NetBSD Problem Report #36636

From gcw@primenet.com.au  Thu Jul 12 10:53:12 2007
Return-Path: <gcw@primenet.com.au>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id D0EC463B8E6
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 12 Jul 2007 10:53:12 +0000 (UTC)
Message-Id: <20070712090629.1142.qmail@g.primenet.com.au>
Date: 12 Jul 2007 19:06:29 +1000
From: gcw@primenet.com.au
Reply-To: gcw@primenet.com.au
To: gnats-bugs@NetBSD.org
Subject: envstat accessing freed memory (and failing)
X-Send-Pr-Version: 3.95

>Number:         36636
>Category:       bin
>Synopsis:       envstat accessing freed memory (and failing)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    xtraeme
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 12 10:55:00 +0000 2007
>Closed-Date:    Thu Jul 12 18:25:10 +0000 2007
>Last-Modified:  Thu Jul 12 18:35:01 +0000 2007
>Originator:     Geoff C. Wing
>Release:        NetBSD 4.99.23 (2007-07-12)
>Organization:
>Environment:
System: NetBSD g.primenet.com.au 4.99.23 NetBSD 4.99.23 (G) #0: Thu Jul 12 10:52:59 EST 2007 gcw@g.primenet.com.au:/usr/netbsd/src/sys/arch/i386/compile/G i386
Architecture: i386
Machine: i386
>Description:
	On an ASUS MB (P5LD2) with aiboost, my /etc/envstat.conf has
		aiboost0:MB Temperature:critmax:50
		aiboost0:MB Temperature:critmin:30
		aiboost0:CPU Temperature:critmax:333.15
		aiboost0:CPU Temperature:critmin:303.15
		aiboost0:CPU FAN Speed:critmin:3000
	to give
	   CPU Temperature:     56.500 degC  max:   60.000 degC  min:   30.000 degC
	    MB Temperature:     41.000 degC  max:   50.000 degC  min:   30.000 degC
	 ...
	     CPU FAN Speed:       3391 RPM   min:     3000 RPM
	 ...

	$ envstat -x
	 ...
        <key>aiboost0</key>
        <array>
                <dict>
                        <key>critical-max-limit</key>
                        <integer>333150000</integer>
                        <key>critical-min-limit</key>
                        <integer>303150000</integer>
                        <key>cur-value</key>
                        <integer>329650000</integer>
                        <key>description</key>
                        <string>CPU Temperature</string>
                        <key>monitoring-supported</key>
                        <true/>
                        <key>state</key>
                        <string>valid</string>
                        <key>type</key>
                        <string>Temperature</string>
                </dict>
                <dict>
                        <key>critical-max-limit</key>
                        <integer>323150000</integer>
                        <key>critical-min-limit</key>
                        <integer>303150000</integer>
                        <key>cur-value</key>
                        <integer>314150000</integer>
                        <key>description</key>
                        <string>MB Temperature</string>
                        <key>monitoring-supported</key>
                        <true/>
                        <key>state</key>
                        <string>valid</string>
                        <key>type</key>
                        <string>Temperature</string>
                </dict>
	 ...

>How-To-Repeat:
	Maybe possible for everyone?
>Fix:
	find_sensors() has this little section
    ------
        gesen = esen;
	...
out:                    
        free(esen);         
        return rval;
    ------
	however it's referencing that memory via gesen later on.  So, let's
	not reference freed memory.

--- usr.sbin/envstat/envstat.c.org	2007-07-06 11:35:29.000000000 +1000
+++ usr.sbin/envstat/envstat.c	2007-07-12 19:03:03.000000000 +1000
@@ -208,6 +208,8 @@
 		free(userreq);
 	if (mydevname)
 		free(mydevname);
+	if (gesen)
+		free(gesen);
 	(void)close(fd);
 	return rval;
 }
@@ -693,7 +695,8 @@
 	}

 out:
-	free(esen);
+	if (rval)
+		free(esen);
 	return rval;
 }


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: bin-bug-people->xtraeme
Responsible-Changed-By: xtraeme@netbsd.org
Responsible-Changed-When: Thu, 12 Jul 2007 15:07:24 +0000
Responsible-Changed-Why:
mine


State-Changed-From-To: open->closed
State-Changed-By: xtraeme@netbsd.org
State-Changed-When: Thu, 12 Jul 2007 18:25:10 +0000
State-Changed-Why:
Fixed, thanks.


From: Juan Romero Pardines <xtraeme@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/36636 CVS commit: src/usr.sbin/envstat
Date: Thu, 12 Jul 2007 18:24:35 +0000 (UTC)

 Module Name:	src
 Committed By:	xtraeme
 Date:		Thu Jul 12 18:24:35 UTC 2007

 Modified Files:
 	src/usr.sbin/envstat: envstat.c

 Log Message:
 - Do not refrence memory already freed, thanks to Geoff C. Wing for
   the analysis. Closes PR bin/36636.
 - Also use the longest string for the column alignment counting all
   sensors available from all devices, not per-device.

 Thanks to rmind@ for help.


 To generate a diff of this commit:
 cvs rdiff -r1.30 -r1.31 src/usr.sbin/envstat/envstat.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.