NetBSD Problem Report #37190

From martin@duskware.de  Wed Oct 24 07:52:28 2007
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id BBB6C63B8FE
	for <gnats-bugs@gnats.netbsd.org>; Wed, 24 Oct 2007 07:52:27 +0000 (UTC)
Message-Id: <20071023202136.DBC1F63B8FE@narn.NetBSD.org>
Date: Tue, 23 Oct 2007 20:21:36 +0000 (UTC)
From: krille@users.sf.net
Reply-To: krille@users.sf.net
To: netbsd-bugs-owner@NetBSD.org
Subject: Package sysutils/tree is badly broken
X-Send-Pr-Version: www-1.0

>Number:         37190
>Category:       pkg
>Synopsis:       Package sysutils/tree is badly broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    cjs
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 24 07:55:00 +0000 2007
>Closed-Date:    Thu Nov 08 06:07:23 +0000 2007
>Last-Modified:  Thu Nov 08 06:07:23 +0000 2007
>Originator:     Christian Hattemer
>Release:        -current
>Organization:
>Environment:
NetBSD seafood 4.99.9 NetBSD 4.99.9 (SEAFOOD) #5: Thu May 10 21:57:50 CEST 2007
>Description:
The package sysutils/tree is badly broken.

It installs the files outside of /usr/pkg. The binary goes to /usr/bin/tree, the man-page goes to /usr/man/man1/tree.1. This is all hardcoded in the Makefile which comes with the distfile.

That Makefile also overrides CFLAGS an has some "Uncomment for $OS:" mechanism to select different flags.

Additionaly the PLIST is empty. This means that a binary package will also be empty.
>How-To-Repeat:
cd /usr/pkgsrc/sysutils/tree
make package
See that it installs in the wrong places and creates an empty package.
>Fix:
Package it correctly.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->cjs
Responsible-Changed-By: snj@netbsd.org
Responsible-Changed-When: Thu, 25 Oct 2007 14:28:10 +0000
Responsible-Changed-Why:
Over to maintainer.


From: Klaus Heinz <k.heinz@oktsieben.kh-22.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/37190 (Package sysutils/tree is badly broken)
Date: Thu, 25 Oct 2007 18:33:38 +0200

 snj@netbsd.org wrote:
 > Synopsis: Package sysutils/tree is badly broken

 After the changes Thomas Klausner applied the "broken-ness" should be
 greatly reduced.

 ciao
      Klaus

From: Christian Hattemer <c.hattemer@arcor.de>
To: gnats-bugs@NetBSD.org
Cc: cjs@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/37190 (Package sysutils/tree is badly broken)
Date: Sun, 28 Oct 2007 01:07:37 +0200

 Klaus Heinz wrote:

 >  After the changes Thomas Klausner applied the "broken-ness" should be
 >  greatly reduced.

 If the CFLAGS definition of the Makefile would be patched to use ?= then it 
 would also honour pkgsrc CFLAGS.

 Otherwise it looks fine now, thanks.

 -- 
 Bye, Chris

From: Klaus Heinz <heinz@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/37190 CVS commit: pkgsrc/sysutils/tree
Date: Sun, 28 Oct 2007 10:10:10 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	heinz
 Date:		Sun Oct 28 10:10:10 UTC 2007

 Modified Files:
 	pkgsrc/sysutils/tree: Makefile distinfo
 	pkgsrc/sysutils/tree/patches: patch-ab

 Log Message:
 Made CFLAGS and LDFLAGS overridable through the pkgsrc Makefile.
 Proposed by Christian Hattemer in PR pkg/37190.


 To generate a diff of this commit:
 cvs rdiff -r1.3 -r1.4 pkgsrc/sysutils/tree/Makefile \
     pkgsrc/sysutils/tree/distinfo
 cvs rdiff -r1.2 -r1.3 pkgsrc/sysutils/tree/patches/patch-ab

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Klaus Heinz <k.heinz@oktsieben.kh-22.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/37190 (Package sysutils/tree is badly broken)
Date: Sun, 28 Oct 2007 12:32:39 +0100

 Christian Hattemer wrote:

 > If the CFLAGS definition of the Makefile would be patched to use ?= then it 
 > would also honour pkgsrc CFLAGS.

 The latest changes should allow that. It would be good if someone would
 try to submit patch-aa and patch-ab back to the upstream maintainer.
 Both are not specific to pkgsrc and should be acceptable as they are.

 ciao
      Klaus

From: Christian Hattemer <c.hattemer@arcor.de>
To: gnats-bugs@NetBSD.org
Cc: cjs@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/37190 (Package sysutils/tree is badly broken)
Date: Mon, 29 Oct 2007 19:51:39 +0100

 Klaus Heinz wrote:

 >  The latest changes should allow that. It would be good if someone would
 >  try to submit patch-aa and patch-ab back to the upstream maintainer.
 >  Both are not specific to pkgsrc and should be acceptable as they are.

 Is the $(DESTDIR) stuff also supposed to be submitted? The variable would be 
 undefined when the Makefile is used standalone. I might submit that eventually then.

  From my POV the PR may be closed now.

 -- 
 Bye, Chris

From: Klaus Heinz <k.heinz@oktsieben.kh-22.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/37190 (Package sysutils/tree is badly broken)
Date: Tue, 30 Oct 2007 00:04:37 +0100

 Christian Hattemer wrote:

 > Is the $(DESTDIR) stuff also supposed to be submitted? The variable would 
 > be undefined when the Makefile is used standalone. I might submit that 
 > eventually then.

 Yes, DESTDIR is the common variable name many other package systems use to
 let you build the package without actual installation to the running
 system.

 Basically, patch-aa marks a few lines as specific to Linux and patch-ab
 introduces some variables to make it possible overriding them on the
 command line. The default values are the same as before so the behaviour
 should not change compared to the situation without the patches.

 ciao
      Klaus

State-Changed-From-To: open->closed
State-Changed-By: jnemeth@netbsd.org
State-Changed-When: Thu, 08 Nov 2007 06:07:23 +0000
State-Changed-Why:
submitter says the pkg is fixed now, thanks for the PR!


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.