NetBSD Problem Report #37209

From simonb@thistledown.com.au  Thu Oct 25 15:59:01 2007
Return-Path: <simonb@thistledown.com.au>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id F3C1763B89A
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 25 Oct 2007 15:59:00 +0000 (UTC)
Message-Id: <20071025155859.5DD82AFD03@thoreau.thistledown.com.au>
Date: Fri, 26 Oct 2007 01:58:59 +1000 (EST)
From: Simon Burge <simonb@NetBSD.org>
Reply-To: Simon Burge <simonb@NetBSD.org>
To: gnats-bugs@NetBSD.org
Subject: missed files in postinstal
X-Send-Pr-Version: 3.95

>Number:         37209
>Category:       install
>Synopsis:       missed files in postinstal
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 25 16:00:00 +0000 2007
>Last-Modified:  Sat Nov 24 11:15:01 +0000 2007
>Originator:     Simon Burge
>Release:        NetBSD 4.0_RC3
>Organization:
>Environment:
System: NetBSD thoreau 4.0_RC3 NetBSD 4.0_RC3 (THOREAU.MP-4.noacpi) #0: Thu Oct 25 17:54:25 EST 2007 simonb@thoreau:/usr/obj/sys/arch/i386/compile/THOREAU.MP-4.noacpi i386
Architecture: i386
Machine: i386
>Description:
	postinstall seems to not worry about the following files:

		etc/powerd/scripts/acadapter
		etc/powerd/scripts/lid_switch
		etc/powerd/scripts/sleep_button
		etc/shrc
		etc/skel/.shrc

	At least shrc and skel/.shrc should be checked.  The others I'm not
	too sure about?

	This was from a netbsd-3 to netbsd-4 upgrade.

>How-To-Repeat:
	postinstall -s /src/dir fix

>Fix:
	None given.

>Audit-Trail:
From: matthew green <mrg@eterna.com.au>
To: gnats-bugs@NetBSD.org
Cc: install-manager@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: re: install/37209: missed files in postinstal 
Date: Fri, 26 Oct 2007 04:31:29 +1000

 did your system actually fail to boot because of this?  if not,
 then this is etcupdate(8)'s job, not postinstall(8).


 .mrg.

From: jnemeth@victoria.tc.ca (John Nemeth)
To: matthew green <mrg@eterna.com.au>, gnats-bugs@NetBSD.org
Cc: install-manager@NetBSD.org, gnats-admin@NetBSD.org,
	netbsd-bugs@NetBSD.org
Subject: re: install/37209: missed files in postinstal
Date: Thu, 25 Oct 2007 22:29:05 -0700

 On Mar 17, 11:07pm, matthew green wrote:
 } 
 } did your system actually fail to boot because of this?  if not,
 } then this is etcupdate(8)'s job, not postinstall(8).

      Umm, there are lots of things in postinstall that aren't required
 to make sure the system will boot.  By defacto, postinstall does
 everything it can to upgrade a system (the only major things it doesn't
 do is create new users and groups).

      The problem with this PR is that it is extremely vague.  Is
 postinstall failing to add files, fix them, delete them, or what?  All
 we have is a list of files, we don't know what the submitter is
 expecting postinstall to do with them.

 }-- End of excerpt from matthew green

From: Simon Burge <simonb@NetBSD.org>
To: jnemeth@victoria.tc.ca (John Nemeth)
Cc: matthew green <mrg@eterna.com.au>, gnats-bugs@NetBSD.org,
	install-manager@NetBSD.org, gnats-admin@NetBSD.org,
	netbsd-bugs@NetBSD.org
Subject: Re: install/37209: missed files in postinstal 
Date: Fri, 26 Oct 2007 16:25:31 +1000

 John Nemeth wrote:

 > On Mar 17, 11:07pm, matthew green wrote:
 > } 
 > } did your system actually fail to boot because of this?  if not,
 > } then this is etcupdate(8)'s job, not postinstall(8).
 > 
 >      Umm, there are lots of things in postinstall that aren't required
 > to make sure the system will boot.  By defacto, postinstall does
 > everything it can to upgrade a system (the only major things it doesn't
 > do is create new users and groups).
 > 
 >      The problem with this PR is that it is extremely vague.  Is
 > postinstall failing to add files, fix them, delete them, or what?  All
 > we have is a list of files, we don't know what the submitter is
 > expecting postinstall to do with them.

 It was a bit late at night when I submitted the PR...

 The files I listed are in the netbsd-4 etc.tgz set and weren't present
 on my existing system.  I would have expected postinstall (or maybe it
 should be etcupdate's job - but I've only ever used postinstall and
 etcupdate isn't referenced in the install notes) to have copied these
 files in to /etc.

 Starting a single user shell complains about the lack of /etc/shrc, so I
 would have thought postinstall should address that.

 Simon.

From: Pavel Cahyna <pavel@NetBSD.org>
To: Simon Burge <simonb@NetBSD.org>
Cc: John Nemeth <jnemeth@victoria.tc.ca>,
	matthew green <mrg@eterna.com.au>, gnats-bugs@NetBSD.org,
	install-manager@NetBSD.org, gnats-admin@NetBSD.org,
	netbsd-bugs@NetBSD.org
Subject: Re: install/37209: missed files in postinstal
Date: Fri, 23 Nov 2007 16:35:59 +0100

 On Fri, Oct 26, 2007 at 04:25:31PM +1000, Simon Burge wrote:
 > Starting a single user shell complains about the lack of /etc/shrc, so I
 > would have thought postinstall should address that.

 It seems that you have you updated /root/.shrc without updating the files
 in /etc.

 Pavel

From: Pavel Cahyna <pavel@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/37209 CVS commit: src/etc
Date: Sat, 24 Nov 2007 11:14:45 +0000 (UTC)

 Module Name:	src
 Committed By:	pavel
 Date:		Sat Nov 24 11:14:43 UTC 2007

 Modified Files:
 	src/etc/root: dot.shrc
 	src/etc/skel: dot.shrc

 Log Message:
 Source /etc/shrc only if it exists. Inspired by PR install/37209.


 To generate a diff of this commit:
 cvs rdiff -r1.7 -r1.8 src/etc/root/dot.shrc
 cvs rdiff -r1.2 -r1.3 src/etc/skel/dot.shrc

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search