NetBSD Problem Report #37391

From martin@duskware.de  Thu Nov 15 22:32:45 2007
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 6347863B867
	for <gnats-bugs@gnats.netbsd.org>; Thu, 15 Nov 2007 22:32:45 +0000 (UTC)
Message-Id: <20071115222002.506D063B867@narn.NetBSD.org>
Date: Thu, 15 Nov 2007 22:20:02 +0000 (UTC)
From: Lloyd.Parkes@ird.govt.nz
Reply-To: Lloyd.Parkes@ird.govt.nz
To: netbsd-bugs-owner@NetBSD.org
Subject: security/tripwire PRE_ROOT_CMD chmods the wrong directory
X-Send-Pr-Version: www-1.0

>Number:         37391
>Category:       pkg
>Synopsis:       security/tripwire PRE_ROOT_CMD chmods the wrong directory
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 15 22:35:00 +0000 2007
>Closed-Date:    Fri Nov 16 00:17:02 +0000 2007
>Last-Modified:  Fri Nov 16 00:20:01 +0000 2007
>Originator:     Lloyd Parkes
>Release:        pkgsrc-current
>Organization:
Inland Revenue
>Environment:
SunOS xxx.ird.govt.nz 5.9 Generic_122300-14 sun4u sparc SUNW,UltraAX-i2
cc: Sun C 5.8 Patch 121015-05 2007/08/01

>Description:
The security/tripwire/Makefile sets a PRE_ROOT_CMD of ${CHMOD} -R go+rwx ${WRKDIR}. This doesn't work because it recurses down into work/.tools and fails to chmod the system utilities symlinked there. Using WRKSRC instead of WRKDIR should be fine.
>How-To-Repeat:
Type bmake install as an unprivileged user.
>Fix:
Patch to be emailed later to avoid whitespace mangling.

>Release-Note:

>Audit-Trail:
From: Lloyd Parkes <Lloyd.Parkes@ird.govt.nz>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/37391: security/tripwire PRE_ROOT_CMD chmods the wrong directory
Date: Fri, 16 Nov 2007 11:37:40 +1300

 This is a multi-part message in MIME format.
 --------------070209080305040901000402
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit

 Attached is for the Makefile.

 -- 
 Lloyd Parkes
 Senior Systems Programmer
 Open Systems
 Ph: +64 4 890 2437

 --------------070209080305040901000402
 Content-Type: text/x-patch;
  name="tripwire.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="tripwire.patch"

 $NetBSD$

 --- Makefile.orig	2007-11-02 12:09:13.375213000 +1300
 +++ Makefile
 @@ -30,7 +30,7 @@ pre-configure:
  		-e 's|@PKG_SYSCONFDIR@|${PKG_SYSCONFDIR}|g'		\
  		${WRKSRC}/include/config.h.in > ${WRKSRC}/include/config.h

 -PRE_ROOT_CMD=	${CHMOD} -R go+rwx ${WRKDIR}
 +PRE_ROOT_CMD=	${CHMOD} -R go+rwx ${WRKSRC}

  post-install:
  	${INSTALL_DATA} ${WRKSRC}/docs/designdoc.ps ${PREFIX}/share/doc/tripwire

 --------------070209080305040901000402--

State-Changed-From-To: open->closed
State-Changed-By: rillig@netbsd.org
State-Changed-When: Fri, 16 Nov 2007 00:17:02 +0000
State-Changed-Why:
Patch applied, thanks for the PR.


From: Roland Illig <rillig@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: PR/37391 CVS commit: pkgsrc/security/tripwire
Date: Fri, 16 Nov 2007 00:16:30 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	rillig
 Date:		Fri Nov 16 00:16:29 UTC 2007

 Modified Files:
 	pkgsrc/security/tripwire: Makefile

 Log Message:
 By default, chmod follows symlinks, which is not intended here. Patch by
 Lloyd Parkes in PR 37391.


 To generate a diff of this commit:
 cvs rdiff -r1.25 -r1.26 pkgsrc/security/tripwire/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.