NetBSD Problem Report #37633

From dauphin@enst.fr  Fri Dec 28 11:29:20 2007
Return-Path: <dauphin@enst.fr>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 66FAB63B852
	for <gnats-bugs@gnats.netbsd.org>; Fri, 28 Dec 2007 11:29:20 +0000 (UTC)
Message-Id: <1198841354.27133@bi.enst.fr>
Date: Fri, 28 Dec 2007 12:29:14 +0100
From: "Gilles Dauphin" <dauphin@enst.fr>
To: "gnats bugs" <gnats-bugs@NetBSD.org>
Subject: graphics/imlib2 visibility attribute gcc4 solaris32/64
X-Send-Pr-Version: gtk-send-pr 0.4.8 
X-GNATS-Notify:

>Number:         37633
>Category:       pkg
>Synopsis:       graphics/imlib2 visibility attribute gcc4 solaris32/64
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 28 11:30:00 +0000 2007
>Closed-Date:    Mon Aug 05 23:55:39 +0000 2019
>Last-Modified:  Mon Aug 05 23:55:39 +0000 2019
>Originator:     Gilles Dauphin
>Release:        SunOS 5.10 i86pc
>Organization:
ENST 
>Environment:


System: SunOS bi.enst.fr 5.10 Generic_120012-14 i86pc


>Description:


the visibility attribute is definitively broken in Solaris's gcc >=4
either in 32 or in 64 bit mode.
Suppress the usage of visibility_hiding in all package for solaris.


>How-To-Repeat:


bmake 
all package with visibility_hiding


>Fix:


kind (imlib2 example) of patch is:

[root@redhot 1058] diff -u src/lib/common.h.orig src/lib/common.h                                    
--- src/lib/common.h.orig       Tue Apr 10 00:40:40 2007
+++ src/lib/common.h    Fri Dec 28 12:16:50 2007
@@ -15,7 +15,7 @@
 #include <sys/types.h>
 #endif

-#if defined(__GNUC__) && (__GNUC__ >= 4)
+#if defined(__GNUC__) && (__GNUC__ >= 4) && !defined(__sun__)
 #define __hidden __attribute__((visibility("hidden")))
 #else
 #define __hidden


-------------------------------------------------
look also at Xfuncproto.h
the package x11/libXft is broken because of this header in 32bit mode.


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: obache@narn.netbsd.org
Responsible-Changed-When: Sun, 20 Jan 2008 07:47:18 +0000
Responsible-Changed-Why:
Problem on Solaris.


State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 23 Jan 2011 05:48:52 +0000
State-Changed-Why:
Is this still a problem?


From: Tim Zingelman <zingelman@gmail.com>
To: gnats-bugs@netbsd.org
Cc: solaris-pkg-people@netbsd.org, pkgsrc-bugs@netbsd.org, 
	gnats-admin@netbsd.org, dholland@netbsd.org, Gilles Dauphin <dauphin@enst.fr>
Subject: Re: pkg/37633 (graphics/imlib2 visibility attribute gcc4 solaris32/64)
Date: Sun, 23 Jan 2011 14:00:15 -0600

 On Sat, Jan 22, 2011 at 11:48 PM,  <dholland@netbsd.org> wrote:
 > Synopsis: graphics/imlib2 visibility attribute gcc4 solaris32/64
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: dholland@NetBSD.org
 > State-Changed-When: Sun, 23 Jan 2011 05:48:52 +0000
 > State-Changed-Why:
 > Is this still a problem?

 I found this:  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46713
 which suggests it is still an issue.

 Perhaps this could be fixed in the wrappers rather than patching every package?

  - Tim

State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 24 Jan 2011 00:01:00 +0000
State-Changed-Why:
Blah.
Yeah, fixing it in the wrappers sounds like a good plan.


State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 05 Aug 2019 23:55:39 +0000
State-Changed-Why:
Assuming this is fixed with newer compilers, which are available for illumos-based OSes.


>Unformatted:

Home	PR Database Search