NetBSD Problem Report #37740

From martin@duskware.de  Thu Jan 10 18:06:37 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id F2D0063BAF8
	for <gnats-bugs@gnats.netbsd.org>; Thu, 10 Jan 2008 18:06:36 +0000 (UTC)
Message-Id: <20080110150702.6E6E663BAF8@narn.NetBSD.org>
Date: Thu, 10 Jan 2008 15:07:02 +0000 (UTC)
From: daniel@NetBSD.org
Reply-To: daniel@NetBSD.org
To: netbsd-bugs-owner@NetBSD.org
Subject: open-vm-tools misses pcre build dependency
X-Send-Pr-Version: www-1.0

>Number:         37740
>Category:       pkg
>Synopsis:       open-vm-tools misses pcre build dependency
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 10 18:10:00 +0000 2008
>Closed-Date:    Tue Aug 06 14:58:59 +0000 2019
>Last-Modified:  Tue Aug 06 14:58:59 +0000 2019
>Originator:     Daniel de Kok
>Release:        4.0
>Organization:
>Environment:
$ uname -a
NetBSD mindbender-nbsd.taickim.net 4.0 NetBSD 4.0 (GENERIC.NOACPI) #0: Sun Dec 16 00:56:55 PST 2007  builds@wb34:/home/builds/ab/netbsd-4-0-RELEASE/i386/200712160005Z-obj/home/builds/ab/netbsd-4-0-RELEASE/src/sys/arch/i386/compile/GENERIC.NOACPI i386
>Description:
Building open-vm-tools on a system where pcre was not installed, building open-vm-tools gave the following error:

---
=> Applying pkgsrc patches for open-vm-tools-2007.09.04.56574
===> Creating toolchain wrappers for open-vm-tools-2007.09.04.56574
ERROR: pcre is not installed; can't buildlink files.
*** Error code 1
---
>How-To-Repeat:
Build open-vm-tools on a machine that does not have pcre installed.
>Fix:
The following one-line fix made it build fine:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/open-vm-tools/Makefile,v
retrieving revision 1.3
diff -b -u -r1.3 Makefile
--- Makefile    11 Nov 2007 11:02:11 -0000      1.3
+++ Makefile    10 Jan 2008 15:04:53 -0000
@@ -22,6 +22,7 @@

 .include "../../security/openssl/buildlink3.mk"
 .include "../../x11/gtk2/buildlink3.mk"
+.include "../../devel/pcre/buildlink3.mk"
 .include "../../x11/libXinerama/buildlink3.mk"
 .include "../../x11/libXrandr/buildlink3.mk"
 .include "../../x11/libXrender/buildlink3.mk"

>Release-Note:

>Audit-Trail:
From: "Daniel de Kok" <me@danieldk.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/37740: open-vm-tools misses pcre build dependency
Date: Thu, 10 Jan 2008 19:26:39 +0100

 BTW. Sorry for messing up the dependency order in the patch.

From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/37740: open-vm-tools misses pcre build dependency
Date: Thu, 10 Jan 2008 12:28:42 -0600 (CST)

 > => Applying pkgsrc patches for open-vm-tools-2007.09.04.56574
 > ===> Creating toolchain wrappers for open-vm-tools-2007.09.04.56574
 > ERROR: pcre is not installed; can't buildlink files.

 This type of problem is caused by a dependency already installed on your 
 system is good enough so the buildlinking is not done. See below.

 > >Fix:
 > The following one-line fix made it build fine:
 > 
 > Index: Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/sysutils/open-vm-tools/Makefile,v
 > retrieving revision 1.3
 > diff -b -u -r1.3 Makefile
 > --- Makefile    11 Nov 2007 11:02:11 -0000      1.3
 > +++ Makefile    10 Jan 2008 15:04:53 -0000
 > @@ -22,6 +22,7 @@
 >  
 >  .include "../../security/openssl/buildlink3.mk"
 >  .include "../../x11/gtk2/buildlink3.mk"
 > +.include "../../devel/pcre/buildlink3.mk"

 If open-vm-tools doesn't need pcre directly, then this is probably not the 
 correct fix.

 What does the following tell us?

 pkg_info -n gtk2+ | egrep 'Information|glib'

 pkg_info -n glib2 | egrep 'Information|pcre'

 The pcre buildlink was included on 08-Nov-07 but the dependency was not 
 bumped. This was done during the update to 2.14.3.

 This has been reported (not including my own similar reports):

 http://archive.netbsd.se/?ml=netbsd-tech-pkg&a=2007-11&m=5701705

 and

 http://archive.netbsd.se/?ml=netbsd-current-users&a=2007-11&m=5735883

 My recommendation is to abuse BUILDLINK_API_DEPENDS.glib2 for this. See my 
 email at http://archive.netbsd.se/?ml=netbsd-tech-pkg&a=2008-01&m=6034802
 (I has posted about this other times also, but never received any answer 
 to this ongoing problem.)

 (As it is the BUILDLINK_ABI_DEPENDS.glib2 is wrong, since the ABI changed 
 when g_once_init_leave was added in glib 2.13.7 from July 2007 -- I 
 think.)



   Jeremy C. Reed

From: "Daniel de Kok" <me@danieldk.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/37740: open-vm-tools misses pcre build dependency
Date: Thu, 10 Jan 2008 19:48:00 +0100

 On 1/10/08, Jeremy C. Reed <reed@reedmedia.net> wrote:
 >  The pcre buildlink was included on 08-Nov-07 but the dependency was not
 >  bumped. This was done during the update to 2.14.3.

 Thanks, that clears things up!

 -- Daniel

From: OBATA Akio <obache@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/37740: open-vm-tools misses pcre build dependency
Date: Sun, 20 Jan 2008 22:18:12 +0900

 On Fri, 11 Jan 2008 03:30:05 +0900, Jeremy C. Reed <reed@reedmedia.net> 
 wrote:

 >  If open-vm-tools doesn't need pcre directly, then this is probably not 
 the
 >  correct fix.
 >
 >  What does the following tell us?
 >
 >  pkg_info -n gtk2+ | egrep 'Information|glib'
 >
 >  pkg_info -n glib2 | egrep 'Information|pcre'
 >
 >  The pcre buildlink was included on 08-Nov-07 but the dependency was not
 >  bumped. This was done during the update to 2.14.3.
 >
 >  This has been reported (not including my own similar reports):
 >
 >  http://archive.netbsd.se/?ml=netbsd-tech-pkg&a=2007-11&m=5701705
 >
 >  and
 >
 >  http://archive.netbsd.se/?ml=netbsd-current-users&a=2007-11&m=5735883
 >
 >  My recommendation is to abuse BUILDLINK_API_DEPENDS.glib2 for this. See 
 my
 >  email at http://archive.netbsd.se/?ml=netbsd-tech-pkg&a=2008-01&m=6034802
 >  (I has posted about this other times also, but never received any answer
 >  to this ongoing problem.)

 Following patch may fix this problem.

 Index: buildlink3.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/glib2/buildlink3.mk,v
 retrieving revision 1.14
 diff -u -r1.14 buildlink3.mk
 --- buildlink3.mk       8 Nov 2007 19:52:21 -0000       1.14
 +++ buildlink3.mk       20 Jan 2008 13:12:02 -0000
 @@ -17,9 +17,18 @@
  BUILDLINK_PKGSRCDIR.glib2?=    ../../devel/glib2
  .endif # GLIB2_BUILDLINK3_MK

 +GLIB2_USING_BUNDLED_PCRE= \
 +        if ${PKG_INFO} -qe 'glib2<=2.14.2'; then                       \
 +                ${ECHO} yes;                                           \
 +        else                                                           \
 +                ${ECHO} no;                                            \
 +        fi
 +
  .include "../../converters/libiconv/buildlink3.mk"
  .include "../../devel/gettext-lib/buildlink3.mk"
 +.if ${GLIB2_USING_BUNDLED_PCRE} == "no"
  .include "../../devel/pcre/buildlink3.mk"
 +.endif
  .include "../../mk/pthread.buildlink3.mk"

  BUILDLINK_DEPTH:=      ${BUILDLINK_DEPTH:S/+$//}


 -- 
 "Of course I love NetBSD":-)
 OBATA Akio / obache@NetBSD.org

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Tue, 06 Aug 2019 14:58:59 +0000
State-Changed-Why:
glib2 users will now get a pcre dependency. thanks for the report and for whoever fixed it.


>Unformatted:

Home	PR Database Search