NetBSD Problem Report #37967

From martin@duskware.de  Tue Feb  5 22:54:46 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 0E80863B853
	for <gnats-bugs@gnats.netbsd.org>; Tue,  5 Feb 2008 22:54:46 +0000 (UTC)
Message-Id: <20080205224849.EC21D63BAF8@narn.NetBSD.org>
Date: Tue,  5 Feb 2008 22:48:49 +0000 (UTC)
From: hbent@cs.oberlin.edu
Reply-To: hbent@cs.oberlin.edu
To: netbsd-bugs-owner@NetBSD.org
Subject: add some SMART attributes to atactl
X-Send-Pr-Version: www-1.0

>Number:         37967
>Category:       bin
>Synopsis:       add some SMART attributes to atactl
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 05 22:55:00 +0000 2008
>Closed-Date:    Mon Aug 25 00:52:47 +0000 2008
>Last-Modified:  Mon Aug 25 00:52:47 +0000 2008
>Originator:     Henry Bent
>Release:        NetBSD 4.99.51
>Organization:
>Environment:
NetBSD aelfric 4.99.51 NetBSD 4.99.51 (AELFRIC) #1: Tue Jan 29 04:01:25 EST 2008  root@aelfric:/usr/obj/src-current/sys/arch/i386/compile/AELFRIC i386
>Description:
atactl does not label SMART attributes 189 and 190, which are "High Fly Writes" and "Airflow Temperature."  Note that 190 will return values identical to 194 ("Temperature"), so I marked it as a valid reporter of temperature.
>How-To-Repeat:
n/a
>Fix:
--- sbin/atactl/atactl.c.orig   2007-12-19 15:26:34.000000000 -0500
+++ sbin/atactl/atactl.c        2008-02-05 17:38:00.000000000 -0500
@@ -272,6 +272,8 @@
        {  10,          "Spin retry count", NULL },
        {  11,          "Calibration retry count", NULL },
        {  12,          "Device power cycle count", NULL },
+       { 189,          "High Fly Writes", NULL },
+       { 190,          "Airflow Temperature", device_smart_temp },
        { 191,          "Gsense error rate", NULL },
        { 192,          "Power-off retract count", NULL },
        { 193,          "Load cycle count", NULL },

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/37967 CVS commit: src/sbin/atactl
Date: Mon, 25 Aug 2008 00:45:56 +0000 (UTC)

 Module Name:	src
 Committed By:	dholland
 Date:		Mon Aug 25 00:45:56 UTC 2008

 Modified Files:
 	src/sbin/atactl: atactl.c

 Log Message:
 Add two missing SMART attributes; PR 37967 from Henry Bent. Also add a
 third I found while digging around, and fix one whose name was typoed.


 To generate a diff of this commit:
 cvs rdiff -r1.51 -r1.52 src/sbin/atactl/atactl.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 25 Aug 2008 00:52:47 +0000
State-Changed-Why:
Added, thanks.


>Unformatted:

Home	PR Database Search