NetBSD Problem Report #38135
From martin@duskware.de Sun Mar 2 10:16:05 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by narn.NetBSD.org (Postfix) with ESMTP id 8E02A63B90D
for <gnats-bugs@gnats.netbsd.org>; Sun, 2 Mar 2008 10:16:05 +0000 (UTC)
Message-Id: <20080302011814.6085E63B90D@narn.NetBSD.org>
Date: Sun, 2 Mar 2008 01:18:14 +0000 (UTC)
From: ad@netbsd.org
Reply-To: ad@netbsd.org
To: netbsd-bugs-owner@NetBSD.org
Subject: vfs_busy/vfs_trybusy confusion
X-Send-Pr-Version: www-1.0
>Number: 38135
>Category: kern
>Synopsis: vfs_busy/vfs_trybusy confusion
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: ad
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Mar 02 10:20:00 +0000 2008
>Closed-Date: Wed Apr 30 12:49:56 +0000 2008
>Last-Modified: Thu May 01 12:20:01 +0000 2008
>Originator: Andrew Doran
>Release: 5.99.55
>Organization:
The NetBSD Project
>Environment:
n/a
>Description:
In some places we do vfs_trybusy(), e.g. when getting mount status.
Other threads can have the mount write locked, causing innocuous
operations to fail when they shouldn't.
>How-To-Repeat:
Code inspection.
>Fix:
Review all uses of vfs_busy+vfs_trybusy and/or consider not failing
vfs_trybusy unless the mount is gone or unmount is in progress.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->ad
Responsible-Changed-By: ad@NetBSD.org
Responsible-Changed-When: Tue, 29 Apr 2008 23:33:54 +0000
Responsible-Changed-Why:
take
State-Changed-From-To: open->closed
State-Changed-By: ad@NetBSD.org
State-Changed-When: Tue, 29 Apr 2008 23:51:29 +0000
State-Changed-Why:
fixed
State-Changed-From-To: closed->open
State-Changed-By: ad@NetBSD.org
State-Changed-When: Wed, 30 Apr 2008 12:04:19 +0000
State-Changed-Why:
There are still issues.
State-Changed-From-To: open->closed
State-Changed-By: ad@NetBSD.org
State-Changed-When: Wed, 30 Apr 2008 12:49:56 +0000
State-Changed-Why:
fixed, again
From: Andrew Doran <ad@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/38135 CVS commit: src/sys
Date: Wed, 30 Apr 2008 12:49:18 +0000 (UTC)
Module Name: src
Committed By: ad
Date: Wed Apr 30 12:49:18 UTC 2008
Modified Files:
src/sys/compat/common: vfs_syscalls_20.c
src/sys/compat/netbsd32: netbsd32_compat_20.c
src/sys/compat/osf1: osf1_mount.c
src/sys/compat/ultrix: ultrix_fs.c
src/sys/fs/cd9660: cd9660_vfsops.c
src/sys/fs/filecorefs: filecore_vfsops.c
src/sys/fs/msdosfs: msdosfs_vfsops.c
src/sys/fs/ntfs: ntfs_vfsops.c
src/sys/fs/puffs: puffs_msgif.c
src/sys/fs/union: union_vnops.c
src/sys/kern: vfs_lookup.c vfs_subr.c vfs_subr2.c vfs_syscalls.c
src/sys/miscfs/procfs: procfs_linux.c
src/sys/miscfs/syncfs: sync_vnops.c
src/sys/nfs: nfs_export.c nfs_vfsops.c
src/sys/sys: fstypes.h mount.h
src/sys/ufs/ext2fs: ext2fs_vfsops.c
src/sys/ufs/ffs: ffs_vfsops.c
src/sys/ufs/lfs: lfs_bio.c lfs_syscalls.c lfs_vfsops.c
src/sys/ufs/mfs: mfs_vfsops.c
src/sys/ufs/ufs: ufs_vfsops.c
Log Message:
PR kern/38135 vfs_busy/vfs_trybusy confusion
The previous fix worked, but it opened a window where mounts could have
disappeared from mountlist while the caller was traversing it using
vfs_trybusy(). Fix that.
To generate a diff of this commit:
cvs rdiff -r1.27 -r1.28 src/sys/compat/common/vfs_syscalls_20.c
cvs rdiff -r1.22 -r1.23 src/sys/compat/netbsd32/netbsd32_compat_20.c
cvs rdiff -r1.42 -r1.43 src/sys/compat/osf1/osf1_mount.c
cvs rdiff -r1.47 -r1.48 src/sys/compat/ultrix/ultrix_fs.c
cvs rdiff -r1.58 -r1.59 src/sys/fs/cd9660/cd9660_vfsops.c
cvs rdiff -r1.50 -r1.51 src/sys/fs/filecorefs/filecore_vfsops.c
cvs rdiff -r1.62 -r1.63 src/sys/fs/msdosfs/msdosfs_vfsops.c
cvs rdiff -r1.66 -r1.67 src/sys/fs/ntfs/ntfs_vfsops.c
cvs rdiff -r1.69 -r1.70 src/sys/fs/puffs/puffs_msgif.c
cvs rdiff -r1.31 -r1.32 src/sys/fs/union/union_vnops.c
cvs rdiff -r1.105 -r1.106 src/sys/kern/vfs_lookup.c
cvs rdiff -r1.338 -r1.339 src/sys/kern/vfs_subr.c
cvs rdiff -r1.21 -r1.22 src/sys/kern/vfs_subr2.c
cvs rdiff -r1.353 -r1.354 src/sys/kern/vfs_syscalls.c
cvs rdiff -r1.51 -r1.52 src/sys/miscfs/procfs/procfs_linux.c
cvs rdiff -r1.23 -r1.24 src/sys/miscfs/syncfs/sync_vnops.c
cvs rdiff -r1.35 -r1.36 src/sys/nfs/nfs_export.c
cvs rdiff -r1.197 -r1.198 src/sys/nfs/nfs_vfsops.c
cvs rdiff -r1.21 -r1.22 src/sys/sys/fstypes.h
cvs rdiff -r1.175 -r1.176 src/sys/sys/mount.h
cvs rdiff -r1.132 -r1.133 src/sys/ufs/ext2fs/ext2fs_vfsops.c
cvs rdiff -r1.224 -r1.225 src/sys/ufs/ffs/ffs_vfsops.c
cvs rdiff -r1.112 -r1.113 src/sys/ufs/lfs/lfs_bio.c
cvs rdiff -r1.130 -r1.131 src/sys/ufs/lfs/lfs_syscalls.c
cvs rdiff -r1.258 -r1.259 src/sys/ufs/lfs/lfs_vfsops.c
cvs rdiff -r1.94 -r1.95 src/sys/ufs/mfs/mfs_vfsops.c
cvs rdiff -r1.37 -r1.38 src/sys/ufs/ufs/ufs_vfsops.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi)
To: gnats-bugs@NetBSD.org
Cc: ad@NetBSD.org, netbsd-bugs@netbsd.org, gnats-admin@netbsd.org,
ad@NetBSD.org, ad@netbsd.org
Subject: Re: kern/38135 (vfs_busy/vfs_trybusy confusion)
Date: Thu, 1 May 2008 11:07:25 +0900 (JST)
can you take a look at PR/38141 as well?
as vfs_trybusy now does rw_enter rather than rw_tryenter,
my box deadlocks frequently due to the bug described in the PR.
YAMAMOTO Takashi
From: Andrew Doran <ad@NetBSD.org>
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: gnats-bugs@NetBSD.org
Subject: Re: kern/38135 (vfs_busy/vfs_trybusy confusion)
Date: Thu, 1 May 2008 13:08:22 +0100
On Thu, May 01, 2008 at 11:07:25AM +0900, YAMAMOTO Takashi wrote:
> can you take a look at PR/38141 as well?
>
> as vfs_trybusy now does rw_enter rather than rw_tryenter,
> my box deadlocks frequently due to the bug described in the PR.
Do you know of an easy way to trigger the problem?
Andrew
From: yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi)
To: ad@NetBSD.org
Cc: gnats-bugs@NetBSD.org
Subject: Re: kern/38135 (vfs_busy/vfs_trybusy confusion)
Date: Thu, 1 May 2008 21:16:28 +0900 (JST)
> On Thu, May 01, 2008 at 11:07:25AM +0900, YAMAMOTO Takashi wrote:
>
> > can you take a look at PR/38141 as well?
> >
> > as vfs_trybusy now does rw_enter rather than rw_tryenter,
> > my box deadlocks frequently due to the bug described in the PR.
>
> Do you know of an easy way to trigger the problem?
>
> Andrew
my test case is ./build.sh -j128 on a system with 4 cpus.
/tmp is tmpfs and everything else is nfs.
the following patch is to detect the recursive read-lock condition.
with this, simply mounting a tmpfs is probably enough to trigger a panic.
YAMAMOTO Takashi
Index: subr_lockdebug.c
===================================================================
RCS file: /cvsroot/src/sys/kern/subr_lockdebug.c,v
retrieving revision 1.31
diff -u -p -r1.31 subr_lockdebug.c
--- subr_lockdebug.c 28 Apr 2008 20:24:04 -0000 1.31
+++ subr_lockdebug.c 30 Apr 2008 12:58:06 -0000
@@ -476,7 +476,7 @@ lockdebug_wantlock(volatile void *lock,
if ((ld = lockdebug_lookup(lock, &lk)) == NULL)
return;
- if ((ld->ld_flags & LD_LOCKED) != 0) {
+ if ((ld->ld_flags & LD_LOCKED) != 0 || ld->ld_shares != 0) {
if ((ld->ld_flags & LD_SLEEPER) != 0) {
if (ld->ld_lwp == l)
recurse = true;
@@ -538,8 +538,6 @@ lockdebug_locked(volatile void *lock, ui
ld->ld_flags |= LD_LOCKED;
ld->ld_locked = where;
- ld->ld_cpu = (uint16_t)cpu_number();
- ld->ld_lwp = l;
ld->ld_exwant--;
if ((ld->ld_flags & LD_SLEEPER) != 0) {
@@ -550,6 +548,8 @@ lockdebug_locked(volatile void *lock, ui
TAILQ_INSERT_TAIL(&ld_spinners, ld, ld_chain);
}
}
+ ld->ld_cpu = (uint16_t)cpu_number();
+ ld->ld_lwp = l;
lockdebug_unlock(lk);
}
@@ -585,6 +585,10 @@ lockdebug_unlocked(volatile void *lock,
}
l->l_shlocks--;
ld->ld_shares--;
+ if (ld->ld_lwp == l)
+ ld->ld_lwp = NULL;
+ if (ld->ld_cpu == (uint16_t)cpu_number())
+ ld->ld_cpu = (uint16_t)-1;
} else {
if ((ld->ld_flags & LD_LOCKED) == 0) {
lockdebug_abort1(ld, lk, __func__, "not locked",
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.