NetBSD Problem Report #38260

From martin@duskware.de  Tue Mar 18 18:09:57 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id CCC8E63B89A
	for <gnats-bugs@gnats.netbsd.org>; Tue, 18 Mar 2008 18:09:57 +0000 (UTC)
Message-Id: <20080318180120.BA63C63B89A@narn.NetBSD.org>
Date: Tue, 18 Mar 2008 18:01:20 +0000 (UTC)
From: bseklecki@collaborativefusion.com
Reply-To: bseklecki@collaborativefusion.com
To: netbsd-bugs-owner@NetBSD.org
Subject: Improved carp(4) event logging
X-Send-Pr-Version: www-1.0

>Number:         38260
>Category:       kern
>Synopsis:       Improved carp(4) event logging
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 18 18:10:00 +0000 2008
>Closed-Date:    Sat Jun 06 19:13:15 +0000 2009
>Last-Modified:  Sat Jun 06 19:13:15 +0000 2009
>Originator:     Brian A. Seklecki
>Release:        NetBSD 4/i386 - stable
>Organization:
Collaborative Fusion, Inc.
>Environment:
NetBSD nbsdbuild-i386-netbsd4.admin.lab00.pitbpa0.priv.collaborativefusion.com 4.0_STABLE NetBSD 4.0_STABLE (GENERIC.MP_NOINET6) #6: Tue Mar 18 11:43:22 EDT 2008  root@nbsdbuild-i386-netbsd4.admin.lab00.pitbpa0.priv.collaborativefusion.com:/home/netbsd/obj.i386/99999/sys/arch/i386/compile/GENERIC.MP_NOINET6 i386

>Description:


I have improved upon my original OpenBSD carp(4) logging patch by merging the FreeBSD patch into NetBSD 4.

Original FreeBSD Patch/commit:


Patch:
http://people.collaborativefusion.com/~seklecki/nbsd4-ip_carp.c-logging.patch

Screenshot:
http://people.collaborativefusion.com/~seklecki/nbsd4_carpLoggingPatch_cons_output.png

>From original Post to tech@openbsd.org:                                                                                                                                                                         

 http://archives.neohapsis.com/archives/openbsd/2007-06/1392.html   
>How-To-Repeat:
Use carp(4) -- find the default logging/debugging drastically insufficient.
>Fix:
Apply patch at URL above.

There is some confusion about the CARP_LOG macro so some messages have a duplicate interface name printed right now.

>Release-Note:

>Audit-Trail:
From: Steve Polyack <spolyack@collaborativefusion.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/38260 Improved carp(4) event logging
Date: Fri, 15 May 2009 09:52:08 -0400

 An updated patch which applies cleanly to NetBSD-5.0-RELEASE and avoids 
 the printing of duplicate interface names is available at:

 http://people.collaborativefusion.com/~spolyack/nbsd5-ip_carp.c-logging.patch


 -- 

 Steve Polyack
 Junior Systems Engineer

 Collaborative Fusion, Inc.
 spolyack@collaborativefusion.com
 412-422-3463 x4026

 5849 Forbes Avenue
 Pittsburgh, PA 15217

 ****************************************************************
 IMPORTANT: This message contains confidential information
 and is intended only for the individual named. If the reader of
 this message is not an intended recipient (or the individual
 responsible for the delivery of this message to an intended
 recipient), please be advised that any re-use, dissemination,
 distribution or copying of this message is prohibited. Please
 notify the sender immediately by e-mail if you have received
 this e-mail by mistake and delete this e-mail from your system.
 E-mail transmission cannot be guaranteed to be secure or
 error-free as information could be intercepted, corrupted, lost,
 destroyed, arrive late or incomplete, or contain viruses. The
 sender therefore does not accept liability for any errors or
 omissions in the contents of this message, which arise as a
 result of e-mail transmission.
 ****************************************************************

From: Christos Zoulas <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38260 CVS commit: src/sys/netinet
Date: Wed, 27 May 2009 17:32:32 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Wed May 27 21:32:31 UTC 2009

 Modified Files:
 	src/sys/netinet: ip_carp.c

 Log Message:
 PR/38260: Brian Seklecki: Improve carp logging.


 To generate a diff of this commit:
 cvs rdiff -u -r1.36 -r1.37 src/sys/netinet/ip_carp.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Brian A. Seklecki" <bseklecki@collaborativefusion.com>
To: gnats-bugs@NetBSD.org
Cc: netbsd-bugs <netbsd-bugs@netbsd.org>
Subject: Re: PR/38260 CVS commit: src/sys/netinet
Date: Fri, 29 May 2009 14:14:18 -0400

 This is a MIME-formatted message.  If you see this text it means that your
 E-mail software does not support MIME-formatted messages.

 --=_blackout-54878-1243620859-0001-2
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable

 awesome -- can you request a netbsd-5 releng pullup? Only commiters can
 request >:{.

 ~BAS

 On Wed, 2009-05-27 at 21:35 +0000, Christos Zoulas wrote:
 > The following reply was made to PR kern/38260; it has been noted by GNATS=
 .
 >=20
 > From: Christos Zoulas <christos@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc:=20
 > Subject: PR/38260 CVS commit: src/sys/netinet
 > Date: Wed, 27 May 2009 17:32:32 -0400
 >=20
 >  Module Name:	src
 >  Committed By:	christos
 >  Date:		Wed May 27 21:32:31 UTC 2009
 > =20
 >  Modified Files:
 >  	src/sys/netinet: ip_carp.c
 > =20
 >  Log Message:
 >  PR/38260: Brian Seklecki: Improve carp logging.
 > =20
 >=20
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.36 -r1.37 src/sys/netinet/ip_carp.c
 > =20
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 > =20
 --=20
 Brian A. Seklecki <bseklecki@collaborativefusion.com>
 Collaborative Fusion, Inc.

 --=_blackout-54878-1243620859-0001-2
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Transfer-Encoding: 7bit
 Content-Description: This is a digitally signed message part

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.9 (GNU/Linux)

 iEYEABECAAYFAkogJfoACgkQCne6BNDQ+R8/GwCfSYYt5bI8m0zgVDuk0kL6o0ml
 uo4An3PUEZ2UjmUTj2Vgy2cP5t4y7DBH
 =mins
 -----END PGP SIGNATURE-----

 --=_blackout-54878-1243620859-0001-2--

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, 
	bseklecki@collaborativefusion.com
Cc: pullup-5@netbsd.org
Subject: Re: PR/38260 CVS commit: src/sys/netinet
Date: Fri, 29 May 2009 16:55:45 -0400

 On May 29,  8:05pm, bseklecki@collaborativefusion.com ("Brian A. Seklecki") wrote:
 -- Subject: Re: PR/38260 CVS commit: src/sys/netinet

 Sure, thing. Guys, can we pull this up?

 Thanks,

 christos

 | The following reply was made to PR kern/38260; it has been noted by GNATS.
 | 
 | From: "Brian A. Seklecki" <bseklecki@collaborativefusion.com>
 | To: gnats-bugs@NetBSD.org
 | Cc: netbsd-bugs <netbsd-bugs@netbsd.org>
 | Subject: Re: PR/38260 CVS commit: src/sys/netinet
 | Date: Fri, 29 May 2009 14:14:18 -0400
 | 
 |  This is a MIME-formatted message.  If you see this text it means that your
 |  E-mail software does not support MIME-formatted messages.
 |  
 |  --=_blackout-54878-1243620859-0001-2
 |  Content-Type: text/plain
 |  Content-Transfer-Encoding: quoted-printable
 |  
 |  awesome -- can you request a netbsd-5 releng pullup? Only commiters can
 |  request >:{.
 |  
 |  ~BAS
 |  
 |  On Wed, 2009-05-27 at 21:35 +0000, Christos Zoulas wrote:
 |  > The following reply was made to PR kern/38260; it has been noted by GNATS=
 |  .
 |  >=20
 |  > From: Christos Zoulas <christos@netbsd.org>
 |  > To: gnats-bugs@gnats.NetBSD.org
 |  > Cc:=20
 |  > Subject: PR/38260 CVS commit: src/sys/netinet
 |  > Date: Wed, 27 May 2009 17:32:32 -0400
 |  >=20
 |  >  Module Name:	src
 |  >  Committed By:	christos
 |  >  Date:		Wed May 27 21:32:31 UTC 2009
 |  > =20
 |  >  Modified Files:
 |  >  	src/sys/netinet: ip_carp.c
 |  > =20
 |  >  Log Message:
 |  >  PR/38260: Brian Seklecki: Improve carp logging.
 |  > =20
 |  >=20
 |  >  To generate a diff of this commit:
 |  >  cvs rdiff -u -r1.36 -r1.37 src/sys/netinet/ip_carp.c
 |  > =20
 |  >  Please note that diffs are not public domain; they are subject to the
 |  >  copyright notices on the relevant files.
 |  > =20
 |  --=20
 |  Brian A. Seklecki <bseklecki@collaborativefusion.com>
 |  Collaborative Fusion, Inc.
 |  
 |  --=_blackout-54878-1243620859-0001-2
 |  Content-Type: application/pgp-signature; name="signature.asc"
 |  Content-Transfer-Encoding: 7bit
 |  Content-Description: This is a digitally signed message part
 |  
 |  -----BEGIN PGP SIGNATURE-----
 |  Version: GnuPG v1.4.9 (GNU/Linux)
 |  
 |  iEYEABECAAYFAkogJfoACgkQCne6BNDQ+R8/GwCfSYYt5bI8m0zgVDuk0kL6o0ml
 |  uo4An3PUEZ2UjmUTj2Vgy2cP5t4y7DBH
 |  =mins
 |  -----END PGP SIGNATURE-----
 |  
 |  --=_blackout-54878-1243620859-0001-2--
 |  
 -- End of excerpt from "Brian A. Seklecki"


From: Soren Jacobsen <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38260 CVS commit: [netbsd-5] src/sys/netinet
Date: Fri, 5 Jun 2009 18:24:02 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Fri Jun  5 18:24:01 UTC 2009

 Modified Files:
 	src/sys/netinet [netbsd-5]: ip_carp.c

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #785):
 	sys/netinet/ip_carp.c: revision 1.37
 PR/38260: Brian Seklecki: Improve carp logging.


 To generate a diff of this commit:
 cvs rdiff -u -r1.26 -r1.26.10.1 src/sys/netinet/ip_carp.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 06 Jun 2009 19:13:15 +0000
State-Changed-Why:
Patch applied and pulled up -- thanks :-)


>Unformatted:

Home	PR Database Search