NetBSD Problem Report #38340

From cheusov@tut.by  Sun Mar 30 00:05:34 2008
Return-Path: <cheusov@tut.by>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 9FC0463B8B8
	for <gnats-bugs@gnats.netbsd.org>; Sun, 30 Mar 2008 00:05:34 +0000 (UTC)
Message-Id: <s93wsnloz40.fsf@chen.chizhovka.net>
Date: Sun, 30 Mar 2008 03:05:19 +0300
From: cheusov@tut.by
Reply-To:
To: gnats-bugs@gnats.NetBSD.org
Subject: x11/xxkb: DESTDIR support, clean-ups and minor fixes
X-Send-Pr-Version: 3.95

>Number:         38340
>Category:       pkg
>Synopsis:       x11/xxkb: DESTDIR support, clean-ups and minor fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    cheusov
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 30 00:10:00 +0000 2008
>Last-Modified:  Fri Feb 01 22:43:38 +0000 2013
>Originator:     cheusov@tut.by
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
System: NetBSD chen.chizhovka.net 4.0_STABLE NetBSD 4.0_STABLE (GENERIC) #2: Tue Dec 25 17:42:38 EET 2007 cheusov@chen.chizhovka.net:/srv/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
DESTDIR support, clean-ups and minor fixes.
This is my package.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/x11/xxkb/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile	2 Dec 2007 00:06:59 -0000	1.3
+++ Makefile	30 Mar 2008 00:03:01 -0000
@@ -11,8 +11,12 @@
 HOMEPAGE=	http://pascal.tsu.ru/other/xxkb/
 COMMENT=	XXKB - switches and indicates a current keyboard layout

+PKG_DESTDIR_SUPPORT=	user-destdir
+
 USE_TOOLS+=		xmkmf
 USE_IMAKE=		yes
+USE_FEATURES=		err
+
 DOC_FILES=		LICENSE README.koi8 README
 DOC_DIR=		${PREFIX}/share/doc/${PKGBASE}
 INSTALLATION_DIRS=	${DOC_DIR}
@@ -21,7 +25,7 @@

 post-install:
 .for i in ${DOC_FILES}
-	${INSTALL_DATA} ${WRKSRC}/${i} ${DOC_DIR}
+	${INSTALL_DATA} ${WRKSRC}/${i} ${DESTDIR}${DOC_DIR}
 .endfor

 .include "../../x11/libXext/buildlink3.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/x11/xxkb/PLIST,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 PLIST
--- PLIST	30 May 2007 14:01:47 -0000	1.1.1.1
+++ PLIST	30 Mar 2008 00:03:01 -0000
@@ -20,6 +20,6 @@
 share/xxkb/su48.xpm
 share/xxkb/ua15.xpm
 share/xxkb/ua48.xpm
-${IMAKE_MAN_DIR}/xxkb.${IMAKE_MANNEWSUFFIX}
+${IMAKE_MAN_DIR}/xxkb.${IMAKE_MAN_SUFFIX}
 @dirrm share/xxkb
 @dirrm share/doc/xxkb

>How-To-Repeat:

>Fix:

Unknown
>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->obache
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Sun, 30 Mar 2008 08:24:04 +0000
Responsible-Changed-Why:
I'll handle this.


From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38340 CVS commit: pkgsrc/x11/xxkb
Date: Sun, 30 Mar 2008 11:24:38 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Sun Mar 30 11:24:38 UTC 2008

 Modified Files:
 	pkgsrc/x11/xxkb: PLIST

 Log Message:
 Prefer IMAKE_MAN_SUFFIX rather than IMAKE_MANNEWSUFFIX, part of  PR 38340.


 To generate a diff of this commit:
 cvs rdiff -r1.1.1.1 -r1.2 pkgsrc/x11/xxkb/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38340 CVS commit: pkgsrc/x11/xxkb
Date: Sun, 30 Mar 2008 11:25:49 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Sun Mar 30 11:25:49 UTC 2008

 Modified Files:
 	pkgsrc/x11/xxkb: Makefile

 Log Message:
 Add DESTDIR support, part of PR 38340.


 To generate a diff of this commit:
 cvs rdiff -r1.3 -r1.4 pkgsrc/x11/xxkb/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: OBATA Akio <obache@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/38340: x11/xxkb: DESTDIR support, clean-ups and minor fixes
Date: Sun, 30 Mar 2008 20:49:17 +0900

 > +USE_FEATURES=		err

 USE_FEATURES=err is pending.
 * Need patch to use USE_FEATURES
   (see example in mk/features/features-vars.mk)
 * Check of "err" in features-vars.mk is incomplete.
   At least, Darwin have err, but not.


Responsible-Changed-From-To: obache->tnn
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Mon, 31 Mar 2008 01:45:58 +0000
Responsible-Changed-Why:
tnn@ have a plan to improve USE_FEATURES framework.


Responsible-Changed-From-To: tnn->cheusov
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Fri, 01 Feb 2013 22:43:38 +0000
Responsible-Changed-Why:
Over to current maintainer.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.