NetBSD Problem Report #38418

From leonardo1990@gmail.com  Sun Apr 13 12:29:46 2008
Return-Path: <leonardo1990@gmail.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 02D8763B9EE
	for <gnats-bugs@gnats.netbsd.org>; Sun, 13 Apr 2008 12:29:45 +0000 (UTC)
Message-Id: <4801fcb6.07035a0a.5d61.5446@mx.google.com>
Date: Sun, 13 Apr 2008 05:29:42 -0700 (PDT)
From: leonardo1990@gmail.com
Reply-To: leonardo1990@gmail.com
To: gnats-bugs@gnats.NetBSD.org
Subject: chat/weechat added the wide-curses option
X-Send-Pr-Version: 3.95

>Number:         38418
>Category:       pkg
>Synopsis:       UTF-8 on chat/weechat doesn't work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tonio
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 13 12:30:00 +0000 2008
>Closed-Date:    Sun May 11 19:14:43 +0000 2008
>Last-Modified:  Sun May 11 19:15:03 +0000 2008
>Originator:     Leonardo Taccari
>Release:        NetBSD 4.0
>Organization:
NetBSD Italia

Hello to all pkgsrc lovers,
chat/weechat on pkgsrc-2007Q4 doesn't support UTF-8. For example if I
join the #netbsd-it channel on Freenode I can't type (or type with
problems) UTF-8 characters. I've got this problem because chat/weechat
use ncurses and not ncursesw so for fix this problems I added a
wide-curses option to options.mk. I also turned that option by default
because IMHO the UTF-8 support is necessary.


HTH.

Ciao, Leonardo
-- 
 Leonardo Taccari (leot) | http://leot.netsons.org/
>Environment:


System: NetBSD bianconiglio 4.0 NetBSD 4.0 (BIANCONIGLIO) #0: Mon Mar 31 16:52:15 CEST 2008 leot@bianconiglio:/home/leot/builds/usr/src/sys/arch/i386/compile/BIANCONIGLIO i386
Architecture: i386
Machine: i386
>Description:
	The package chat/weechat doesn't support UTF-8. I've got this
	problem because it uses ncurses and not ncursesw, and there
	isn't any PKG_OPTIONS for turn on the wide-curses support. 

>How-To-Repeat:
	cd $PKGSRCDIR/chat/weechat && make install && weechat-curses
	/join #netbsd-it

	...and now please type some UTF-8 characters. :-)

>Fix:
	Apply the attached patch that adds the wide-curses option, and
	turn on the wide-curses option (I use pkgsrc-2007Q4 but i'm
	quite sure that this patch can apply without any problems on
	pkgsrc-current).


Patch for chat/weechat/Makefile:

--- Makefile.orig	2008-04-13 12:48:19.000000000 +0200
+++ Makefile	2008-04-13 13:02:16.000000000 +0200
@@ -26,5 +26,4 @@

 .include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../converters/libiconv/buildlink3.mk"
-.include "../../devel/ncurses/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"


Patch for chat/weechat/options.mk:

--- options.mk.orig	2008-04-13 12:55:23.000000000 +0200
+++ options.mk	2008-04-13 13:05:20.000000000 +0200
@@ -1,8 +1,8 @@
 # $NetBSD: options.mk,v 1.3 2007/06/10 22:20:10 tonio Exp $

 PKG_OPTIONS_VAR=	PKG_OPTIONS.weechat
-PKG_SUPPORTED_OPTIONS=	charset gnutls python lua
-PKG_SUGGESTED_OPTIONS=	charset
+PKG_SUPPORTED_OPTIONS=	charset gnutls lua python wide-curses
+PKG_SUGGESTED_OPTIONS=	charset wide-curses

 .include "../../mk/bsd.options.mk"

@@ -18,6 +18,12 @@
 .include "../../security/gnutls/buildlink3.mk"
 .endif

+.if !empty(PKG_OPTIONS:Mwide-curses)
+.include "../../devel/ncursesw/buildlink3.mk"
+.else
+.include "../../devel/ncurses/buildlink3.mk"
+.endif
+
 .if !empty(PKG_OPTIONS:Mpython)
 .include "../../lang/python/extension.mk"
 CONFIGURE_ARGS+=	--enable-python

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->tonio
Responsible-Changed-By: snj@NetBSD.org
Responsible-Changed-When: Tue, 15 Apr 2008 00:06:50 +0000
Responsible-Changed-Why:
Over to maintainer.


State-Changed-From-To: open->closed
State-Changed-By: tonio@NetBSD.org
State-Changed-When: Sun, 11 May 2008 19:14:43 +0000
State-Changed-Why:
Patch applied, thanks for the PR!
I kept the option disabled by default, since an user wanting utf-8 aware applications probably sets wide-curses option globally.


From: Antoine Reilles <tonio@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38418 CVS commit: pkgsrc/chat/weechat
Date: Sun, 11 May 2008 19:10:30 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	tonio
 Date:		Sun May 11 19:10:30 UTC 2008

 Modified Files:
 	pkgsrc/chat/weechat: Makefile options.mk

 Log Message:
 Add a wide-curses option, to enable utf-8 support.
 Based on patch from Leonardo Taccari in PR pkg/38418


 To generate a diff of this commit:
 cvs rdiff -r1.18 -r1.19 pkgsrc/chat/weechat/Makefile
 cvs rdiff -r1.4 -r1.5 pkgsrc/chat/weechat/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.