NetBSD Problem Report #38423

From martin@duskware.de  Sun Apr 13 13:26:30 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 76ECE63B9EE
	for <gnats-bugs@gnats.netbsd.org>; Sun, 13 Apr 2008 13:26:30 +0000 (UTC)
Message-Id: <20080413100418.0CBF463B9EE@narn.NetBSD.org>
Date: Sun, 13 Apr 2008 10:04:18 +0000 (UTC)
From: svs@ropnet.ru
Reply-To: svs@ropnet.ru
To: netbsd-bugs-owner@NetBSD.org
Subject: url2pkg should use 'make distinfo' (to prevent endless loop)
X-Send-Pr-Version: www-1.0

>Number:         38423
>Category:       pkg
>Synopsis:       url2pkg should use 'make distinfo' (to prevent endless loop)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    rillig
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 13 13:30:00 +0000 2008
>Closed-Date:    Fri Nov 20 11:51:09 +0000 2009
>Last-Modified:  Fri Nov 20 11:51:09 +0000 2009
>Originator:     Sergey Svishchev
>Release:        4.0
>Organization:
>Environment:
>Description:
If a distfile is not (yet) recorded in distinfo, 'make makesum' no longer updates it with new checksums; this makes url2pkg impossible to use.
>How-To-Repeat:

>Fix:
--- pkgtools/url2pkg/files/url2pkg.pl	25 Sep 2007 13:59:42 -0000	1.10
+++ pkgtools/url2pkg/files/url2pkg.pl	13 Apr 2008 09:48:57 -0000
@@ -296,16 +296,13 @@
 	print PLIST ("\@comment \$NetBSD\$\n");
 	close(PLIST) or die;

-	open(DI, ">", "distinfo") or die;
-	close(DI) or die;
-
 	open(DESCR, ">", "DESCR") or die;
 	close(DESCR) or die;

 	run_editor("Makefile", 5);

-	print ("url2pkg> Running \"make makesum\" ...\n");
-	(system { $make } ($make, "makesum")) == 0 or die;
+	print ("url2pkg> Running \"make distinfo\" ...\n");
+	(system { $make } ($make, "distinfo")) == 0 or die;

 	print ("url2pkg> Running \"make extract\" ...\n");
 	(system { $make } ($make, "extract")) == 0 or die;

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->rillig
Responsible-Changed-By: snj@NetBSD.org
Responsible-Changed-When: Tue, 15 Apr 2008 00:07:16 +0000
Responsible-Changed-Why:
Over to maintainer.


From: Roland Illig <rillig@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38423 CVS commit: pkgsrc/pkgtools/url2pkg
Date: Fri, 20 Nov 2009 11:49:18 +0000

 Module Name:	pkgsrc
 Committed By:	rillig
 Date:		Fri Nov 20 11:49:18 UTC 2009

 Modified Files:
 	pkgsrc/pkgtools/url2pkg: Makefile
 	pkgsrc/pkgtools/url2pkg/files: url2pkg.pl

 Log Message:
 Applied patch from PR 38423 by Sergey Svishchev.
 Increased the version number to 2.12.


 To generate a diff of this commit:
 cvs rdiff -u -r1.59 -r1.60 pkgsrc/pkgtools/url2pkg/Makefile
 cvs rdiff -u -r1.14 -r1.15 pkgsrc/pkgtools/url2pkg/files/url2pkg.pl

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: rillig@NetBSD.org
State-Changed-When: Fri, 20 Nov 2009 11:51:09 +0000
State-Changed-Why:
Thanks for the patch. I just applied it. Sorry that it took so long.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.