NetBSD Problem Report #38521

From cheusov@tut.by  Sun Apr 27 08:46:04 2008
Return-Path: <cheusov@tut.by>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id A9D9F63B898
	for <gnats-bugs@gnats.netbsd.org>; Sun, 27 Apr 2008 08:46:04 +0000 (UTC)
Message-Id: <s93prsb3cu3.fsf@chen.chizhovka.net>
Date: Sun, 27 Apr 2008 11:45:56 +0300
From: cheusov@tut.by
Reply-To:
To: gnats-bugs@gnats.NetBSD.org
Subject: DESTDIR support and clean-ups for pkgtools/shlock
X-Send-Pr-Version: 3.95

>Number:         38521
>Category:       pkg
>Synopsis:       DESTDIR support for pkgtools/shlock
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 27 08:50:00 +0000 2008
>Closed-Date:    Thu May 29 17:09:35 +0000 2008
>Last-Modified:  Fri May 30 10:10:02 +0000 2008
>Originator:     cheusov@tut.by
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
System: NetBSD chen.chizhovka.net 4.0_STABLE NetBSD 4.0_STABLE (GENERIC) #3: Wed Apr 23 00:58:08 EEST 2008 cheusov@chen.chizhovka.net:/srv/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
http://www.mova.org/~cheusov/pub/pkgsrc-pbulk/NetBSD/current-destdir/log/20080426.0859/pkgtools/shlock/stage_package.html

=> Generating pre-install file lists
#   install  /tmp/obj-pkgsrc-destdir/pkgtools/shlock/work/.destdir/usr/pkg/bin/shlock
install  -c  -r -o root -g wheel -m 755  -s shlock /tmp/obj-pkgsrc-destdir/pkgtools/shlock/work/.destdir/usr/pkg/bin/shlock
install: /tmp/obj-pkgsrc-destdir/pkgtools/shlock/work/.destdir/usr/pkg/bin: mkstemp: No such file or directory
*** Error code 1

Stop.
make: stopped in /tmp/obj-pkgsrc-destdir/pkgtools/shlock/work
*** Error code 1

Stop.
make: stopped in /srv/pkgsrc/pkgtools/shlock
*** Error code 1

>How-To-Repeat:

>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/shlock/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- Makefile	19 Dec 2006 13:28:20 -0000	1.18
+++ Makefile	27 Apr 2008 08:43:40 -0000
@@ -13,35 +13,17 @@
 WRKSRC=		${WRKDIR}
 EXTRACT_ONLY=	#empty
 NO_CHECKSUM=	yes
-MANCOMPRESSED_IF_MANZ=	yes
-PLIST_SRC=	${WRKDIR}/PLIST
-BUILD_DEFS+=	MANINSTALL

-MAKE_ENV+=	${BSD_MAKE_ENV}
+WRKSRC=			${.CURDIR}/files

-.include "../../mk/bsd.prefs.mk"
+USE_BSD_MAKEFILE=	yes
+PKG_DESTDIR_SUPPORT=	user-destdir
+
+MAKE_ENV+=		MAKEOBJDIR=${WRKDIR}
+MAKE_ENV+=		MKCATPAGES=no

 PKGSRC_LOCKTYPE=	none	# avoid "bootstrapping problem"

-.if !empty(OPSYS:MSunOS) || !empty(OPSYS:MDarwin) ||			\
-    !empty(OPSYS:MDragonFly) || !empty(OPSYS:MFreeBSD) ||		\
-    !empty(OPSYS:MLinux)
-MANINSTALL=
-.endif
-
-post-extract:
-	@for FILE in Makefile shlock.c shlock.1; do			\
-		${CP} ${FILESDIR}/$$FILE ${WRKSRC};			\
-	done
-
-pre-install:
-	@${RM} -f ${PLIST_SRC}
-	@${CP} ${PKGDIR}/PLIST ${PLIST_SRC}
-	@if [ -n "${MANINSTALL:Mcatinstall}" ]; then			\
-		${ECHO} man/cat1/shlock.0 >> ${PLIST_SRC};		\
-	fi
-	@if [ -n "${MANINSTALL:Mmaninstall}" ]; then			\
-		${ECHO} man/man1/shlock.1 >> ${PLIST_SRC};		\
-	fi
+INSTALLATION_DIRS+=	bin ${PKGMANDIR}/man1

 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/shlock/PLIST,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 PLIST
--- PLIST	15 Jan 2002 13:20:27 -0000	1.1.1.1
+++ PLIST	27 Apr 2008 08:43:40 -0000
@@ -1,2 +1,3 @@
 @comment $NetBSD: PLIST,v 1.1.1.1 2002/01/15 13:20:27 agc Exp $
 bin/shlock
+man/man1/shlock.1

>Release-Note:

>Audit-Trail:
From: Tobias Nygren <tnn@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38521 CVS commit: pkgsrc/pkgtools/shlock
Date: Thu, 29 May 2008 17:03:54 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	tnn
 Date:		Thu May 29 17:03:54 UTC 2008

 Modified Files:
 	pkgsrc/pkgtools/shlock: Makefile PLIST

 Log Message:
 Merge some changes from PR pkg/38521 to clean up the package and
 desupport installing catpage.
 Thanks to cheusov for the PR and obache for making me aware of it.
 Bump the version to 20080529.


 To generate a diff of this commit:
 cvs rdiff -r1.19 -r1.20 pkgsrc/pkgtools/shlock/Makefile
 cvs rdiff -r1.1.1.1 -r1.2 pkgsrc/pkgtools/shlock/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tnn@NetBSD.org
State-Changed-When: Thu, 29 May 2008 17:09:35 +0000
State-Changed-Why:
should work now I hope. Thanks.


From: OBATA Akio <obache@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: Uwe Klaus <uklaus@hgb-leipzig.de>
Subject: Re: pkg/38521 (DESTDIR support for pkgtools/shlock)
Date: Fri, 30 May 2008 17:51:39 +0900

 --On 2008/05/30 10:04 +0200 Uwe Klaus <uklaus@hgb-leipzig.de> wrote:

 >
 > bmake package on solaris complains of missing man page.
 >
 > ===> Installing for shlock-20080529
 > => Creating installation directories
 > /usr/ucb/install   -c -s   -o root -g root -m 555 shlock
 > /opt/pkg/bin/shlock
 > => Automatic manual page handling
 > pkg_create: can't stat `/opt/pkg/man/man1/shlock.1'
 > => Registering installation for shlock-20080529
 > pkg_admin: shlock-20080529: File `/opt/pkg/man/man1/shlock.1' is in
 > +CONTENTS but not on filesystem!
 >
 > Regards,
 > Uwe

 Probably should fix pkgsrc/pkgtools/shlock/files/Makefile.
 I don't know why but
  r1.2 SunOS
  r1.3 Darwin
  r1.4 Dragonfly
  r1.5 Linux
 was added for "NOMAN=YES".

 OK to remove the following three lines from the Makefile?
 .if (${OPSYS} == SunOS || ${OPSYS} == Darwin || ${OPSYS} == DragonFly || \
     ${OPSYS} == Linux)
 NOMAN=          YES
 .endif


From: Uwe Klaus <uklaus@hgb-leipzig.de>
To: OBATA Akio <obache@NetBSD.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/38521 (DESTDIR support for pkgtools/shlock)
Date: Fri, 30 May 2008 11:08:04 +0200 (CEST)

 On Fri, 30 May 2008, OBATA Akio wrote:

 > Probably should fix pkgsrc/pkgtools/shlock/files/Makefile.
 > I don't know why but
 > r1.2 SunOS
 > r1.3 Darwin
 > r1.4 Dragonfly
 > r1.5 Linux
 > was added for "NOMAN=YES".
 >
 > OK to remove the following three lines from the Makefile?
 > .if (${OPSYS} == SunOS || ${OPSYS} == Darwin || ${OPSYS} == DragonFly || \
 >   ${OPSYS} == Linux)
 > NOMAN=          YES
 > .endif
 man page was built but looks uggly.

 Uwe


From: Tobias Nygren <tnn@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/38521 (DESTDIR support for pkgtools/shlock)
Date: Fri, 30 May 2008 12:05:11 +0200

 >  man page was built but looks uggly.

 An ugly manpage is probably better than the previous of no manpage at
 all. If we really need the catpage it should be pregenerated and
 committed for this package.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.