NetBSD Problem Report #38565

From woods@once.weird.com  Fri May  2 16:40:21 2008
Return-Path: <woods@once.weird.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id BF07A63BA2C
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  2 May 2008 16:40:20 +0000 (UTC)
Message-Id: <m1JryIy-0018KZC@once.weird.com>
Date: Fri, 2 May 2008 12:40:16 -0400 (EDT)
From: "Greg A. Woods" <woods@planix.com>
Sender: "Greg A. Woods" <woods@once.weird.com>
Reply-To: "Greg A. Woods" <woods@planix.com>
To: gnats-bugs@gnats.NetBSD.org
Subject: console outputs CRLF in the "wrong" order
X-Send-Pr-Version: 3.95

>Number:         38565
>Category:       kern
>Synopsis:       console outputs CRLF in the "wrong" order
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 02 16:45:00 +0000 2008
>Closed-Date:    Sat Dec 31 04:08:52 +0000 2022
>Last-Modified:  Sat Dec 31 04:08:52 +0000 2022
>Originator:     Greg A. Woods
>Release:        NetBSD current 2008/05/02
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
>Description:

	the console driver ouputs the <CR> after the <LF> instead of in
	the traditional <CR><LF> order

>How-To-Repeat:

>Fix:

	I'm pretty sure I saw this somewhere else in someone else's
	diff, but I can't find it again now

Index: sys/dev/cons.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/src/sys/dev/cons.c,v
retrieving revision 1.65
diff -u -r1.65 cons.c
--- sys/dev/cons.c	24 Jan 2008 17:32:52 -0000	1.65
+++ sys/dev/cons.c	16 Apr 2008 20:06:16 -0000
@@ -336,9 +336,9 @@
 		return;

 	if (c) {
-		(*cn_tab->cn_putc)(cn_tab->cn_dev, c);
 		if (c == '\n')
 			(*cn_tab->cn_putc)(cn_tab->cn_dev, '\r');
+		(*cn_tab->cn_putc)(cn_tab->cn_dev, c);
 	}
 }


>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 31 Dec 2022 04:08:52 +0000
State-Changed-Why:
This was fixed in 2015 by nakayama@ in -r1.74 of cons.c.

If anyone watching has an sgimips, note that this apparently
broke the console somehow (see -r1.75) so the change doesn't
apply there until someone figures out what happened.


>Unformatted:

Home	PR Database Search