NetBSD Problem Report #38573

From martin@duskware.de  Sat May  3 23:00:33 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 99B6063BA7F
	for <gnats-bugs@gnats.netbsd.org>; Sat,  3 May 2008 23:00:33 +0000 (UTC)
Message-Id: <20080503215849.5224A63B8BC@narn.NetBSD.org>
Date: Sat,  3 May 2008 21:58:49 +0000 (UTC)
From: svs@ropnet.ru
Reply-To: svs@ropnet.ru
To: netbsd-bugs-owner@NetBSD.org
Subject: sysutils/smartmontools 5.38
X-Send-Pr-Version: www-1.0

>Number:         38573
>Category:       pkg
>Synopsis:       sysutils/smartmontools 5.38
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat May 03 23:05:00 +0000 2008
>Closed-Date:    Sat May 17 13:16:09 +0000 2008
>Last-Modified:  Sat May 17 13:16:09 +0000 2008
>Originator:     Sergey Svishchev
>Release:        4.0
>Organization:
>Environment:
>Description:
New platforms: DragonFly [see also PR/36982], GNU/kFreeBSD.

New features:
  ATA: '-l scttemp[sts,hist]' options to print disk temperature information and history table provided by SMART Command Transport (SCT) Feature Set.
  ATA: '-t selective,{redo,next,cont}' commands to perform tests based on the last ranges still stored on disk.
  Many cleanups of CCISS support code; support FreeBSD ciss(4) driver.
  On Linux, DEVICESCAN now automatically recognizes SATA devices behind libata and Marvell drivers.
  '-F samsung3' option to correct firmware bug reporting completed self-tests as still in progress.
  Many new entries in drive database.

Fixes:
  Added missing const specifiers (undetected by gcc 3.4 and 4.X) to fix compilation with gcc 2.X.
  smartd: Don't start self tests in first pass to avoid performance problems during boot.
  Fix scheduled tests on Highpoint RAID controllers.
  Support up to 32 disks on 3ware controllers.
  Fix auto-offline and auto-save on Linux via libata and on FreeBSD.

NetBSD-specific fixes:
  Handle actual SCSI and ATA errors and not only ioctl() errors;
  Set up I/O request properly for AUTO_OFFLINE and AUTOSAVE commands;
  Handle AUTO_OFFLINE and AUTOSAVE like STATUS_CHECK (like os_linux.cpp does).

pkgsrc- and Solaris-specific fix copied from PR/38199.

>How-To-Repeat:

>Fix:
Index: sysutils/smartmontools/Makefile
===================================================================
RCS file: /vol/2/cvsup/pkgsrc/sysutils/smartmontools/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- sysutils/smartmontools/Makefile	4 Jan 2008 22:15:47 -0000	1.14
+++ sysutils/smartmontools/Makefile	3 May 2008 13:20:46 -0000
@@ -1,6 +1,6 @@
 # $NetBSD: Makefile,v 1.14 2008/01/04 22:15:47 heinz Exp $

-DISTNAME=		smartmontools-5.37
+DISTNAME=		smartmontools-5.38
 CATEGORIES=		sysutils
 MASTER_SITES=		${MASTER_SITE_SOURCEFORGE:=smartmontools/}

@@ -8,15 +8,15 @@
 HOMEPAGE=		http://smartmontools.sourceforge.net/
 COMMENT=		Control and monitor storage systems using SMART

-ONLY_FOR_PLATFORM=	Darwin-*-* FreeBSD-*-* Linux-*-*
+ONLY_FOR_PLATFORM=	Darwin-*-* DragonFly-*-* FreeBSD-*-* Linux-*-*
 ONLY_FOR_PLATFORM+=	NetBSD-*-* OpenBSD-*-* SunOS-*-*

 PKG_DESTDIR_SUPPORT=	user-destdir
 PKG_INSTALLATION_TYPES=	overwrite pkgviews

-USE_LANGUAGES+=		c++
 USE_TOOLS+=		gmake
 GNU_CONFIGURE=		yes
+USE_LANGUAGES=		c c++

 EGDIR=			${PREFIX}/share/examples/smartmontools
 CONF_FILES=		${EGDIR}/smartd.conf ${PKG_SYSCONFDIR}/smartd.conf
Index: sysutils/smartmontools/distinfo
===================================================================
RCS file: /vol/2/cvsup/pkgsrc/sysutils/smartmontools/distinfo,v
retrieving revision 1.14
diff -u -r1.14 distinfo
--- sysutils/smartmontools/distinfo	19 Oct 2007 03:56:13 -0000	1.14
+++ sysutils/smartmontools/distinfo	3 May 2008 13:18:38 -0000
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.14 2007/10/19 03:56:13 taca Exp $
+$NetBSD$

-SHA1 (smartmontools-5.37.tar.gz) = d6e88f576e26836b929c570290644b0580645602
-RMD160 (smartmontools-5.37.tar.gz) = e9d18c71340766dc43bf462a4c12cb0d152f2812
-Size (smartmontools-5.37.tar.gz) = 590605 bytes
-SHA1 (patch-aa) = 005d69bebfdb385ca42c59aa2c90a62e22c14733
-SHA1 (patch-ae) = 35a42cfc16f6657ddbc81cbecf340a3892ba4918
-SHA1 (patch-af) = 0936c5eb5f0df75cebd186304a6ca111909a34d2
+SHA1 (smartmontools-5.38.tar.gz) = b5831719fd292dccfd12fa58b15b3e278dd9bcbe
+RMD160 (smartmontools-5.38.tar.gz) = abc2ca7f30c84f9679da79c0ca2f812c1b816ee9
+Size (smartmontools-5.38.tar.gz) = 617099 bytes
+SHA1 (patch-aa) = bf6e5aaef364397ebfb7b44dfd98297c780a2f17
+SHA1 (patch-ab) = b40f78d220d87217d0006bfbfec2b47ee3c79e2f
+SHA1 (patch-ac) = 712cf0cc567221a92d38d8b3c4623902705b6dfa
Index: sysutils/smartmontools/patches/patch-aa
===================================================================
RCS file: /vol/2/cvsup/pkgsrc/sysutils/smartmontools/patches/patch-aa,v
retrieving revision 1.4
diff -u -r1.4 patch-aa
--- sysutils/smartmontools/patches/patch-aa	3 Jun 2007 10:40:07 -0000	1.4
+++ sysutils/smartmontools/patches/patch-aa	27 Apr 2008 17:36:50 -0000
@@ -1,8 +1,8 @@
-$NetBSD: patch-aa,v 1.4 2007/06/03 10:40:07 jmmv Exp $
+$NetBSD$

---- Makefile.in.orig	2006-12-20 21:38:50.000000000 +0100
+--- Makefile.in.orig	2008-03-04 22:28:09.000000000 +0000
 +++ Makefile.in
-@@ -92,7 +92,7 @@ CONFIG_HEADER = config.h
+@@ -87,7 +87,7 @@ CONFIG_HEADER = config.h
  CONFIG_CLEAN_FILES =
  am__installdirs = "$(DESTDIR)$(sbindir)" "$(DESTDIR)$(man5dir)" \
  	"$(DESTDIR)$(man8dir)" "$(DESTDIR)$(docsdir)" \
@@ -11,7 +11,7 @@
  sbinPROGRAMS_INSTALL = $(INSTALL_PROGRAM)
  PROGRAMS = $(sbin_PROGRAMS)
  am__smartctl_SOURCES_DIST = smartctl.cpp smartctl.h atacmdnames.cpp \
-@@ -353,8 +353,7 @@ docs_DATA = AUTHORS     \
+@@ -347,8 +347,7 @@ docs_DATA = AUTHORS     \
              NEWS        \
              README      \
              TODO        \
@@ -21,12 +21,12 @@

  sysconf_DATA = smartd.conf$(smartd_suffix)
  EXTRA_DIST = smartmontools.spec                    \
-@@ -1122,7 +1121,7 @@ info: info-recursive
+@@ -1115,7 +1114,7 @@ info: info-recursive

  info-am:

 -install-data-am: install-docsDATA install-initdDATA install-man
 +install-data-am: install-docsDATA install-man

- install-exec-am: install-sbinPROGRAMS install-sysconfDATA
+ install-dvi: install-dvi-recursive

Index: sysutils/smartmontools/patches/patch-ab
===================================================================
RCS file: sysutils/smartmontools/patches/patch-ab
diff -N sysutils/smartmontools/patches/patch-ab
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ sysutils/smartmontools/patches/patch-ab	27 Apr 2008 17:35:59 -0000
@@ -0,0 +1,18 @@
+$NetBSD$
+
+--- configure.orig	2008-03-04 22:28:10.000000000 +0000
++++ configure
+@@ -8098,13 +8098,8 @@ else
+   OS_DARWIN_FALSE=
+ fi
+ 
+- if echo $host_os | grep '^solaris' > /dev/null; then
+-  OS_SOLARIS_TRUE=
+-  OS_SOLARIS_FALSE='#'
+-else
+   OS_SOLARIS_TRUE='#'
+   OS_SOLARIS_FALSE=
+-fi
+ 
+  if echo $host_os | grep '^mingw' > /dev/null; then
+   OS_WIN32_MINGW_TRUE=
Index: sysutils/smartmontools/patches/patch-ac
===================================================================
RCS file: sysutils/smartmontools/patches/patch-ac
diff -N sysutils/smartmontools/patches/patch-ac
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ sysutils/smartmontools/patches/patch-ac	3 May 2008 13:18:36 -0000
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- os_freebsd.cpp.orig	2008-03-04 22:09:47.000000000 +0000
++++ os_freebsd.cpp
+@@ -272,7 +272,6 @@ int marvell_command_interface(__unused i
+ }
+ 
+ int highpoint_command_interface(__unused int fd, __unused smart_command_set command, __unused int select, __unused char *data) {
+-{
+   return -1;
+ }
+ 
Index: sysutils/smartmontools/patches/patch-ae
===================================================================
RCS file: sysutils/smartmontools/patches/patch-ae
diff -N sysutils/smartmontools/patches/patch-ae
--- sysutils/smartmontools/patches/patch-ae	19 Oct 2007 03:56:13 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,13 +0,0 @@
-$NetBSD: patch-ae,v 1.1 2007/10/19 03:56:13 taca Exp $
-
---- smartctl.cpp.orig	Mon Oct  9 20:45:12 2006
-+++ smartctl.cpp
-@@ -82,7 +82,7 @@ void PrintOneCVS(const char *a_cvs_id){
- }
- 
- void printcopy(){
--  char *configargs=strlen(SMARTMONTOOLS_CONFIGURE_ARGS)?SMARTMONTOOLS_CONFIGURE_ARGS:"[no arguments given]";
-+  const char *configargs=strlen(SMARTMONTOOLS_CONFIGURE_ARGS)?SMARTMONTOOLS_CONFIGURE_ARGS:"[no arguments given]";
- 
-   pout("smartctl comes with ABSOLUTELY NO WARRANTY. This\n");
-   pout("is free software, and you are welcome to redistribute it\n");
Index: sysutils/smartmontools/patches/patch-af
===================================================================
RCS file: sysutils/smartmontools/patches/patch-af
diff -N sysutils/smartmontools/patches/patch-af
--- sysutils/smartmontools/patches/patch-af	19 Oct 2007 03:56:14 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,13 +0,0 @@
-$NetBSD: patch-af,v 1.1 2007/10/19 03:56:14 taca Exp $
-
---- smartd.cpp.orig	Sun Nov 12 13:49:09 2006
-+++ smartd.cpp
-@@ -310,7 +310,7 @@ void PrintOneCVS(const char *a_cvs_id){
- 
- // prints CVS identity information for the executable
- void PrintCVS(void){
--  char *configargs=strlen(SMARTMONTOOLS_CONFIGURE_ARGS)?SMARTMONTOOLS_CONFIGURE_ARGS:"[no arguments given]";
-+  const char *configargs=strlen(SMARTMONTOOLS_CONFIGURE_ARGS)?SMARTMONTOOLS_CONFIGURE_ARGS:"[no arguments given]";
- 
-   PrintOut(LOG_INFO,(char *)copyleftstring);
-   PrintOut(LOG_INFO,"CVS version IDs of files used to build this code are:\n");

>Release-Note:

>Audit-Trail:
From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38573 CVS commit: pkgsrc/sysutils/smartmontools
Date: Sat, 17 May 2008 13:07:54 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Sat May 17 13:07:54 UTC 2008

 Modified Files:
 	pkgsrc/sysutils/smartmontools: Makefile distinfo
 	pkgsrc/sysutils/smartmontools/patches: patch-aa
 Added Files:
 	pkgsrc/sysutils/smartmontools/patches: patch-ag patch-ah
 Removed Files:
 	pkgsrc/sysutils/smartmontools/patches: patch-ae patch-af

 Log Message:
 Update smartmontools to 5.38, UNSTABLE to STABLE.
 Based on patch provided by Sergey Svishchev in PR 38573.
 This version contains DragonFly support, noted in PR 36982.
 patch-ag is taken from PR 38199.

 Date 2008-03-10
 Summary: smartmontools release 5.38 (STABLE)
 --------------------------------------------
 This is a stable release of smartmontools.  In addition to changes
 below, it includes:

  - Libata/Marvell driver devices no longer need explicit '-d' switch
  - DEVICESCAN automatically detects libata/marvell driver SATA devices
  - Fixed auto-offline/autosave support in FreeBSD
  - SAT device type + SCSI generic devices work properly with smartd under Linux
  - Many additions to drive database
  - More portable autogen/autoconf/automake script set
  - Additional Windows IOCTL route to access SMART data
  - Some ATA-8 updates
  - Smoother CCISS compilation support in Linux
  - Dragonfly support
  - Fixed some ATA identity byte swap problems on big endian CPUs
  - Added support for the QNX operating system
  - No-fork option added to smartd
  - Improved device scanning and drive type recognition in Windows
  - 3ware support for controllers with more disks (32 max)
  - Improved Windows installer
  - Improved SMART Attribute list and descriptions
  - Fix to smartctl return codes
  - Fix to scheduled tests on Highpoint RAID controllers
  - New samsung firmware bug workaround option
  - Auto-offline and Auto-save fixed in Linux + libata
  - Solaris: better SCSI support and support for Sun compilers AND gcc
  - Fixed and improvements to CCISS support
  - More options for SCSI temperature monitoring and history
  - Additional command line options for selective self-tests
  - Compilation fixes for various platforms.

 See CHANGELOG for more details, or smartmontools CVS for still further
 details.


 To generate a diff of this commit:
 cvs rdiff -r1.14 -r1.15 pkgsrc/sysutils/smartmontools/Makefile \
     pkgsrc/sysutils/smartmontools/distinfo
 cvs rdiff -r1.4 -r1.5 pkgsrc/sysutils/smartmontools/patches/patch-aa
 cvs rdiff -r1.1 -r0 pkgsrc/sysutils/smartmontools/patches/patch-ae \
     pkgsrc/sysutils/smartmontools/patches/patch-af
 cvs rdiff -r0 -r1.1 pkgsrc/sysutils/smartmontools/patches/patch-ag \
     pkgsrc/sysutils/smartmontools/patches/patch-ah

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Sat, 17 May 2008 13:16:09 +0000
State-Changed-Why:
Updated.  Thanks!


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.