NetBSD Problem Report #38577
From kay@gaia.kaynet.or.jp Sun May 4 05:54:12 2008
Return-Path: <kay@gaia.kaynet.or.jp>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by narn.NetBSD.org (Postfix) with ESMTP id 2F85A63BA4A
for <gnats-bugs@gnats.NetBSD.org>; Sun, 4 May 2008 05:54:12 +0000 (UTC)
Message-Id: <20080504043757.84C7213F39@gaia.kaynet.or.jp>
Date: Sun, 4 May 2008 13:37:57 +0900 (JST)
From: kay@gaia.kaynet.or.jp
Reply-To: kay@gaia.kaynet.or.jp
To: gnats-bugs@gnats.NetBSD.org
Subject: options IPSEC crashes when execute netstat -s
X-Send-Pr-Version: 3.95
>Number: 38577
>Category: kern
>Synopsis: options IPSEC crashes when execute netstat -s
>Confidential: no
>Severity: critical
>Priority: medium
>Responsible: thorpej
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun May 04 05:55:00 +0000 2008
>Closed-Date: Fri Jun 27 17:25:47 +0000 2008
>Last-Modified: Fri Jun 27 17:25:47 +0000 2008
>Originator: kay@gaia.kaynet.or.jp
>Release: NetBSD 4.99.62
>Organization:
>Environment:
System: NetBSD gaia.kaynet.or.jp 4.99.60 NetBSD 4.99.62 (GAIA) #0: Wed Apr 23 02:20:55 JST 2008 root@gaia.kaynet.or.jp:/usr/src/obj.x86_64/sys/arch/amd64/compile/GAIA amd64
Architecture: x86_64
Machine: amd64
>Description:
allocate too large array on statck.
$NetBSD: ipsec.c,v 1.129 2008/04/23 06:09:05 thorpej Exp $
static int
sysctl_net_inet_ipsec_stats(SYSCTLFN_ARGS)
{
netstat_sysctl_context ctx;
uint64_t ipss[IPSEC_NSTATS];
ctx.ctx_stat = ipsecstat_percpu;
ctx.ctx_counters = ipss;
ctx.ctx_ncounters = IPSEC_NSTATS;
return (NETSTAT_SYSCTL(&ctx));
}
back trace:
sysctl_net_inet_ipsec_stats() at netbsd:sysctl_net_inet_ipsec_stats+0x19
sysctl_dispatch() at netbsd:sysctl_dispatch+0xd8
sys___sysctl() at netbsd:sys___sysctl+0xd4
syscall() at netbsd:syscall+0x9a
disassemble:
Dump of assembler code for function sysctl_net_inet_ipsec_stats:
0xffffffff801c1280 <sysctl_net_inet_ipsec_stats+0>: push %rbp
0xffffffff801c1281 <sysctl_net_inet_ipsec_stats+1>: mov %rdi,%r10
0xffffffff801c1284 <sysctl_net_inet_ipsec_stats+4>: mov %rsp,%rbp
0xffffffff801c1287 <sysctl_net_inet_ipsec_stats+7>: sub $0x30e0,%rsp
0xffffffff801c128e <sysctl_net_inet_ipsec_stats+14>: mov 7264963(%rip),%r\
ax # 0xffffffff808aed58 <ipsecstat_percpu>
0xffffffff801c1295 <sysctl_net_inet_ipsec_stats+21>: lea 0xffffffffffffff\
e0(%rbp),%rdi
0xffffffff801c1299 <sysctl_net_inet_ipsec_stats+25>: mov %r9,(%rsp) <== here
0xffffffff801c129d <sysctl_net_inet_ipsec_stats+29>: mov %r8,%r9
0xffffffff801c12a0 <sysctl_net_inet_ipsec_stats+32>: mov %rcx,%r8
0xffffffff801c12a3 <sysctl_net_inet_ipsec_stats+35>: mov %rdx,%rcx
0xffffffff801c12a6 <sysctl_net_inet_ipsec_stats+38>: mov %esi,%edx
0xffffffff801c12a8 <sysctl_net_inet_ipsec_stats+40>: mov %rax,0xfffffffff\
fffffe0(%rbp)
0xffffffff801c12ac <sysctl_net_inet_ipsec_stats+44>: lea 0xffffffffffffcf\
40(%rbp),%rax
0xffffffff801c12b3 <sysctl_net_inet_ipsec_stats+51>: mov %r10,%rsi
0xffffffff801c12b6 <sysctl_net_inet_ipsec_stats+54>: movl $0x614,0xfffffff\
ffffffff0(%rbp)
0xffffffff801c12bd <sysctl_net_inet_ipsec_stats+61>: mov %rax,0xfffffffff\
fffffe8(%rbp)
0xffffffff801c12c1 <sysctl_net_inet_ipsec_stats+65>: mov 0x20(%rbp),%rax
0xffffffff801c12c5 <sysctl_net_inet_ipsec_stats+69>: mov %rax,0x18(%rsp)
0xffffffff801c12ca <sysctl_net_inet_ipsec_stats+74>: mov 0x18(%rbp),%rax
0xffffffff801c12ce <sysctl_net_inet_ipsec_stats+78>: mov %rax,0x10(%rsp)
0xffffffff801c12d3 <sysctl_net_inet_ipsec_stats+83>: mov 0x10(%rbp),%rax
0xffffffff801c12d7 <sysctl_net_inet_ipsec_stats+87>: mov %rax,0x8(%rsp)
0xffffffff801c12dc <sysctl_net_inet_ipsec_stats+92>: callq 0xffffffff8042c5\
30 <netstat_sysctl>
0xffffffff801c12e1 <sysctl_net_inet_ipsec_stats+97>: leaveq
0xffffffff801c12e2 <sysctl_net_inet_ipsec_stats+98>: retq
>How-To-Repeat:
1. enable IPSEC in your kernel configuration file.
2. build kernel and boot it.
3. execute netstat -s
>Fix:
grow kernel stack size or allocate uint64_t ipss[IPSEC_NSTATS] on heap.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->thorpej
Responsible-Changed-By: thorpej@NetBSD.org
Responsible-Changed-When: Sun, 04 May 2008 06:21:15 +0000
Responsible-Changed-Why:
take
State-Changed-From-To: open->feedback
State-Changed-By: thorpej@NetBSD.org
State-Changed-When: Sun, 04 May 2008 07:23:22 +0000
State-Changed-Why:
Should be fixed with the following revisions. Please verify.
Checking in net/net_stats.c;
/cvsroot/src/sys/net/net_stats.c,v <-- net_stats.c
new revision: 1.4; previous revision: 1.3
done
Checking in net/net_stats.h;
/cvsroot/src/sys/net/net_stats.h,v <-- net_stats.h
new revision: 1.3; previous revision: 1.2
done
Checking in netatalk/ddp_usrreq.c;
/cvsroot/src/sys/netatalk/ddp_usrreq.c,v <-- ddp_usrreq.c
new revision: 1.33; previous revision: 1.32
done
Checking in netinet/if_arp.c;
/cvsroot/src/sys/netinet/if_arp.c,v <-- if_arp.c
new revision: 1.137; previous revision: 1.136
done
Checking in netinet/igmp.c;
/cvsroot/src/sys/netinet/igmp.c,v <-- igmp.c
new revision: 1.49; previous revision: 1.48
done
Checking in netinet/ip_carp.c;
/cvsroot/src/sys/netinet/ip_carp.c,v <-- ip_carp.c
new revision: 1.26; previous revision: 1.25
done
Checking in netinet/ip_icmp.c;
/cvsroot/src/sys/netinet/ip_icmp.c,v <-- ip_icmp.c
new revision: 1.119; previous revision: 1.118
done
Checking in netinet/ip_input.c;
/cvsroot/src/sys/netinet/ip_input.c,v <-- ip_input.c
new revision: 1.271; previous revision: 1.270
done
Checking in netinet/tcp_usrreq.c;
/cvsroot/src/sys/netinet/tcp_usrreq.c,v <-- tcp_usrreq.c
new revision: 1.146; previous revision: 1.145
done
Checking in netinet/udp_usrreq.c;
/cvsroot/src/sys/netinet/udp_usrreq.c,v <-- udp_usrreq.c
new revision: 1.172; previous revision: 1.171
done
Checking in netinet6/icmp6.c;
/cvsroot/src/sys/netinet6/icmp6.c,v <-- icmp6.c
new revision: 1.147; previous revision: 1.146
done
Checking in netinet6/ip6_input.c;
/cvsroot/src/sys/netinet6/ip6_input.c,v <-- ip6_input.c
new revision: 1.119; previous revision: 1.118
done
Checking in netinet6/ip6_mroute.c;
/cvsroot/src/sys/netinet6/ip6_mroute.c,v <-- ip6_mroute.c
new revision: 1.93; previous revision: 1.92
done
Checking in netinet6/ipsec.c;
/cvsroot/src/sys/netinet6/ipsec.c,v <-- ipsec.c
new revision: 1.130; previous revision: 1.129
done
Checking in netinet6/raw_ip6.c;
/cvsroot/src/sys/netinet6/raw_ip6.c,v <-- raw_ip6.c
new revision: 1.99; previous revision: 1.98
done
Checking in netinet6/udp6_usrreq.c;
/cvsroot/src/sys/netinet6/udp6_usrreq.c,v <-- udp6_usrreq.c
new revision: 1.86; previous revision: 1.85
done
Checking in netipsec/ipsec_netbsd.c;
/cvsroot/src/sys/netipsec/ipsec_netbsd.c,v <-- ipsec_netbsd.c
new revision: 1.32; previous revision: 1.31
done
Checking in netipsec/key.c;
/cvsroot/src/sys/netipsec/key.c,v <-- key.c
new revision: 1.55; previous revision: 1.54
done
Checking in netkey/key.c;
/cvsroot/src/sys/netkey/key.c,v <-- key.c
new revision: 1.160; previous revision: 1.159
done
From: Jason R Thorpe <thorpej@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/38577 CVS commit: src/sys
Date: Sun, 4 May 2008 07:22:15 +0000 (UTC)
Module Name: src
Committed By: thorpej
Date: Sun May 4 07:22:15 UTC 2008
Modified Files:
src/sys/net: net_stats.c net_stats.h
src/sys/netatalk: ddp_usrreq.c
src/sys/netinet: if_arp.c igmp.c ip_carp.c ip_icmp.c ip_input.c
tcp_usrreq.c udp_usrreq.c
src/sys/netinet6: icmp6.c ip6_input.c ip6_mroute.c ipsec.c raw_ip6.c
udp6_usrreq.c
src/sys/netipsec: ipsec_netbsd.c key.c
src/sys/netkey: key.c
Log Message:
Simplify the interface to netstat_sysctl() and allocate space for
the collated counters using kmem_alloc().
PR kern/38577
To generate a diff of this commit:
cvs rdiff -r1.3 -r1.4 src/sys/net/net_stats.c
cvs rdiff -r1.2 -r1.3 src/sys/net/net_stats.h
cvs rdiff -r1.32 -r1.33 src/sys/netatalk/ddp_usrreq.c
cvs rdiff -r1.136 -r1.137 src/sys/netinet/if_arp.c
cvs rdiff -r1.48 -r1.49 src/sys/netinet/igmp.c
cvs rdiff -r1.25 -r1.26 src/sys/netinet/ip_carp.c
cvs rdiff -r1.118 -r1.119 src/sys/netinet/ip_icmp.c
cvs rdiff -r1.270 -r1.271 src/sys/netinet/ip_input.c
cvs rdiff -r1.145 -r1.146 src/sys/netinet/tcp_usrreq.c
cvs rdiff -r1.171 -r1.172 src/sys/netinet/udp_usrreq.c
cvs rdiff -r1.146 -r1.147 src/sys/netinet6/icmp6.c
cvs rdiff -r1.118 -r1.119 src/sys/netinet6/ip6_input.c
cvs rdiff -r1.92 -r1.93 src/sys/netinet6/ip6_mroute.c
cvs rdiff -r1.129 -r1.130 src/sys/netinet6/ipsec.c
cvs rdiff -r1.98 -r1.99 src/sys/netinet6/raw_ip6.c
cvs rdiff -r1.85 -r1.86 src/sys/netinet6/udp6_usrreq.c
cvs rdiff -r1.31 -r1.32 src/sys/netipsec/ipsec_netbsd.c
cvs rdiff -r1.54 -r1.55 src/sys/netipsec/key.c
cvs rdiff -r1.159 -r1.160 src/sys/netkey/key.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Keisuke YOSHIDA <kay@kaynet.or.jp>
To: gnats-bugs@NetBSD.org
Cc: thorpej@NetBSD.org,
netbsd-bugs@netbsd.org,
gnats-admin@netbsd.org,
kay@gaia.kaynet.or.jp
Subject: Re: kern/38577 (options IPSEC crashes when execute netstat -s)
Date: Wed, 7 May 2008 19:59:02 +0900
I built new kernel, and check it. It works fine. Thanks.
State-Changed-From-To: feedback->closed
State-Changed-By: degroote@NetBSD.org
State-Changed-When: Fri, 27 Jun 2008 17:25:47 +0000
State-Changed-Why:
User confirmed that the problem was fixed
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.