NetBSD Problem Report #38814

From martin@duskware.de  Sat May 31 19:46:43 2008
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 9E4AC63B8BC
	for <gnats-bugs@gnats.netbsd.org>; Sat, 31 May 2008 19:46:43 +0000 (UTC)
Message-Id: <20080531194535.E050F63B8BC@narn.NetBSD.org>
Date: Sat, 31 May 2008 19:45:35 +0000 (UTC)
From: ad@netbsd.org
Reply-To: ad@netbsd.org
To: netbsd-bugs-owner@NetBSD.org
Subject: ksyms needs locking
X-Send-Pr-Version: www-1.0

>Number:         38814
>Category:       kern
>Synopsis:       ksyms needs locking
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 31 19:50:00 +0000 2008
>Closed-Date:    Mon Oct 20 10:35:16 +0000 2008
>Last-Modified:  Mon Oct 20 10:35:16 +0000 2008
>Originator:     Andrew Doran
>Release:        4.99.64
>Organization:
The NetBSD Project
>Environment:
n/a
>Description:
ksyms functions can be called without kernel_lock held.

>How-To-Repeat:
Code inspection.
>Fix:
Implement locking in kern_ksyms.c.

ddb needs to be able to do lookups without taking locks.

>Release-Note:

>Audit-Trail:
From: Andrew Doran <ad@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/38814 CVS commit: src/sys
Date: Mon, 20 Oct 2008 10:24:18 +0000 (UTC)

 Module Name:	src
 Committed By:	ad
 Date:		Mon Oct 20 10:24:18 UTC 2008

 Modified Files:
 	src/sys/kern: init_main.c kern_ksyms.c kern_sysctl.c subr_kobj.c
 	src/sys/sys: ksyms.h

 Log Message:
 PR kern/38814 ksyms needs locking

 - Make ksyms MT safe.
 - Fix deadlock from an operation like "modload foo.lkm < /dev/ksyms".
 - Fix uninitialized structure members.
 - Reduce memory footprint for loaded modules.
 - Export ksyms structures for kernel grovellers like savecore.
 - Some KNF.


 To generate a diff of this commit:
 cvs rdiff -r1.366 -r1.367 src/sys/kern/init_main.c
 cvs rdiff -r1.38 -r1.39 src/sys/kern/kern_ksyms.c
 cvs rdiff -r1.216 -r1.217 src/sys/kern/kern_sysctl.c
 cvs rdiff -r1.22 -r1.23 src/sys/kern/subr_kobj.c
 cvs rdiff -r1.14 -r1.15 src/sys/sys/ksyms.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: ad@NetBSD.org
State-Changed-When: Mon, 20 Oct 2008 10:35:16 +0000
State-Changed-Why:
fixed


>Unformatted:

Home	PR Database Search