NetBSD Problem Report #389

From gnats  Wed Aug  3 19:28:35 1994
Received: from bloom-beacon.mit.edu (BLOOM-BEACON.MIT.EDU [18.181.0.26]) by sun-lamp.cs.berkeley.edu (8.6.9/8.6.9) with SMTP id TAA01073 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Wed, 3 Aug 1994 19:28:34 -0700
Message-Id: <199408040206.WAA00448@orchard.medford.ma.us>
Date: Wed, 3 Aug 1994 22:06:53 -0400
From: sommerfeld@orchard.medford.ma.us
Reply-To: sommerfeld@orchard.medford.ma.us
To: gnats-bugs@sun-lamp.cs.berkeley.edu
Subject: send-pr.el busted.
X-Send-Pr-Version: 3.2

>Number:         389
>Category:       bin
>Synopsis:       send-pr.el busted on non-gnats site.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnats-admin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 03 19:35:10 +0000 1994
>Closed-Date:    Thu Sep 14 14:02:01 +0000 1995
>Last-Modified:  Sun May 18 13:12:00 +0000 2003
>Originator:     Bill Sommerfeld
>Release:        1.0 Beta
>Organization:
	none
>Environment:

System: NetBSD orchard.medford.ma.us 1.0-ALPHA NetBSD 1.0-ALPHA (ORCHARD) #4: Fri Jul 22 10:36:08 EDT 1994 root@orchard.medford.ma.us:/u1/nsys/sys/arch/i386/compile/ORCHARD i386


>Description:
	send-pr looks for the file /usr/share/gnats/gnats-adm/config,
	which isn't distributed in NetBSD; it attempts to catch errors
	when this fails, but the way it does this is really lame.
	It's better to just see if the config file exists at all
	before bothering to start a subshell to parse it..

	Also, send-pr.el should be installed *somewhere* in the system..

	This should probably be reflected back to Cygnus.
>How-To-Repeat:
	start emacs
	load send-pr.el out of /src/gnu/usr.bin/send-pr/obj/send-pr.el
	M-x send-pr
>Fix:
	The change is smaller than it appears since I had to reindent
	the code..

diff -c -r1.1.1.1 send-pr-el.in
*** 1.1.1.1	1994/05/17 19:31:15
--- send-pr-el.in	1994/08/04 01:59:27
***************
*** 88,105 ****
  ;;; user in his/her .emacs file.
  ;;;
  (defun gnats::get-config (var)
!   (let ((shell-file-name "/bin/sh")
! 	(buf (generate-new-buffer " *GNATS config*"))
! 	ret)
!     (save-excursion
!       (set-buffer buf)
!       (shell-command (concat ". " gnats:root "/gnats-adm/config; echo $" var )
! 		     t)
!       (if (looking-at "/bin/sh:\\|\n")
! 	  (setq ret nil)
! 	(setq ret (buffer-substring (point-min) (- (point-max) 1)))))
!     (kill-buffer buf)
!     ret))

  ;; const because it must match the script's value
  (defconst send-pr:datadir (or (gnats::get-config "DATADIR") "xDATADIRx")
--- 88,107 ----
  ;;; user in his/her .emacs file.
  ;;;
  (defun gnats::get-config (var)
!   (let ((config-file (concat gnats:root "/gnats-adm/config")))
!     (if (file-exists-p config-file)
! 	(let ((shell-file-name "/bin/sh")
! 	      (buf (generate-new-buffer " *GNATS config*"))
! 	      ret)
! 	  (save-excursion
! 	    (set-buffer buf)
! 	    (shell-command (concat ". " config-file "; echo $" var )
! 			   t)
! 	    (if (looking-at "/bin/sh:\\|\n")
! 		(setq ret nil)
! 	      (setq ret (buffer-substring (point-min) (- (point-max) 1)))))
! 	  (kill-buffer buf)
! 	  ret))))

  ;; const because it must match the script's value
  (defconst send-pr:datadir (or (gnats::get-config "DATADIR") "xDATADIRx")
>Release-Note:
>Audit-Trail:

State-Changed-From-To: open->analyzed
State-Changed-By: jtc
State-Changed-When: Fri Sep  2 22:23:34 1994
State-Changed-Why:
Bug has been relayed to Cygnus.
This fix looks reasonable, and should probably be applyed while we wait 
for an official fix in a future GNATS release.

State-Changed-From-To: analyzed->closed
State-Changed-By: jtc
State-Changed-When: Thu Sep 14 14:02:01 1995
State-Changed-Why:
Integrated new version of send-pr, which fixes this problem.


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/389 CVS commit: pkgsrc/devel/automake
Date: Sun, 18 May 2003 13:10:59 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Sun May 18 13:10:58 UTC 2003

 Modified Files:
 	pkgsrc/devel/automake: Makefile distinfo

 Log Message:
 Update to 1.7.5:
 Bugs fixed in 1.7.5:
 * Update install-sh's license to remove an advertising clause.
   (Debian bug #191717)
 * Fix a bug introduced in 1.7.4, related to BUILT_SOURCE handling,
   that caused invalid Makefile.ins to be generated.
 * Make sure AM_MAKE_INCLUDE doesn't fail when a `doit' file exists.
 * New FAQ entry: renamed objects.

 Bugs fixed in 1.7.4:
 * Tweak the TAGS rule to support Exuberant Ctags (in addition to
   the Emacs implementation)
 * Fix output of aclocal.m4 dependencies in subdirectories.
 * Use `mv -f' instead of `mv' in fastdep rules.
 * Upgrade mdate-sh to work on OS/2.
 * Don't byte-compile elisp files when ELCFILES is set empty.
   (this documented feature was broken by 1.7.3)
 * Diagnose trailing backslashes on last line of Makefile.am.
 * Diagnose whitespace following trailing backslashes.
 * Multiple tests are now correctly supported in DEJATOOL. (PR/388)
 * Fix rebuilt rules for AC_CONFIG_FILES([Makefile:Makefile.in:Makefile.bot])
   Makefiles. (PR/389)
 * `make install' will build `BUILT_SOURCES' first.
 * Minor documentation fixes.


 To generate a diff of this commit:
 cvs rdiff -r1.35 -r1.36 pkgsrc/devel/automake/Makefile
 cvs rdiff -r1.11 -r1.12 pkgsrc/devel/automake/distinfo

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.