NetBSD Problem Report #39032

From www@NetBSD.org  Tue Jun 24 08:48:18 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 0EB0363B89F
	for <gnats-bugs@gnats.netbsd.org>; Tue, 24 Jun 2008 08:48:18 +0000 (UTC)
Message-Id: <20080624084817.8C66063B880@narn.NetBSD.org>
Date: Tue, 24 Jun 2008 08:48:17 +0000 (UTC)
From: hasso@estpak.ee
Reply-To: hasso@estpak.ee
To: gnats-bugs@NetBSD.org
Subject: net/ntp4 problems
X-Send-Pr-Version: www-1.0

>Number:         39032
>Category:       pkg
>Synopsis:       net/ntp4 problems
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    obache
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 24 08:50:00 +0000 2008
>Closed-Date:    Wed Jun 25 00:08:50 +0000 2008
>Last-Modified:  Wed Jun 25 00:08:50 +0000 2008
>Originator:     Hasso Tepper
>Release:        DragonFly
>Organization:
>Environment:
DragonFly
>Description:
net/ntp4 doesn't compile:

=> Checking file-check results for ntp-4.2.4p4
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /usr/pkg:
ERROR:         /usr/pkg/share/doc/ntp4/build/hints/dragonfly
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg but not in the PLIST:
ERROR:         /usr/pkg/bin/ntptime
ERROR:         /usr/pkg/bin/tickadj
ERROR:         /usr/pkg/share/doc/ntp4/build/hints/netbsd
*** Error code 1

After fixing these PLIST problems (see below) new problem appears:

=> Checking for work-directory references in ntp-4.2.4p4
ERROR: /usr/pkg/bin/ntp-wait:   #! /usr/obj/pkgsrc/net/ntp4/work/.tools/bin/perl -w
ERROR: /usr/pkg/bin/ntptrace:   #! /usr/obj/pkgsrc/net/ntp4/work/.tools/bin/perl -w
ERROR: *** The above files still have references to the build directory.
ERROR:     This is possibly an error that should be fixed by unwrapping
ERROR:     the files or adding missing tools to the package makefile!
*** Error code 1

>How-To-Repeat:

>Fix:
Regarding PLIST problems two points:

* /usr/pkg/share/doc/ntp4/build/hints/netbsd is installed regardless what OS is in use, therefore the change introduced with last update is just wrong and should be reverted:

-share/doc/ntp4/build/hints/${LOWER_OPSYS}
+share/doc/ntp4/build/hints/netbsd

* I'm not sure what systems are affected, but ntptime isn't specific to NetBSD - at least in DragonFly it is compiled as well, so:

-.if ${OPSYS} == "NetBSD"
+.if ${OPSYS} == "NetBSD" || ${OPSYS} == "DragonFly"
 PLIST.ntptime=         yes

No idea how to fix interpreters.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->obache
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Tue, 24 Jun 2008 10:08:14 +0000
Responsible-Changed-Why:
I updated the package.


State-Changed-From-To: open->feedback
State-Changed-By: obache@NetBSD.org
State-Changed-When: Tue, 24 Jun 2008 11:49:01 +0000
State-Changed-Why:
Should be fixed.  Please confirm fixes on your environment.


From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39032 CVS commit: pkgsrc/net/ntp4
Date: Tue, 24 Jun 2008 11:47:14 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Tue Jun 24 11:47:13 UTC 2008

 Modified Files:
 	pkgsrc/net/ntp4: Makefile PLIST

 Log Message:
 Fixes some problems noticed by Hasso Tepper in PR 39032.
  * Fix perl path in scripts, add runtime dependency on perl.
  * Fix unwanted PLIST subst.
  * DragonFly also support ntptime.

 Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -r1.56 -r1.57 pkgsrc/net/ntp4/Makefile
 cvs rdiff -r1.10 -r1.11 pkgsrc/net/ntp4/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Hasso Tepper <hasso@estpak.ee>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/39032 (net/ntp4 problems)
Date: Tue, 24 Jun 2008 20:43:20 +0300

 obache@netbsd.org wrote:
 > Should be fixed.  Please confirm fixes on your environment.

 Yes, it's fixed now. Thanks.


 -- 
 Hasso Tepper

State-Changed-From-To: feedback->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Wed, 25 Jun 2008 00:08:50 +0000
State-Changed-Why:
Fix confirmed by submitter.  Thanks!


>Unformatted:

Home	PR Database Search