NetBSD Problem Report #39276

From www@NetBSD.org  Sun Aug  3 08:53:14 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 7350D63B977
	for <gnats-bugs@gnats.netbsd.org>; Sun,  3 Aug 2008 08:53:14 +0000 (UTC)
Message-Id: <20080803085314.2E57163B975@narn.NetBSD.org>
Date: Sun,  3 Aug 2008 08:53:14 +0000 (UTC)
From: qhwt+nbsd@les.ath.cx
Reply-To: qhwt+nbsd@les.ath.cx
To: gnats-bugs@NetBSD.org
Subject: pkg_admin rebuild-tree crash (pkgtools/pkg_install)
X-Send-Pr-Version: www-1.0

>Number:         39276
>Category:       pkg
>Synopsis:       pkg_admin rebuild-tree crash (pkgtools/pkg_install)
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    joerg
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 03 08:55:00 +0000 2008
>Closed-Date:    Sat Sep 20 02:42:17 +0000 2008
>Last-Modified:  Sat Sep 20 02:42:17 +0000 2008
>Originator:     YONETANI Tomokazu
>Release:        
>Organization:
>Environment:
DragonFly firebolt.here 2.0.0-RELEASE DragonFly 2.0.0-RELEASE #0: Sun Aug  3 16:30:55 JST 2008     dragonfly@firebolt.here:/var/obj/R2_0/home/source/dragonfly/R2_0/src/sys/FIREBOLT.SMP  i386
>Description:
pkg_admin, part of pkgtools/pkg_install package, crashed when I issued `rebuild-tree' command.  add_depends_of() passes a variable `plist' to read_plist() without first initializing it, which gets dereferenced later on in add_plist().
>How-To-Repeat:
It's an uninitialized pointer dereference, so it may not always reproduce depending on your environment.

  pkg_admin rebuild-tree some-non-important-package

>Fix:
Initialize plist before call to read_plist.

--- a/pkgtools/pkg_install/files/admin/main.c
+++ b/pkgtools/pkg_install/files/admin/main.c
@@ -310,6 +310,7 @@ add_depends_of(const char *pkgname, void *cookie)
        package_t plist;
        char *path;

+       plist.head = plist.tail = NULL;
        path = pkgdb_pkg_file(pkgname, CONTENTS_FNAME);
        if ((fp = fopen(path, "r")) == NULL)
                errx(EXIT_FAILURE, "Cannot read %s of package %s",

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->joerg
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Sun, 03 Aug 2008 08:59:35 +0000
Responsible-Changed-Why:
Over to maintainer.


From: YONETANI Tomokazu <qhwt+nbsd@les.ath.cx>
To: joerg@NetBSD.org
Cc: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-bugs@NetBSD.org,
	gnats-admin@netbsd.org, obache@NetBSD.org
Subject: Re: pkg/39276 (pkg_admin rebuild-tree crash (pkgtools/pkg_install))
Date: Tue, 2 Sep 2008 15:35:55 +0900

 On Sun, Aug 03, 2008 at 08:59:37AM +0000, obache@NetBSD.org wrote:
 > Synopsis: pkg_admin rebuild-tree crash (pkgtools/pkg_install)
 > 
 > Responsible-Changed-From-To: pkg-manager->joerg
 > Responsible-Changed-By: obache@NetBSD.org
 > Responsible-Changed-When: Sun, 03 Aug 2008 08:59:35 +0000
 > Responsible-Changed-Why:
 > Over to maintainer.

 Wie geht's?

From: YONETANI Tomokazu <qhwt+nbsd@les.ath.cx>
To: joerg@britannica.bec.de
Cc: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org,
	gnats-admin@netbsd.org, obache@NetBSD.org
Subject: Re: pkg/39276 (pkg_admin rebuild-tree crash (pkgtools/pkg_install))
Date: Wed, 17 Sep 2008 11:45:49 +0900

 On Sun, Aug 03, 2008 at 08:59:37AM +0000, obache@NetBSD.org wrote:
 > Synopsis: pkg_admin rebuild-tree crash (pkgtools/pkg_install)
 > 
 > Responsible-Changed-From-To: pkg-manager->joerg
 > Responsible-Changed-By: obache@NetBSD.org
 > Responsible-Changed-When: Sun, 03 Aug 2008 08:59:35 +0000
 > Responsible-Changed-Why:
 > Over to maintainer.

 I guess you're not reading mails to joerg@netbsd.org, do you?

 Cheers.

From: Joerg Sonnenberger <joerg@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39276 CVS commit: pkgsrc/pkgtools/pkg_install/files
Date: Wed, 17 Sep 2008 15:21:30 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	joerg
 Date:		Wed Sep 17 15:21:30 UTC 2008

 Modified Files:
 	pkgsrc/pkgtools/pkg_install/files/add: perform.c
 	pkgsrc/pkgtools/pkg_install/files/admin: check.c main.c
 	pkgsrc/pkgtools/pkg_install/files/create: perform.c
 	pkgsrc/pkgtools/pkg_install/files/delete: perform.c
 	pkgsrc/pkgtools/pkg_install/files/lib: conflicts.c lib.h plist.c
 	    version.h

 Log Message:
 pkg_install-20080916:
 Merge from changes for read_plist from pkg_install-renovation to always
 initialize the plist and add append_plist for the one case where this is
 not desired. Fixes PR 39276.


 To generate a diff of this commit:
 cvs rdiff -r1.72 -r1.73 pkgsrc/pkgtools/pkg_install/files/add/perform.c
 cvs rdiff -r1.4 -r1.5 pkgsrc/pkgtools/pkg_install/files/admin/check.c
 cvs rdiff -r1.44 -r1.45 pkgsrc/pkgtools/pkg_install/files/admin/main.c
 cvs rdiff -r1.21 -r1.22 pkgsrc/pkgtools/pkg_install/files/create/perform.c
 cvs rdiff -r1.23 -r1.24 pkgsrc/pkgtools/pkg_install/files/delete/perform.c
 cvs rdiff -r1.6 -r1.7 pkgsrc/pkgtools/pkg_install/files/lib/conflicts.c
 cvs rdiff -r1.44 -r1.45 pkgsrc/pkgtools/pkg_install/files/lib/lib.h
 cvs rdiff -r1.20 -r1.21 pkgsrc/pkgtools/pkg_install/files/lib/plist.c
 cvs rdiff -r1.104 -r1.105 pkgsrc/pkgtools/pkg_install/files/lib/version.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: YONETANI Tomokazu <qhwt+nbsd@les.ath.cx>
To: joerg@NetBSD.org
Cc: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: PR/39276 CVS commit: pkgsrc/pkgtools/pkg_install/files
Date: Thu, 18 Sep 2008 11:28:48 +0900

 On Wed, Sep 17, 2008 at 03:25:03PM +0000, Joerg Sonnenberger wrote:
 >  pkg_install-20080916:
 >  Merge from changes for read_plist from pkg_install-renovation to always
 >  initialize the plist and add append_plist for the one case where this is
 >  not desired. Fixes PR 39276.

 Ugh, I completely overlooked your development on that branch.
 Thanks and sorry for the noise.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 18 Sep 2008 05:10:25 +0000
State-Changed-Why:
Fixed?


From: YONETANI Tomokazu <qhwt+nbsd@les.ath.cx>
To: gnats-bugs@NetBSD.org
Cc: joerg@NetBSD.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org,
	dholland@NetBSD.org
Subject: Re: pkg/39276 (pkg_admin rebuild-tree crash (pkgtools/pkg_install))
Date: Sat, 20 Sep 2008 11:38:11 +0900

 On Thu, Sep 18, 2008 at 05:10:26AM +0000, dholland@NetBSD.org wrote:
 > Synopsis: pkg_admin rebuild-tree crash (pkgtools/pkg_install)
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: dholland@NetBSD.org
 > State-Changed-When: Thu, 18 Sep 2008 05:10:25 +0000
 > State-Changed-Why:
 > Fixed?

 this can be closed (I don't know about other issues fixed/improved by
 pkg_install-renovation branch which has just been merged, though).

 Thanks.

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 20 Sep 2008 02:42:17 +0000
State-Changed-Why:
Confirmed fixed, thanks.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.