NetBSD Problem Report #39433

From riastradh@smalltalk.localdomain  Fri Aug 29 17:15:35 2008
Return-Path: <riastradh@smalltalk.localdomain>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 82BF063B8A9
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 29 Aug 2008 17:15:35 +0000 (UTC)
Message-Id: <20080829171442.6B7F36A@smalltalk.localdomain>
Date: Fri, 29 Aug 2008 17:14:42 +0000 (UTC)
From: Taylor R Campbell <campbell@mumble.net>
Reply-To: Taylor R Campbell <campbell@mumble.net>
To: gnats-bugs@gnats.NetBSD.org
Subject: enable zlib support in OpenSSL
X-Send-Pr-Version: 3.95

>Number:         39433
>Category:       pkg
>Synopsis:       enable zlib support in OpenSSL
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 29 17:20:01 +0000 2008
>Closed-Date:    Wed Sep 17 00:49:25 +0000 2008
>Last-Modified:  Wed Sep 17 00:50:03 +0000 2008
>Originator:     Taylor R Campbell <campbell@mumble.net>
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
System: NetBSD smalltalk.localdomain 4.0_STABLE NetBSD 4.0_STABLE (RIAXEN3_DOM0) #4: Sat Aug 23 06:25:39 UTC 2008 riastradh@smalltalk.localdomain:/home/riastradh/netbsd/4/obj/sys/arch/i386/compile/RIAXEN3_DOM0 i386
Architecture: i386
Machine: i386
>Description:

	OpenSSL supports the use of zlib to compress data transmitted
	over TLS sessions, but it is disabled by default.  Since zlib
	is available nearly everywhere, including the NetBSD base
	system, it is probably sensible to enable this by default (and
	it would be convenient if enabled in the NetBSD base system's
	OpenSSL, too).  At the very least, it would be nice to have as
	an option when building OpenSSL.

>How-To-Repeat:
>Fix:

	Add `zlib' to CONFIGURE_ARGS, perhaps only if a new option,
	say, `openssl-zlib', is selected.

>Release-Note:

>Audit-Trail:
From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/39433
Date: Tue, 2 Sep 2008 09:10:30 -0500 (CDT)

 Does this work for you?

 Should it be openssl-zlib option like you suggested or just zlib?

 cvs diff: Diffing .
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/security/openssl/Makefile,v
 retrieving revision 1.134
 diff -u -r1.134 Makefile
 --- Makefile	14 Jul 2008 03:52:54 -0000	1.134
 +++ Makefile	2 Sep 2008 14:08:13 -0000
 @@ -3,6 +3,7 @@
  OPENSSL_SNAPSHOT?=	# empty
  OPENSSL_STABLE?=	# empty
  OPENSSL_VERS?=		0.9.8h
 +PKGREVISION=		1

  .if empty(OPENSSL_SNAPSHOT)
  DISTNAME=	openssl-${OPENSSL_VERS}
 Index: options.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/security/openssl/options.mk,v
 retrieving revision 1.5
 diff -u -r1.5 options.mk
 --- options.mk	12 Apr 2008 22:43:12 -0000	1.5
 +++ options.mk	2 Sep 2008 14:08:13 -0000
 @@ -1,7 +1,7 @@
  # $NetBSD: options.mk,v 1.5 2008/04/12 22:43:12 jlam Exp $

  PKG_OPTIONS_VAR=	PKG_OPTIONS.openssl
 -PKG_SUPPORTED_OPTIONS=	idea mdc2 rc5
 +PKG_SUPPORTED_OPTIONS=	idea mdc2 rc5 zlib

  .include "../../mk/bsd.options.mk"

 @@ -48,6 +48,13 @@
  CONFIGURE_ARGS+=	no-rc5
  .endif

 +.if !empty(PKG_OPTIONS:Mzlib)
 +CONFIGURE_ARGS+=	enable-zlib
 +.include "../../devel/zlib/buildlink3.mk"
 +.else
 +CONFIGURE_ARGS+=	no-zlib
 +.endif
 +
  .if !empty(OPENSSL_LICENSE)
  # pkgsrc does not handle multiple licenses
  LICENSE=	openssl-patented-algorithms-nonlicense
 cvs diff: Diffing patches

From: Taylor R Campbell <campbell@mumble.net>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/39433
Date: Tue, 2 Sep 2008 17:27:14 -0400

    Date: Tue,  2 Sep 2008 14:15:04 +0000 (UTC)
    From: "Jeremy C. Reed" <reed@reedmedia.net>

    Does this work for you?

 I don't believe it will -- see below.

    Should it be openssl-zlib option like you suggested or just zlib?

 There is currently no `zlib' or `openssl-zlib' option in
 mk/defaults/options.description.  There is a `links-zlib' option,
 which is obviously inapplicable.  Adding a general `zlib' option, or
 enabling zlib by default (wherever it can be enabled), seems most
 sensible to me, but adding an `openssl-zlib' option would be least
 invasive.

    @@ -48,6 +48,13 @@
     CONFIGURE_ARGS+=	no-rc5
     .endif

    +.if !empty(PKG_OPTIONS:Mzlib)
    +CONFIGURE_ARGS+=	enable-zlib
    +.include "../../devel/zlib/buildlink3.mk"
    +.else
    +CONFIGURE_ARGS+=	no-zlib
    +.endif
    +
     .if !empty(OPENSSL_LICENSE)
     # pkgsrc does not handle multiple licenses
     LICENSE=	openssl-patented-algorithms-nonlicense

 The argument you have to pass to the configure script is `zlib', not
 `enable-zlib'.  There is another option, `zlib-dynamic', for using a
 zlib shared library if one is available, and proceeding without zlib
 if one is not available.  Considering the ubiquity of zlib, however, I
 think that using the vanilla `zlib' option is preferable.

From: Taylor R Campbell <campbell@mumble.net>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org,
	gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
	"Jeremy C. Reed" <reed@reedmedia.net>
Cc: 
Subject: Re: pkg/39433
Date: Tue, 16 Sep 2008 17:02:08 -0400

 Except for the configure argument, which must be either `zlib' or
 `zlib-dynamic', the patch will work.  Is this waiting for anything
 else?

 Alternatively, we could just add `zlib' or `zlib-dynamic' to the
 configure arguments in the makefile, and depend on devel/zlib always,
 without introducing a new option.

State-Changed-From-To: open->closed
State-Changed-By: reed@NetBSD.org
State-Changed-When: Wed, 17 Sep 2008 00:49:25 +0000
State-Changed-Why:
Committed this.
Not enabled by default.
The enable-zlib worked before because in the Configure script the zlib was
converted to enable-zlib. I am just using "zlib" now as the Configure
argument though.
.


From: "Jeremy C. Reed" <reed@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39433 CVS commit: pkgsrc/security/openssl
Date: Wed, 17 Sep 2008 00:46:58 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	reed
 Date:		Wed Sep 17 00:46:58 UTC 2008

 Modified Files:
 	pkgsrc/security/openssl: Makefile options.mk

 Log Message:
 Add zlib option.
 This is for PR 39433.
 It is not enabled by default.


 To generate a diff of this commit:
 cvs rdiff -r1.134 -r1.135 pkgsrc/security/openssl/Makefile
 cvs rdiff -r1.5 -r1.6 pkgsrc/security/openssl/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search