NetBSD Problem Report #39443

From leonardo1990@gmail.com  Mon Sep  1 00:38:13 2008
Return-Path: <leonardo1990@gmail.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id C17CA63BC30
	for <gnats-bugs@gnats.netbsd.org>; Mon,  1 Sep 2008 00:38:13 +0000 (UTC)
Message-Id: <48bb070c.0a04d00a.75c9.ffffd681@mx.google.com>
Date: Sun, 31 Aug 2008 14:03:08 -0700 (PDT)
From: leonardo1990@gmail.com
Reply-To: leonardo1990@gmail.com
To: gnats-bugs@gnats.NetBSD.org
Subject: DESTDIR support for pkgtools/pkgfind
X-Send-Pr-Version: 3.95

>Number:         39443
>Category:       pkg
>Synopsis:       pkgtools/pkgfind: doesn't support DESTDIR
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 01 00:40:00 +0000 2008
>Closed-Date:    Tue Sep 02 11:10:25 +0000 2008
>Last-Modified:  Tue Sep 02 11:15:03 +0000 2008
>Originator:     Leonardo Taccari
>Release:        NetBSD 4.0
>Organization:
NetBSD Italia
>Environment:


System: NetBSD bianconiglio 4.0 NetBSD 4.0 (BIANCONIGLIO) #3: Tue Jul 1 06:54:05 CEST 2008 leot@bianconiglio:/home/leot/builds/usr/src/sys/arch/i386/compile/BIANCONIGLIO i386
Architecture: i386
Machine: i386
>Description:
pkgtools/pkgfind doesn't support DESTDIR and pkgtools/pkglint warns
about the @${CP}.
>How-To-Repeat:
For the former:

	$ cd ${PKGSRCDIR}/pkgtools/pkgfind
	$ USE_DESTDIR=full make install

For the latter:

	$ cd ${PKGSRCDIR}/pkgtools/pkgfind
	$ pkglint -Wall
	WARN: Makefile:20: The shell command "${CP}" should not be hidden.
	0 errors and 1 warnings found.
>Fix:
Please apply the following patch. Thank you very much!


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkgfind/Makefile,v
retrieving revision 1.20
diff -u -p -r1.20 Makefile
--- Makefile	27 Dec 2007 23:19:06 -0000	1.20
+++ Makefile	31 Aug 2008 20:43:12 -0000
@@ -8,6 +8,7 @@ DISTFILES=	# empty
 MAINTAINER=	pkgsrc-users@NetBSD.org
 COMMENT=	Find packages by package name in pkgsrc

+PKG_DESTDIR_SUPPORT=	user-destdir
 PKG_INSTALLATION_TYPES=	overwrite pkgviews

 NO_CHECKSUM=	yes
@@ -17,15 +18,15 @@ USE_FEATURES=	err getprogname setprognam
 INSTALLATION_DIRS=	bin ${PKGMANDIR}/man1

 do-extract:
-	@${CP} -R ${FILESDIR} ${WRKSRC}
+	${RUN} ${CP} -R ${FILESDIR} ${WRKSRC}

 do-build:
 	${CC} ${CFLAGS} ${CPPFLAGS} ${LDFLAGS} -o ${WRKSRC}/pkgfind	\
 		${WRKSRC}/pkgfind.c ${LIBS}

 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/pkgfind ${PREFIX}/bin/pkgfind
-	${INSTALL_MAN} ${WRKSRC}/pkgfind.1 ${PREFIX}/${PKGMANDIR}/man1/pkgfind.1
+	${INSTALL_PROGRAM} ${WRKSRC}/pkgfind ${DESTDIR}${PREFIX}/bin/pkgfind
+	${INSTALL_MAN} ${WRKSRC}/pkgfind.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1/pkgfind.1

 SUBST_CLASSES+=		path
 SUBST_STAGE.path=	post-patch

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Tue, 02 Sep 2008 11:10:25 +0000
State-Changed-Why:
Fixed.  Thanks!


From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39443 CVS commit: pkgsrc/pkgtools/pkgfind
Date: Tue,  2 Sep 2008 11:09:59 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Tue Sep  2 11:09:59 UTC 2008

 Modified Files:
 	pkgsrc/pkgtools/pkgfind: Makefile

 Log Message:
 Add DESTDIR support and stop one pkglint warning.
 Requested by Leonardo Taccari in PR 39443.


 To generate a diff of this commit:
 cvs rdiff -r1.20 -r1.21 pkgsrc/pkgtools/pkgfind/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.