NetBSD Problem Report #39457

From www@NetBSD.org  Wed Sep  3 21:54:21 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 5EBB663BC96
	for <gnats-bugs@gnats.netbsd.org>; Wed,  3 Sep 2008 21:54:21 +0000 (UTC)
Message-Id: <20080903215421.0FFE163BC80@narn.NetBSD.org>
Date: Wed,  3 Sep 2008 21:54:21 +0000 (UTC)
From: frederik.sausmikat@gmx.de
Reply-To: frederik.sausmikat@gmx.de
To: gnats-bugs@NetBSD.org
Subject: Add uplcom support for ROTRONIC (ROLINE) USB-Serial adapter
X-Send-Pr-Version: www-1.0

>Number:         39457
>Category:       kern
>Synopsis:       Add uplcom support for ROTRONIC (ROLINE) USB-Serial adapter
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    martin
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 03 21:55:00 +0000 2008
>Closed-Date:    Tue Sep 16 20:08:08 +0000 2008
>Last-Modified:  Tue Sep 16 20:08:08 +0000 2008
>Originator:     Frederik Sausmikat
>Release:        NetBSD 4.99.72
>Organization:
>Environment:
NetBSD eee 4.99.72 NetBSD 4.99.72 (GENERIC) #2: Wed Sep  3 09:27:19 CEST 2008 root@pc50-s74.fhr.fgan.de:/home/fsausm/nbusb/usr/src/sys/arch/i386/compile/obj/GENERIC i386
>Description:
The adapter in general is already supported by uplcom (so there are no modifications to usbdevs neccesary) but the ROTRONIC (and others) features the more modern HX variant of the PL-2303 chip for which the attached patch applies.

usbdevs -v output:
port 1 addr 2: full speed, power 100 mA, config 1, USB-Serial Controller D(0x2008), Prolific Technology Inc.(0x0557), rev 3.00

>How-To-Repeat:

>Fix:
Index: uplcom.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uplcom.c,v
retrieving revision 1.65
diff -u -r1.65 uplcom.c
--- uplcom.c    24 May 2008 16:40:58 -0000      1.65
+++ uplcom.c    3 Sep 2008 21:01:49 -0000
@@ -163,6 +163,9 @@
        /* I/O DATA USB-RSAQ5 */
        { { USB_VENDOR_IODATA, USB_PRODUCT_IODATA_USBRSAQ5 },
                -1, UPLCOM_TYPE_HX },
+       /* ROTRONIC 12.02.1086 */
+       { { USB_VENDOR_ATEN, USB_PRODUCT_ATEN_UC232A },
+               0x300, UPLCOM_TYPE_HX },
        /* PLANEX USB-RS232 URS-03 */
        { { USB_VENDOR_ATEN, USB_PRODUCT_ATEN_UC232A },
                -1, UPLCOM_TYPE_0 },

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->martin
Responsible-Changed-By: martin@NetBSD.org
Responsible-Changed-When: Thu, 04 Sep 2008 08:24:20 +0000
Responsible-Changed-Why:
I'll handle it


From: Martin Husemann <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39457 CVS commit: src/sys/dev/usb
Date: Tue, 16 Sep 2008 20:00:17 +0000 (UTC)

 Module Name:	src
 Committed By:	martin
 Date:		Tue Sep 16 20:00:17 UTC 2008

 Modified Files:
 	src/sys/dev/usb: uplcom.c

 Log Message:
 Remove hardcoded vendor/product ID based lookup for HX type chips and
 decide based on the device descriptor instead. Simplifies things a
 lot and fixes PR 39457.


 To generate a diff of this commit:
 cvs rdiff -r1.65 -r1.66 src/sys/dev/usb/uplcom.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 16 Sep 2008 20:08:08 +0000
State-Changed-Why:
Fixed, thanks for the PR


>Unformatted:

Home	PR Database Search