NetBSD Problem Report #39580

From www@NetBSD.org  Thu Sep 18 18:59:09 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 89D9B63B877
	for <gnats-bugs@gnats.netbsd.org>; Thu, 18 Sep 2008 18:59:09 +0000 (UTC)
Message-Id: <20080918185909.3A9E863B842@narn.NetBSD.org>
Date: Thu, 18 Sep 2008 18:59:09 +0000 (UTC)
From: thacrazze@googlemail.com
Reply-To: thacrazze@googlemail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips
X-Send-Pr-Version: www-1.0

>Number:         39580
>Category:       kern
>Synopsis:       [PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          support
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 18 19:00:00 +0000 2008
>Closed-Date:    Mon Jul 23 07:49:24 +0000 2012
>Last-Modified:  Wed Oct 24 03:40:01 +0000 2012
>Originator:     Peter Mockel
>Release:        NetBSD-HEAD
>Organization:
Private
>Environment:
NetBSD 4.99.72 amd64
>Description:
Hello,

I made a patch. This patch  adding the PC-IDs for the ASUS F5SL-AP177D
Notebook and some SiS chips


This is my first patch. It would give me great pleasure if someone
commit this patch :)

The patch is attached.

Best regards,
>How-To-Repeat:

> product ATI RADEON_M82_95C4   0x95c4  Mobility Radeon HD 3400 Series (M82)
adopted from: http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-radeonhd;a=blob_plain;f=src/rhd_id.c
and http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-ati.git;a=blob_plain;f=src/ati_pciids_gen.h

> product SIS 7502              0x7502  7502 HD Sound
adopted from: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=sound/pci/hda/hda_intel.c;h=2b6bd3139b86d09203d5a9a0b4084a9d9d51e4ba;hp=288ab07648305576a4f2b754c6102e55a76502f5;hb=47672310789431c16de22f16934febf4d55b4bb0;hpb=a93bf99077886d209f8e72bc134e1ceb36e76aa2

For SiS 671 see:
http://www.sis.com/products/sis671.htm

And for SiS 966 and 968 see:
http://www.sis.com/products/sis966.htm
http://www.sis.com/products/sis968.htm
(useful for comparison with the already existing 965 PCI ID:
http://www.sis.com/products/sis965.htm)
>Fix:
--- pcidevs.old 2008-09-07 16:47:44.000000000 +0200
+++ pcidevs     2008-09-07 17:57:37.000000000 +0200
@@ -1320,6 +1320,7 @@
 product ATI RS690_PPB_7915     0x7915  RS690 PCI to PCI-Express Port 1 Bridge
 product ATI RS690_PPB_7916     0x7916  RS690 PCI to PCI-Express Port 2 Bridge
 product ATI RS690_PPB_7917     0x7917  RS690 PCI to PCI-Express Port 3 Bridge
+product ATI RADEON_M82_95C4    0x95c4  Mobility Radeon HD 3400 Series (M82)
 product ATI RADEON_HD2600_XT   0x9588  Radeon HD2600 XT GDDR3
 product ATI RADEON_HD2600_HD   0xaa08  Radeon HD2600 HD Audio Controller

@@ -3583,7 +3584,9 @@
 product SIS 180_SATA           0x0180  180 SATA controller
 product SIS 181_SATA           0x0181  181 SATA controller
 product SIS 182_SATA           0x0182  182 SATA controller
+product SIS 183_SATA           0x0183  183 SATA controller
 product SIS 190                        0x0190  190 Ethernet
+product SIS 191                        0x0191  191 Gigabit Ethernet
 product SIS 5597_VGA           0x0200  5597/5598 integrated VGA
 product SIS 300                        0x0300  300/305 AGP VGA
 product SIS 85C501             0x0406  85C501
@@ -3606,6 +3609,7 @@
 product SIS 655                        0x0655  655 Host Bridge
 product SIS 658                        0x0658  658 Host Bridge
 product SIS 661                        0x0661  661 Host Bridge
+product SIS 671                        0x0671  671 Host Bridge
 product SIS 730                        0x0730  730 Host Bridge
 product SIS 733                        0x0733  733 Host Bridge
 product SIS 735                        0x0735  735 Host Bridge
@@ -3627,6 +3631,8 @@
 product SIS 963                        0x0963  963 Host Bridge
 product SIS 964                        0x0964  964 Host Bridge
 product SIS 965                        0x0965  965 Host Bridge
+product SIS 966                        0x0966  966 Host Bridge
+product SIS 968                        0x0968  968 Host Bridge
 product SIS 5597_IDE           0x5513  5597/5598 IDE controller
 product SIS 5597_HB            0x5597  5597/5598 host bridge
 product SIS 530VGA             0x6306  530 GUI Accelerator+3D
@@ -3637,6 +3643,7 @@
 product SIS 7012_AC            0x7012  7012 AC-97 Sound
 product SIS 7016               0x7016  7016 10/100 Ethernet
 product SIS 7018               0x7018  7018 Sound
+product SIS 7502               0x7502  7502 HD Sound

 /* Silicon Motion products */
 product SILMOTION SM710                0x0710  LynxEM

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: port-amd64-maintainer->kern-bug-people
Responsible-Changed-By: martin@NetBSD.org
Responsible-Changed-When: Thu, 18 Sep 2008 19:02:43 +0000
Responsible-Changed-Why:
this is not amd64 specific


From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/39580: [PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips
Date: Thu, 18 Sep 2008 21:04:01 +0200

 Please describe the problem you are solving - what does not work before
 and how does it magically work with this patch applied?

 Sorry, I don't see it.

 Martin

From: thacrazze <thacrazze@googlemail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/39580: [PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips
Date: Fri, 19 Sep 2008 15:20:57 +0200

 Sound works, fixes the error messages in dmesg

 On Thu, Sep 18, 2008 at 9:05 PM, Martin Husemann <martin@duskware.de> wrote:
 > The following reply was made to PR kern/39580; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin@duskware.de>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: kern/39580: [PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips
 > Date: Thu, 18 Sep 2008 21:04:01 +0200
 >
 >  Please describe the problem you are solving - what does not work before
 >  and how does it magically work with this patch applied?
 >
 >  Sorry, I don't see it.
 >
 >  Martin
 >
 >

From: thacrazze <thacrazze@googlemail.com>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: kern/39580: [PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips
Date: Fri, 19 Sep 2008 15:21:23 +0200

 Sound works, fixes the error messages in dmesg

 On Thu, Sep 18, 2008 at 9:05 PM, Martin Husemann <martin@duskware.de> wrote:
 > The following reply was made to PR kern/39580; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin@duskware.de>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: kern/39580: [PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips
 > Date: Thu, 18 Sep 2008 21:04:01 +0200
 >
 >  Please describe the problem you are solving - what does not work before
 >  and how does it magically work with this patch applied?
 >
 >  Sorry, I don't see it.
 >
 >  Martin
 >
 >

From: Martin Husemann <martin@duskware.de>
To: thacrazze <thacrazze@googlemail.com>
Cc: gnats-bugs@netbsd.org, kern-bug-people@netbsd.org,
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: kern/39580: [PATCH] Add PCI-IDs for ASUS-F5SL and some SiS chips
Date: Fri, 19 Sep 2008 16:54:27 +0200

 On Fri, Sep 19, 2008 at 03:21:23PM +0200, thacrazze wrote:
 > Sound works, fixes the error messages in dmesg

 Can you please 

  (a) provide the dmesg before the change and mark what you consider error
      messages

  (b) provide the dmesg with you patch applied

  (c) check if sound realy does not work without your patch?
      I can't see where the azalia driver would ever care about the pcidevs
      table.

 Thanks

 Martin

State-Changed-From-To: open->closed
State-Changed-By: msaitoh@NetBSD.org
State-Changed-When: Mon, 23 Jul 2012 07:49:24 +0000
State-Changed-Why:
fixed in -current.
Thanks.


From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39580 CVS commit: src/sys/dev/pci
Date: Mon, 23 Jul 2012 07:47:15 +0000

 Module Name:	src
 Committed By:	msaitoh
 Date:		Mon Jul 23 07:47:15 UTC 2012

 Modified Files:
 	src/sys/dev/pci: pcidevs

 Log Message:
 Add some ATI and SIS devices.
 Fixes PR#39580


 To generate a diff of this commit:
 cvs rdiff -u -r1.1123 -r1.1124 src/sys/dev/pci/pcidevs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39580 CVS commit: [netbsd-6] src/sys/dev/pci
Date: Wed, 24 Oct 2012 03:35:42 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Wed Oct 24 03:35:42 UTC 2012

 Modified Files:
 	src/sys/dev/pci [netbsd-6]: pcidevs

 Log Message:
 Apply patch (requested by msaitoh in ticket #631):

  This patch doesn't include any changes that rename ID.

 ==================================================================
 sys/dev/pci/pcidevs	1.1103,1.1105,1.1109-1.1112,1.1114,1.1119-1.1124,
 			1.1126-1.1128,1.1130-1.1136,1.1138-1.1142

 	Added Ricoh 5CE823.
 	Added some AMD/ATI devices.
 	Add Marvell Yukon 88e8040 ethernet.
 	More broadcom stuff.
 	Add IDs for Fresco Logic and their FL1000 and FL1009 xHCI chips.
 	NEC uPD720100A is USB2.
 	Add NEC uPD720200, a USB3 Host Controller.
 	Add Intel Sandybridge integrated graphics.
 	Add Marvell SoC 88F6282.
 	Add XGI Technology's devices.
 	Add some Intel's devices.
 	Add more FREESCALE devices.
 	Fix RICOH RU5230 description.
 	Add some Intel 7 series devices.
 	Add some ATI and SIS devices. Fixes PR#39580.
 	Add VirtualBox ids.
 	Add EG20T PCH.  Closes PR/45567.
 	Add LSI MegaRAID SAS2208.
 	Add 82GM45_KT for puc(4).
 	Add some Intel's KT (Serial over LAN) devices.
 	Add some PCI AHCI controllers, from linux.
 	Added ALTERA EP4CGX15BF14C8N entry.
 	Add Broadcom BCM57762 Gigabit Ethernet, per PR kern/46961.
 	Add ASMEDIA ASM1061.
 	Add Lava Computers SSERIAL-PCI single serial port adapter.
 	Add Intel Ivy Bridge host bridge and integrated graphics device IDs.
 	Add Intel Centrino Wireless-N 2230.
 	Pull in changes from matt-nb5-mips64 (RMI & NETLOGIC).
 	Add SB600_USB_OHCI0 again. This was (accidentally) removed in
 	rev. 1.1105.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1102.2.7 -r1.1102.2.8 src/sys/dev/pci/pcidevs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.