NetBSD Problem Report #39625

From www@NetBSD.org  Wed Sep 24 22:28:17 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 678ED63BCFE
	for <gnats-bugs@gnats.netbsd.org>; Wed, 24 Sep 2008 22:28:17 +0000 (UTC)
Message-Id: <20080924222816.EC94D63BCED@narn.NetBSD.org>
Date: Wed, 24 Sep 2008 22:28:16 +0000 (UTC)
From: Ephaeton@gmx.net
Reply-To: Ephaeton@gmx.net
To: gnats-bugs@NetBSD.org
Subject: cardbus(9) CODE REFERENCES section is wrong
X-Send-Pr-Version: www-1.0

>Number:         39625
>Category:       misc
>Synopsis:       cardbus(9) CODE REFERENCES section is wrong
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 24 22:30:00 +0000 2008
>Closed-Date:    Sun Jul 13 11:04:16 +0000 2014
>Last-Modified:  Sun Jul 13 11:05:01 +0000 2014
>Originator:     Martin S. Weber
>Release:        4.99.72/i386
>Organization:
>Environment:
NetBSD agamemnon.entropie.local 4.99.72 NetBSD 4.99.72 (AGAMEMNON) #4: Sat Sep 20 20:45:58 EDT 2008  root@agamemnon.entropie.local:/home/netbsd/obj/sys/arch/i386/compile/AGAMEMNON i386
>Description:
The "CODE REFERENCES" section of cardbus(9) is essentially copy-pasted from pcmcia(9) with an s/pcmcia/cardbus/ afterwards. That's wrong unfortunately. This part:

" The database of known devices exists within the file sys/dev/cardbus/cardbus_data.h and is generated automatically from the file sys/dev/cardbus/cardbusdevs.New vendor and product identifiers should be added to this file.  The database can be regenerated using the Makefile sys/dev/cardbus/Makefile.cardbusdevs."

references two non-existing files: sys/dev/cardbus/cardbusdevs does not exist, nor does Makefile.cardbusdevs. In fact you hook up new stuff the brutal way (found by trying to hack some new hardware in, still not yet successful :( )

>How-To-Repeat:
man 9 cardbus.
Try to actually do what CODE REFERENCES suggests.
>Fix:
Replace section CODE REFERENCES with valid data and usual procedure to add devices. As I was doing this with trial and error someone else most probably qualifies better to write a description for that.

>Release-Note:

>Audit-Trail:
From: Jukka Ruohonen <jruohonen@iki.fi>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/39625
Date: Fri, 22 May 2009 10:32:45 +0300

 I suggest the attached patch.

 If it is incorrect, in my opinion it is better to remove the whole
 discussion about known CardBus devices rather than confuse people with false
 references.


 Index: cardbus.9
 ===================================================================
 RCS file: /cvsroot/src/share/man/man9/cardbus.9,v
 retrieving revision 1.12
 diff -u -p -r1.12 cardbus.9
 --- cardbus.9	30 Apr 2008 13:10:58 -0000	1.12
 +++ cardbus.9	22 May 2009 07:23:26 -0000
 @@ -326,13 +326,9 @@ The CardBus subsystem itself is implemen
  .Pa sys/dev/cardbus/cardbus_map.c
  and
  .Pa sys/dev/cardbus/cardslot.c .
 -The database of known devices exists within the file
 -.Pa sys/dev/cardbus/cardbus_data.h
 -and is generated automatically from the file
 -.Pa sys/dev/cardbus/cardbusdevs .
 -New vendor and product identifiers should be added to this file.
 -The database can be regenerated using the Makefile
 -.Pa sys/dev/cardbus/Makefile.cardbusdevs .
 +The database for PCI devices is also used for known CardBus devices.
 +For more details see
 +.Xr pci 9 .
  .Sh SEE ALSO
  .Xr cardbus 4 ,
  .Xr pcmcia 4 ,

From: "Martin S. Weber" <Ephaeton@gmx.net>
To: gnats-bugs@NetBSD.org
Cc: misc-bug-people@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: Re: misc/39625
Date: Fri, 22 May 2009 15:45:26 -0400

 On Fri, May 22, 2009 at 07:35:02AM +0000, Jukka Ruohonen wrote:
 > The following reply was made to PR misc/39625; it has been noted by GNATS.
 > 
 > From: Jukka Ruohonen <jruohonen@iki.fi>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: misc/39625
 > Date: Fri, 22 May 2009 10:32:45 +0300
 > 
 >  I suggest the attached patch.
 >  
 >  If it is incorrect, in my opinion it is better to remove the whole
 >  discussion about known CardBus devices rather than confuse people with false
 >  references.

 I agree. It's a pity I stopped working on that cardbus'd wlan card I had (because
 I got hands on another working piece of equipment) so I don't even remember what
 I had to do to get the device attach etc.; but if all that is necessary is add
 it to the pcidevs etc., then the suggested patch is all fine!

 Regards,

 -Martin

State-Changed-From-To: open->closed
State-Changed-By: mbalmer@NetBSD.org
State-Changed-When: Sun, 13 Jul 2014 11:04:16 +0000
State-Changed-Why:
Fix suggested by Jukka Ruohonen applied.


From: "Marc Balmer" <mbalmer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39625 CVS commit: src/share/man/man9
Date: Sun, 13 Jul 2014 11:03:26 +0000

 Module Name:	src
 Committed By:	mbalmer
 Date:		Sun Jul 13 11:03:26 UTC 2014

 Modified Files:
 	src/share/man/man9: cardbus.9

 Log Message:
 Don't lie about the CardBus device database.  Diff from Jukka Ruohonen.
 Fixes PR misc/39625.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 src/share/man/man9/cardbus.9

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search