NetBSD Problem Report #39635

From root@juniata.machshav.com  Sat Sep 27 15:02:51 2008
Return-Path: <root@juniata.machshav.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 8319163BCED
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 27 Sep 2008 15:02:51 +0000 (UTC)
Message-Id: <20080927134259.0E6AB1CA341@juniata.machshav.com>
Date: Sat, 27 Sep 2008 13:42:59 +0000 (GMT)
From: smb@cs.columbia.edu
Reply-To: smb@cs.columbia.edu
To: gnats-bugs@gnats.NetBSD.org
Subject: stunnel won't compile
X-Send-Pr-Version: 3.95

>Number:         39635
>Category:       pkg
>Synopsis:       stunnel won't compile; missing libwrap
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 27 15:05:00 +0000 2008
>Closed-Date:    Wed Oct 01 14:35:06 +0000 2008
>Last-Modified:  Wed Oct 01 14:50:03 +0000 2008
>Originator:     Steven M. Bellovin
>Release:        NetBSD 4.0_STABLE
>Organization:

>Environment:


System: NetBSD juniata.machshav.com 4.0_STABLE NetBSD 4.0_STABLE (EMU-DOMU) #3: Sat May 24 18:11:32 GMT 2008 smb@juniata.machshav.com:/usr/msrc/BUILD/obj/sys/arch/i386/compile/EMU-DOMU i386
Architecture: i386
Machine: i386
>Description:
	security/stunnel won't compile because it needs -lwrap:

	libwrap.o: In function `auth_libwrap':
	libwrap.c:(.text+0x38): undefined reference to `request_init'
	libwrap.c:(.text+0x41): undefined reference to `sock_host'
	libwrap.c:(.text+0x49): undefined reference to `hosts_access'

	I've seen this on amd64-current and i386-4.0.
>How-To-Repeat:
	cd /usr/pkgsrc/security/stunnel && make
>Fix:
	There are two work-arounds.  First, use mk.conf to disable the
	libwrap option if you don't need it.  Second, the following patch
	works on NetBSD but perhaps not on other platforms; besides,
	it's a bad patch to put into pkgsrc:

	--- configure   2008-05-18 07:46:08.000000000 -0400
	+++ /tmp/configure      2008-09-26 22:44:02.000000000 -0400
	@@ -23452,6 +23452,7 @@
			 cat >>confdefs.h <<\_ACEOF
	 #define HAVE_LIBWRAP 1
	 _ACEOF
	+LIBS="-lwrap $LIBS"

			 ;;
		     no) { echo "$as_me:$LINENO: result: yes" >&5

>Release-Note:

>Audit-Trail:
From: Adrian Portelli <adrianp@stindustries.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/39635: stunnel won't compile
Date: Mon, 29 Sep 2008 15:01:09 +0100

 smb@cs.columbia.edu wrote:
 >> Number:         39635
 >> Category:       pkg
 >> Synopsis:       stunnel won't compile; missing libwrap
 >> Confidential:   no
 >> Severity:       serious
 >> Priority:       high
 >> Responsible:    pkg-manager
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Sat Sep 27 15:05:00 +0000 2008
 >> Originator:     Steven M. Bellovin
 >> Release:        NetBSD 4.0_STABLE
 >> Organization:
 > 	
 >> Environment:
 > 	
 > 	
 > System: NetBSD juniata.machshav.com 4.0_STABLE NetBSD 4.0_STABLE (EMU-DOMU) #3: Sat May 24 18:11:32 GMT 2008 smb@juniata.machshav.com:/usr/msrc/BUILD/obj/sys/arch/i386/compile/EMU-DOMU i386
 > Architecture: i386
 > Machine: i386
 >> Description:
 > 	security/stunnel won't compile because it needs -lwrap:
 > 
 > 	libwrap.o: In function `auth_libwrap':
 > 	libwrap.c:(.text+0x38): undefined reference to `request_init'
 > 	libwrap.c:(.text+0x41): undefined reference to `sock_host'
 > 	libwrap.c:(.text+0x49): undefined reference to `hosts_access'
 > 
 > 	I've seen this on amd64-current and i386-4.0.
 >> How-To-Repeat:
 > 	cd /usr/pkgsrc/security/stunnel && make
 >> Fix:
 > 	There are two work-arounds.  First, use mk.conf to disable the
 > 	libwrap option if you don't need it.  Second, the following patch
 > 	works on NetBSD but perhaps not on other platforms; besides,
 > 	it's a bad patch to put into pkgsrc:
 > 
 > 	--- configure   2008-05-18 07:46:08.000000000 -0400
 > 	+++ /tmp/configure      2008-09-26 22:44:02.000000000 -0400
 > 	@@ -23452,6 +23452,7 @@
 > 			 cat >>confdefs.h <<\_ACEOF
 > 	 #define HAVE_LIBWRAP 1
 > 	 _ACEOF
 > 	+LIBS="-lwrap $LIBS"

 This is how Gentoo fixed it as well but it would have thought that the
 tcp_wrappers/buildlink3.mk would have taken care of this.  If I bump
 stunnel to 4.26 locally it folds at the same point on OpenSolaris so I
 don't _think_ this is a NetBSD specific issue.

 adrian.

State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Wed, 01 Oct 2008 14:35:06 +0000
State-Changed-Why:
Fixed.  Thanks!


From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39635 CVS commit: pkgsrc/security/stunnel
Date: Wed,  1 Oct 2008 14:34:32 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Wed Oct  1 14:34:32 UTC 2008

 Modified Files:
 	pkgsrc/security/stunnel: Makefile options.mk

 Log Message:
 * Move inclusion of phthread.buildlink3.mk to rightful place in options.mk and
   only suggest pthread option when native pthread exists.
   We cannot use pthread.buildlink3.mk to just detect if suituable pthread
   implementation exist or not.
   Avoid unwanted dependency on pthread package when no native pthread and
   pthread option off.

 * Move inclusion of seculity/tcp_wappers/buildlink3.mk to rightful place in
   options.mk.
   Avoid unwanted dependency on tcp_wrappers when libwrap option off.

 * Remove deprecated(?) --with-tcp-wrappers from CONFIGURE_ARGS.

 * Remove --enable-libwrap from CONFIGURE_ARGS even if require tcp_wrappers.
   It affect not only check of existence of tcp_wappers but also blow off
   needful addition of -lwrap to LIBS.
   Fixes PR 39635


 To generate a diff of this commit:
 cvs rdiff -r1.63 -r1.64 pkgsrc/security/stunnel/Makefile
 cvs rdiff -r1.4 -r1.5 pkgsrc/security/stunnel/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search