NetBSD Problem Report #39766

From riastradh@slate.localdomain  Sun Oct 19 03:43:46 2008
Return-Path: <riastradh@slate.localdomain>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id AC3C763B93C
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 19 Oct 2008 03:43:46 +0000 (UTC)
Message-Id: <20081019024443.1576B76CBE@slate.localdomain>
Date: Sun, 19 Oct 2008 02:44:42 +0000 (UTC)
From: Taylor R Campbell <campbell@mumble.net>
Reply-To: Taylor R Campbell <campbell@mumble.net>
To: gnats-bugs@gnats.NetBSD.org
Subject: security/mhash installs <mhash.h> that cooperates badly with autoconf
X-Send-Pr-Version: 3.95

>Number:         39766
>Category:       pkg
>Synopsis:       security/mhash installs <mhash.h> that cooperates badly with autoconf
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 19 03:45:00 +0000 2008
>Closed-Date:    Thu Mar 05 13:36:46 +0000 2015
>Last-Modified:  Thu Mar 05 13:36:46 +0000 2015
>Originator:     Taylor R Campbell <campbell@mumble.net>
>Release:        NetBSD 4.0_STABLE
>Organization:
>Environment:
System: NetBSD slate.localdomain 4.0_STABLE NetBSD 4.0_STABLE (RIABWI) #11: Mon Sep 22 15:53:59 UTC 2008 riastradh@slate.localdomain:/home/riastradh/netbsd/4/obj/sys/arch/macppc/compile/RIABWI macppc
Architecture: powerpc
Machine: macppc
>Description:

	The package security/mhash installs a file in
	/usr/pkg/include/mhash.h that has the effect of including
	mhash's config.h generated by autoconf, which is intended for
	use internal to the program of which config.h is a part.  Any
	other program that uses autoconf will have trouble reconciling
	mhash's config.h with its own config.h, since they define many
	macros in common, such as PACKAGE_NAME and PACKAGE_VERSION.

>How-To-Repeat:

	Install security/mhash and try to build a C program that uses
	autoconf and includes <mhash.h>.

>Fix:

	Patch /usr/pkg/include/mhash.h to strike out the line

		#define MUTILS_USE_MHASH_CONFIG

	which has no useful effects of which I am aware for programs
	outside of mhash.  It may be possible to patch the source file
	mhash-0.9.9/include/mhash.h -- other C source files in mhash
	already define MUTILS_USE_MHASH_CONFIG before including it.

	This should probably also be reported upstream, but mhash looks
	awfully defunct upstream.  <http://mhash.sf.net/> is rather
	outdated, and the version one finds in CVS is older than the
	version one finds in the distribution tarballs.

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: obache@NetBSD.org
State-Changed-When: Sat, 27 Dec 2008 11:20:21 +0000
State-Changed-Why:
Common macros were moved from mhas_config.h to config.h (it is not installed).
Do you still want to remove MUTILS_USE_MHASH_CONFIG definition from mhash.h?


Responsible-Changed-From-To: pkg-manager->bjs
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Sat, 27 Dec 2008 11:49:54 +0000
Responsible-Changed-Why:
bjs@ commited the fix.
I have one question, why patch-aa rev1.1 was removed VERSION from mhash_config.h
but rev1.2 is not and added to config.h.  Why VERSION in both?


From: Taylor R Campbell <campbell@mumble.net>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org,
	gnats-admin@netbsd.org, obache@NetBSD.org
Subject: Re: pkg/39766 (security/mhash installs <mhash.h> that cooperates badly with autoconf)
Date: Sat, 27 Dec 2008 14:23:33 -0500

    Date: Sat, 27 Dec 2008 11:20:22 +0000 (UTC)
    From: obache@NetBSD.org

    Common macros were moved from mhas_config.h to config.h (it is not insta=
 lled).
    Do you still want to remove MUTILS_USE_MHASH_CONFIG definition from mhas=
 h.h?

 Urgh.  I was mistaken in my original report -- the header files really
 do use the information derived from autoconf.  Bletch.

 I wonder how other autoconf'd software deals with this.  Very little
 actually installs config.h files into the system include directories.

State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 15 Nov 2009 01:05:41 +0000
State-Changed-Why:
feedback was received in december.


Responsible-Changed-From-To: bjs->pkg-manager
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Mon, 28 Feb 2011 15:05:06 +0000
Responsible-Changed-Why:
Reset responsible field for retired developer.


State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 29 Dec 2014 07:44:37 +0000
State-Changed-Why:
This looks fixed to me -- what do you think?


State-Changed-From-To: feedback->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Thu, 05 Mar 2015 13:36:46 +0000
State-Changed-Why:
good enough
(I am submitter)


>Unformatted:

Home	PR Database Search