NetBSD Problem Report #39851

From spz@volans.1st.de  Sun Nov  2 13:04:15 2008
Return-Path: <spz@volans.1st.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 0143563B88A
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  2 Nov 2008 13:04:14 +0000 (UTC)
Message-Id: <20081102130350.B154A578E@volans.1st.de>
Date: Sun,  2 Nov 2008 14:03:50 +0100 (CET)
From: spz@volans.1st.de
Reply-To: spz@volans.1st.de
To: gnats-bugs@gnats.NetBSD.org
Subject: native xorgs xdm doesn't use PAM
X-Send-Pr-Version: 3.95

>Number:         39851
>Category:       xsrc
>Synopsis:       native xorgs xdm doesn't use PAM
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    xsrc-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 02 13:05:01 +0000 2008
>Closed-Date:    Fri Jan 02 23:33:18 +0000 2009
>Last-Modified:  Fri Jan 09 02:55:00 +0000 2009
>Originator:     S.P.Zeidler
>Release:        NetBSD 5.0_BETA (20081101)
>Organization:
	dis-
>Environment:
System: NetBSD volans 5.0_BETA NetBSD 5.0_BETA (VOLANS) #7: Sun Nov 2 12:47:45 CET 2008 spz@volans:/home/netbsd/i386/obj/home/netbsd/src/sys/arch/i386/compile/VOLANS i386
Architecture: i386
Machine: i386
>Description:
	native xorgs xdm isn't compiled to use PAM
>How-To-Repeat:
	build & install native xorg, use xdm
>Fix:

Index: external/mit/xorg/bin/xdm/Makefile
===================================================================
RCS file: /cvsroot/src/external/mit/xorg/bin/xdm/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- external/mit/xorg/bin/xdm/Makefile	14 Oct 2008 23:37:19 -0000	1.3
+++ external/mit/xorg/bin/xdm/Makefile	2 Nov 2008 12:54:06 -0000
@@ -31,6 +31,11 @@
 DPADD+=		${LIBXAU} ${LIBXDMCP} ${LIBXINERAMA} ${LIBXPM} ${LIBXMU}
 DPADD+=		${LIBXT} ${LIBSM} ${LIBICE} ${LIBXEXT} ${LIBX11} ${LIBCRYPT}

+.if (${USE_PAM} != "no")
+LDADD+= -lpam ${PAM_STATIC_LDADD}
+DPADD+= ${LIBPAM} ${PAM_STATIC_DPADD}
+.endif
+
 SUBDIR=		chooser config
 TARGETS+=	configinstall

Index: external/mit/xorg/bin/xdm/Makefile.xdm
===================================================================
RCS file: /cvsroot/src/external/mit/xorg/bin/xdm/Makefile.xdm,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile.xdm
--- external/mit/xorg/bin/xdm/Makefile.xdm	29 Jul 2008 05:01:22 -0000	1.1.1.1
+++ external/mit/xorg/bin/xdm/Makefile.xdm	2 Nov 2008 12:54:06 -0000
@@ -15,4 +15,8 @@
 		-I${X11SRCDIR.xdm} \
 		${X11FLAGS.VERSION}

+.if (${USE_PAM} != "no")
+CPPFLAGS+=      -DUSE_PAM
+.endif
+
 .PATH:		${X11SRCDIR.xdm}

Index: external/mit/xdm/dist/greeter/greet.c
===================================================================
RCS file: /cvsroot/xsrc/external/mit/xdm/dist/greeter/greet.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 greet.c
--- external/mit/xdm/dist/greeter/greet.c	30 Jul 2008 04:15:19 -0000	1.1.1.1
+++ external/mit/xdm/dist/greeter/greet.c	2 Nov 2008 12:55:33 -0000
@@ -694,8 +694,8 @@
     if (*response == NULL)
 	return (PAM_BUF_ERR);

-    m = *msg;
-    r = *response;
+    m = (struct pam_message *) *msg;
+    r = (struct pam_response *) *response;

     for (i = 0; i < num_msg; i++ , m++ , r++) {
 	char *username;

>Release-Note:

>Audit-Trail:
From: "S.P.Zeidler" <spz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39851 CVS commit: src/external/mit/xorg/bin/xdm
Date: Fri,  2 Jan 2009 23:25:57 +0000 (UTC)

 Module Name:	src
 Committed By:	spz
 Date:		Fri Jan  2 23:25:57 UTC 2009

 Modified Files:
 	src/external/mit/xorg/bin/xdm: Makefile Makefile.xdm

 Log Message:
 make xdm (able to) use PAM
 fixes PR 39851


 To generate a diff of this commit:
 cvs rdiff -r1.3 -r1.4 src/external/mit/xorg/bin/xdm/Makefile
 cvs rdiff -r1.1.1.1 -r1.2 src/external/mit/xorg/bin/xdm/Makefile.xdm

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: spz@NetBSD.org
State-Changed-When: Fri, 02 Jan 2009 23:33:18 +0000
State-Changed-Why:
xdm now may use PAM


From: Soren Jacobsen <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39851 CVS commit: [netbsd-5] src/external/mit/xorg/bin/xdm
Date: Fri,  9 Jan 2009 02:51:40 +0000 (UTC)

 Module Name:	src
 Committed By:	snj
 Date:		Fri Jan  9 02:51:40 UTC 2009

 Modified Files:
 	src/external/mit/xorg/bin/xdm [netbsd-5]: Makefile Makefile.xdm

 Log Message:
 Pull up following revision(s) (requested by spz in ticket #238):
 	external/mit/xorg/bin/xdm/Makefile: revision 1.4
 	external/mit/xorg/bin/xdm/Makefile.xdm: revision 1.2
 make xdm (able to) use PAM
 fixes PR 39851


 To generate a diff of this commit:
 cvs rdiff -r1.3 -r1.3.4.1 src/external/mit/xorg/bin/xdm/Makefile
 cvs rdiff -r1.1.1.1 -r1.1.1.1.8.1 src/external/mit/xorg/bin/xdm/Makefile.xdm

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search