NetBSD Problem Report #39873

From kilbi@kilbi.de  Fri Nov  7 02:37:06 2008
Return-Path: <kilbi@kilbi.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 73A8363BADB
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  7 Nov 2008 02:37:06 +0000 (UTC)
Message-Id: <20081107023624.A16D1FA68@mail.kilbi.de>
Date: Fri,  7 Nov 2008 03:36:24 +0100 (MET)
From: mk@kilbi.de
Reply-To: mk@kilbi.de
To: gnats-bugs@gnats.NetBSD.org
Subject: cvs rdiff -r1.69 -r1.70 src/bin/sh/parser.c break case's ')' delim
X-Send-Pr-Version: 3.95

>Number:         39873
>Category:       bin
>Synopsis:       /bin/sh occasionally misinterpret case's ')' delim as unexpected
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 07 02:40:00 +0000 2008
>Closed-Date:    Fri Nov 07 15:09:16 +0000 2008
>Last-Modified:  Fri Nov 07 15:10:10 +0000 2008
>Originator:     Markus W. Kilbinger
>Release:        NetBSD 5.99.01
>Organization:

>Environment:


System: NetBSD 5.99.01 NetBSD 5.99.01 (Q) #12: Thu Nov 6 23:57:32 MET 2008 root@q:/u/NetBSD/src/sys/arch/amd64/compile/Q amd64
Architecture: x86_64
Machine: amd64
>Description:
	Above mentioned change to sh's parser.c may lead to
	misinterpretation of case's ')' delimiter. I've found that
	while seeing 'build.sh ... distribution' failing with
	following complex sh command (one line!) out of make:

if test "make" = "gettext"; then  /bin/sh `case "/usr/u/NetBSD/src/tools/gmake/../../gnu/dist/gmake/config/mkinstalldirs" in /*) echo "/usr/u/NetBSD/src/tools/gmake/../../gnu/dist/gmake/config/mkinstalldirs" ;; *) echo "..//usr/u/NetBSD/src/tools/gmake/../../gnu/dist/gmake/config/mkinstalldirs" ;; esac` /usr/u/NetBSD/tools-i386-ustix/share/gettext/po;  for file in Makefile.in.in Makevars remove-potcdate.sin  quot.sed boldquot.sed en@quot.header en@boldquot.header insert-header.sin Rules-quot  ; do  /usr/u/NetBSD/tools-i386-ustix/bin/i386--netbsdelf-install -c -p -r -m 644 /usr/u/NetBSD/src/tools/gmake/../../gnu/dist/gmake/po/$file  /usr/u/NetBSD/tools-i386-ustix/share/gettext/po/$file;  done;  else  : ;  fi

>How-To-Repeat:
	Run the above sh command with /bin/sh containing parser.c
	v1.70.
>Fix:
	Unknown.
	WR: Revert parser.c to v1.69

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: christos@NetBSD.org
State-Changed-When: Fri, 07 Nov 2008 10:09:16 -0500
State-Changed-Why:
fixed, thanks


From: Christos Zoulas <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/39873 CVS commit: src/bin/sh
Date: Fri,  7 Nov 2008 15:08:43 +0000 (UTC)

 Module Name:	src
 Committed By:	christos
 Date:		Fri Nov  7 15:08:43 UTC 2008

 Modified Files:
 	src/bin/sh: parser.c

 Log Message:
 Break PR/11317 again. The counting parentheses fix does not handle case
 statements properly. Fixes PR/39873.


 To generate a diff of this commit:
 cvs rdiff -r1.70 -r1.71 src/bin/sh/parser.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search