NetBSD Problem Report #39902

From www@NetBSD.org  Wed Nov 12 13:19:54 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id B08C563B8A9
	for <gnats-bugs@gnats.netbsd.org>; Wed, 12 Nov 2008 13:19:54 +0000 (UTC)
Message-Id: <20081112131954.6DCE663B898@narn.NetBSD.org>
Date: Wed, 12 Nov 2008 13:19:54 +0000 (UTC)
From: sd4dfg2@hotmail.com
Reply-To: sd4dfg2@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: openssh package can't create sshd userid - missing full path name for shell
X-Send-Pr-Version: www-1.0

>Number:         39902
>Category:       pkg
>Synopsis:       openssh package can't create sshd userid - missing full path name for shell
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    solaris-pkg-people
>State:          analyzed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 12 13:20:01 +0000 2008
>Closed-Date:    
>Last-Modified:  Fri Nov 14 13:54:45 +0000 2008
>Originator:     Rob Quinn
>Release:        Solaris 10 with pkgsrc current
>Organization:
>Environment:
>Description:
openssh-5.1.1: Creating user ``sshd''
UX: /usr/sbin/useradd: ERROR: false is not a full path name.  Choose another.
>How-To-Repeat:
#bmake package
=> Bootstrap dependency digest>=20010302: found digest-20080510
=> Bootstrap dependency tnftp-[0-9]*: found tnftp-20070806
===> Installing for openssh-5.1.1
=> Running PRE-INSTALL script actions
openssh-5.1.1: Creating user ``sshd''
UX: /usr/sbin/useradd: ERROR: false is not a full path name.  Choose another.
===========================================================================
The following users need to be created for openssh-5.1.1:

        sshd: sshd, /var/chroot/sshd, false

===========================================================================
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/security/openssh
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/security/openssh
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/security/openssh

>Fix:

>Release-Note:

>Audit-Trail:
From: OBATA Akio <obache@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: ahoka@NetBSD.org,
 adrianp@NetBSD.org
Subject: Re: pkg/39902: openssh package can't create sshd userid - missing full path name for shell
Date: Thu, 13 Nov 2008 06:24:27 +0900

 This problem is appeard after ${TOOLS_PLATFORM.false} is replaced  
 with shell builtin.
 in mk/tools/tools.SunOS.mk rev1.29.
 For OpenSolaris, replaced with GNU false in rev1.30 to avoid this issue.

 How about replace following line in mk/platform/SunOS.mk?
 (and tools.SunOS.mk back to rev1.29)?

 < NOLOGIN?=	${FALSE}
  > NOLOGIN?=	/usr/bin/false

 -- 
 "Of course I love NetBSD":-)
 OBATA Akio / obache@NetBSD.org





From: Adrian Portelli <adrianp@stindustries.net>
To: OBATA Akio <obache@NetBSD.org>
Cc: gnats-bugs@NetBSD.org, ahoka@NetBSD.org
Subject: Re: pkg/39902: openssh package can't create sshd userid - missing
 full path name for shell
Date: Wed, 12 Nov 2008 21:39:20 +0000

 OBATA Akio wrote:
 > This problem is appeard after ${TOOLS_PLATFORM.false} is replaced with
 > shell builtin.
 > in mk/tools/tools.SunOS.mk rev1.29.
 > For OpenSolaris, replaced with GNU false in rev1.30 to avoid this issue.
 > 
 > How about replace following line in mk/platform/SunOS.mk?
 > (and tools.SunOS.mk back to rev1.29)?
 > 
 > < NOLOGIN?=    ${FALSE}
 >> NOLOGIN?=    /usr/bin/false
 > 

 Sure, sounds logical to me.  On OpenSolairs it happened to be in
 /usr/gnu/bin/false, searching a little harder now it's also in
 /usr/bin/.  I'd suggest the following change:

 Index: mk/tools/tools.SunOS.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mk/tools/tools.SunOS.mk,v
 retrieving revision 1.30
 diff -u -r1.30 tools.SunOS.mk
 --- mk/tools/tools.SunOS.mk	11 Sep 2008 23:00:31 -0000	1.30
 +++ mk/tools/tools.SunOS.mk	12 Nov 2008 21:36:53 -0000
 @@ -44,11 +44,7 @@
  TOOLS_PLATFORM.egrep?=		/usr/xpg4/bin/grep -E
  TOOLS_PLATFORM.env?=		/usr/bin/env
  TOOLS_PLATFORM.expr?=		/usr/xpg4/bin/expr
 -.if exists(/usr/gnu/bin/false)	# if we are using OpenSolaris
 -TOOLS_PLATFORM.false?=		/usr/gnu/bin/false
 -.else
 -TOOLS_PLATFORM.false?=		false			# shell builtin
 -.endif
 +TOOLS_PLATFORM.false?=		/usr/bin/false
  TOOLS_PLATFORM.fgrep?=		/usr/xpg4/bin/fgrep
  TOOLS_PLATFORM.file?=		/usr/bin/file
  TOOLS_PLATFORM.find?=		/usr/bin/find

 Would mk/platform/SunOS.mk then pick up ${FALSE} correctly ?

 adrian.

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/39902: openssh package can't create sshd userid - missing
	full path name for shell
Date: Wed, 12 Nov 2008 23:37:32 +0100

 On Wed, Nov 12, 2008 at 09:40:05PM +0000, Adrian Portelli wrote:
 >  Sure, sounds logical to me.  On OpenSolairs it happened to be in
 >  /usr/gnu/bin/false, searching a little harder now it's also in
 >  /usr/bin/.  I'd suggest the following change:

 I disagree. If it can be a shell builtin, please leave it as such and
 only change NOLOGIN.

 Joerg

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/39902: openssh package can't create sshd userid - missing
 full path name for shell
Date: Thu, 13 Nov 2008 09:07:47 +0900

 On Thu, 13 Nov 2008 07:45:03 +0900, Joerg Sonnenberger <joerg@britannica.bec.de> wrote:

 >  I disagree. If it can be a shell builtin, please leave it as such and
 >  only change NOLOGIN.

 Probably also for IRIX.mk, and maybe UnixWare.mk.

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Fri, 14 Nov 2008 13:54:45 +0000
Responsible-Changed-Why:
Problem on Solaris.


State-Changed-From-To: open->analyzed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Fri, 14 Nov 2008 13:54:45 +0000
State-Changed-Why:
NOLOGIN point to /usr/bin/false directly, or FALSE not to shell builtin.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.