NetBSD Problem Report #39953
From heas@shrubbery.net Tue Nov 18 20:32:21 2008
Return-Path: <heas@shrubbery.net>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by narn.NetBSD.org (Postfix) with ESMTP id F16E463B874
for <gnats-bugs@gnats.NetBSD.org>; Tue, 18 Nov 2008 20:32:20 +0000 (UTC)
Message-Id: <20081118203219.BE16A108690@guelah.shrubbery.net>
Date: Tue, 18 Nov 2008 20:32:19 +0000 (UTC)
From: heas@shrubbery.net
Reply-To: heas@shrubbery.net
To: gnats-bugs@gnats.NetBSD.org
Subject: skey patch-ac is broken
X-Send-Pr-Version: 3.95
>Number: 39953
>Category: pkg
>Synopsis: skey patch-ac is broken
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Nov 18 20:35:00 +0000 2008
>Closed-Date: Sat Dec 13 14:02:25 +0000 2008
>Last-Modified: Sat Dec 13 14:02:25 +0000 2008
>Originator: john heasley
>Release: NetBSD 4.99.68
>Organization:
>Environment:
System: NetBSD guelah 4.99.68 NetBSD 4.99.68 (guelah) #1: Tue Jul 1 18:16:59 UTC 2008 root@guelah:/sys/arch/sparc64/compile/guelah sparc64
Architecture: sparc64
Machine: sparc64
>Description:
security/skey patch-ac is broken or half-baked. It appears this was added
for IRIX, but it uses a '-' in a cpp macro name, which does not work.
Also, the private RMD160File() has a different signature than NetBSD'
rmd160.h.
>How-To-Repeat:
>Fix:
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/skey/distinfo,v
retrieving revision 1.6
diff -u -d -u -r1.6 distinfo
--- distinfo 9 Jul 2006 13:39:06 -0000 1.6
+++ distinfo 18 Nov 2008 20:31:38 -0000
@@ -5,4 +5,5 @@
Size (skey-1.1.5.tar.bz2) = 61911 bytes
SHA1 (patch-aa) = c9c0cde8f648fae44bbfbffcb7da0d331fad537d
SHA1 (patch-ab) = 69d8f92968b3ebffc9b05fe7af1cde7e9d116587
-SHA1 (patch-ac) = 7f0b69315ccec66c4c59da142bd919b46d4c8409
+SHA1 (patch-ac) = f3e9a6ebb7ac22116c8d8e6fe8ca0db7f8d37051
+SHA1 (patch-ad) = 550fa498340b1b092c360d2a360aa3b004c88684
Index: hacks.mk
===================================================================
RCS file: /cvsroot/pkgsrc/security/skey/hacks.mk,v
retrieving revision 1.3
diff -u -d -u -r1.3 hacks.mk
--- hacks.mk 11 Mar 2008 18:47:41 -0000 1.3
+++ hacks.mk 18 Nov 2008 20:31:38 -0000
@@ -32,7 +32,7 @@
###
.if !empty(MACHINE_PLATFORM:MIRIX-5*)
PKG_HACKS+= missing-u_int64_t
-CPPFLAGS+= -DMISSING-U_INT64_T
+CPPFLAGS+= -DMISSING_U_INT64_T
.endif
.endif
cvs diff: Diffing patches
Index: patches/patch-ac
===================================================================
RCS file: /cvsroot/pkgsrc/security/skey/patches/patch-ac,v
retrieving revision 1.1
diff -u -d -u -r1.1 patch-ac
--- patches/patch-ac 9 Jul 2006 13:39:06 -0000 1.1
+++ patches/patch-ac 18 Nov 2008 20:31:38 -0000
@@ -6,7 +6,7 @@
# endif
#endif
-+#ifdef MISSING-U_INT64_T
++#ifdef MISSING_U_INT64_T
+typedef unsigned long long int u_int64_t;
+#endif
+
patches/patch-ad:
$NetBSD$
--- rmd160.h.orig 2001-05-10 16:10:49.000000000 +0000
+++ rmd160.h
@@ -40,7 +40,7 @@ void RMD160Transform __P((u_int32_t stat
void RMD160Update __P((RMD160_CTX *context, const u_char *data, u_int32_t nbyte
s));
void RMD160Final __P((u_char digest[20], RMD160_CTX *context));
char *RMD160End __P((RMD160_CTX *, char *));
-char *RMD160File __P((char *, char *));
+char *RMD160File __P((const char *, char *));
char *RMD160Data __P((const u_char *, size_t, char *));
#endif /* _RMD160_H */
--- rmd160hl.c.orig 2001-05-10 16:10:49.000000000 +0000
+++ rmd160hl.c
@@ -50,7 +50,7 @@ RMD160End(ctx, buf)
char *
RMD160File (filename, buf)
- char *filename;
+ const char *filename;
char *buf;
{
u_char buffer[BUFSIZ];
>Release-Note:
>Audit-Trail:
From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/39953 CVS commit: pkgsrc/security/skey
Date: Sat, 13 Dec 2008 12:07:54 +0000 (UTC)
Module Name: pkgsrc
Committed By: obache
Date: Sat Dec 13 12:07:54 UTC 2008
Modified Files:
pkgsrc/security/skey: distinfo hacks.mk
pkgsrc/security/skey/patches: patch-ac
Log Message:
macro name must not contains '-', a part of PR 39953.
To generate a diff of this commit:
cvs rdiff -r1.6 -r1.7 pkgsrc/security/skey/distinfo
cvs rdiff -r1.3 -r1.4 pkgsrc/security/skey/hacks.mk
cvs rdiff -r1.1 -r1.2 pkgsrc/security/skey/patches/patch-ac
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/39953 CVS commit: pkgsrc/security/skey
Date: Sat, 13 Dec 2008 13:58:31 +0000 (UTC)
Module Name: pkgsrc
Committed By: obache
Date: Sat Dec 13 13:58:31 UTC 2008
Modified Files:
pkgsrc/security/skey: Makefile PLIST distinfo
pkgsrc/security/skey/patches: patch-aa
Added Files:
pkgsrc/security/skey/patches: patch-ad patch-ae patch-af patch-ag
patch-ah patch-ai
Log Message:
* Fixes mismatch between the section and extension of skeyprune.
* skeyprune is perl script, need runtime dependency on perl5.
* Fixes mis-use of config.h (patch-a[d-i]), avoid to use a mixture of
local hash function with system RMD header.
Fixes build failure reported by PR 39872 and PR 39953.
Bump PKGREVISION.
To generate a diff of this commit:
cvs rdiff -r1.21 -r1.22 pkgsrc/security/skey/Makefile
cvs rdiff -r1.2 -r1.3 pkgsrc/security/skey/PLIST
cvs rdiff -r1.8 -r1.9 pkgsrc/security/skey/distinfo
cvs rdiff -r1.4 -r1.5 pkgsrc/security/skey/patches/patch-aa
cvs rdiff -r0 -r1.1 pkgsrc/security/skey/patches/patch-ad \
pkgsrc/security/skey/patches/patch-ae \
pkgsrc/security/skey/patches/patch-af \
pkgsrc/security/skey/patches/patch-ag \
pkgsrc/security/skey/patches/patch-ah \
pkgsrc/security/skey/patches/patch-ai
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Sat, 13 Dec 2008 14:02:25 +0000
State-Changed-Why:
First part patch was commited.
Second part was fixed with another way.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.