NetBSD Problem Report #39974

From www@NetBSD.org  Thu Nov 20 10:56:35 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 5516F63B8BD
	for <gnats-bugs@gnats.netbsd.org>; Thu, 20 Nov 2008 10:56:35 +0000 (UTC)
Message-Id: <20081120105635.263FA63B874@narn.NetBSD.org>
Date: Thu, 20 Nov 2008 10:56:35 +0000 (UTC)
From: xtraeme@gmail.com
Reply-To: xtraeme@gmail.com
To: gnats-bugs@NetBSD.org
Subject: modules/ffs: can't mount log filesystems if vfs_wapbl.c not built in kernel
X-Send-Pr-Version: www-1.0

>Number:         39974
>Category:       kern
>Synopsis:       modules/ffs: can't mount log filesystems if vfs_wapbl.c not built in kernel
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 20 11:00:00 +0000 2008
>Closed-Date:    Tue May 31 03:32:36 +0000 2016
>Last-Modified:  Tue May 31 03:32:36 +0000 2016
>Originator:     Juan RP
>Release:        Latest
>Organization:
>Environment:
NetBSD vmware-netbsd 5.99.3 NetBSD 5.99.3 (MASTER) #10: Thu Nov 20 11:40:06 CET 2008  juan@vmware-netbsd:/home/juan/build/obj/sys/arch/i386/compile/MASTER i386
>Description:
If a kernel is built without WAPBL (no options WAPBL) and the x86
bootloader autoloads the ffs module, it won't be able to mount a fs
with log option. That's because vfs_wapbl.c is not built in the
ffs module or in another dependent module.



>How-To-Repeat:

>Fix:
There are two ways to fix this:

1) Build the ffs module with vfs_wapbl.c.
2) Build another wapbl module and make ffs depend on it.

As quick fix I used the first option:

Index: Makefile
===================================================================
RCS file: /cvsroot/src/sys/modules/ffs/Makefile,v
retrieving revision 1.2
diff -b -u -p -r1.2 Makefile
--- Makefile    13 Nov 2008 10:50:26 -0000      1.2
+++ Makefile    20 Nov 2008 10:50:41 -0000
@@ -16,4 +16,7 @@ SRCS+=        ffs_alloc.c ffs_balloc.c ffs_inod
        ffs_vfsops.c ffs_vnops.c ffs_softdep.stub.c ffs_snapshot.c \
        ffs_bswap.c ffs_wapbl.c ffs_appleufs.c

+.PATH: ${S}/kern
+SRCS+= vfs_wapbl.c
+
 .include <bsd.kmodule.mk>

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Tue, 31 May 2016 03:32:36 +0000
Responsible-Changed-Why:
I took care of it.


State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Tue, 31 May 2016 03:32:36 +0000
State-Changed-Why:
The PR is no longer valid, as we have previously created a new wapbl
module, and the ffs module now depends on wapbl.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.