NetBSD Problem Report #40039

From kre@munnari.OZ.AU  Wed Nov 26 19:08:05 2008
Return-Path: <kre@munnari.OZ.AU>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 675E863B8BD
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 26 Nov 2008 19:08:05 +0000 (UTC)
Message-Id: <200811261906.mAQJ6Vkv002529@jade.coe.psu.ac.th>
Date: Thu, 27 Nov 2008 02:06:31 +0700 (ICT)
From: kre@munnari.OZ.AU
To: gnats-bugs@gnats.NetBSD.org
Subject: sysutils/hal compilation errors (NetBSD 4.0)
X-Send-Pr-Version: 3.95

>Number:         40039
>Category:       pkg
>Synopsis:       sysutils/hal compilation errors (NetBSD 4.0)
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    jmcneill
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 26 19:10:00 +0000 2008
>Closed-Date:    Wed Dec 24 11:40:12 +0000 2008
>Last-Modified:  Wed Dec 24 11:40:12 +0000 2008
>Originator:     Robert Elz
>Release:        NetBSD 4.0_STABLE (pkgsrc current within past 12 hours)
>Organization:
	Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE (JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 kre@jade.coe.psu.ac.th:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
	sysutils/hal no longer compiles on NetBSD 4.0 (maybe other systems)
	This PR is marked critical/high because hal bas become a fairly
	fundamental dependency of many gnome packages - they're all
	failing to build now (withou reverting to an older hal anyway).

	All this for a package that's only existed a week or so ...

>How-To-Repeat:
	I use pkg_comp with libkver and NetBSD 4.0 release sets installed
	(except the x* sets, I have X11_TYPE=modular in the mk.conf)

	Building (attempting to build) sysutils/hal results in ...

/bin/sh ../../libtool --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I../..  -DPACKAGE_SYSCONF_DIR=\""/usr/pkg/etc"\" -DPACKAGE_DATA_DIR=\""/usr/pkg/share"\" -DPACKAGE_BIN_DIR=\""/usr/pkg/bin"\" -DPACKAGE_LOCALE_DIR=\""/usr/pkg/share/locale"\" -DPACKAGE_LOCALSTATEDIR=\""/var"\" -I../.. -I.. -I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/dbus-1.0 -I/usr/pkg/lib/dbus-1.0/include   -I/usr/pkg/include/dbus-1.0 -I/usr/pkg/lib/dbus-1.0/include   -I/usr/pkg/include/PolicyKit   -I/usr/pkg/include -I/usr/include  -O2 -I/usr/pkg/include -I/usr/include -Wall -Wchar-subscripts -Wmissing-declarations -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -MT drvctl.lo -MD -MP -MF .deps/drvctl.Tpo -c -o drvctl.lo drvctl.c
 cc -DHAVE_CONFIG_H -I. -I../.. -DPACKAGE_SYSCONF_DIR=\"/usr/pkg/etc\" -DPACKAGE_DATA_DIR=\"/usr/pkg/share\" -DPACKAGE_BIN_DIR=\"/usr/pkg/bin\" -DPACKAGE_LOCALE_DIR=\"/usr/pkg/share/locale\" -DPACKAGE_LOCALSTATEDIR=\"/var\" -I.. -I/pkg_comp/obj/pkgsrc/sysutils/hal/4x/.buildlink/include/glib/glib-2.0 -I/pkg_comp/obj/pkgsrc/sysutils/hal/4x/.buildlink/lib/glib-2.0/include -I/pkg_comp/obj/pkgsrc/sysutils/hal/4x/.buildlink/include/dbus-1.0 -I/pkg_comp/obj/pkgsrc/sysutils/hal/4x/.buildlink/lib/dbus-1.0/include -I/pkg_comp/obj/pkgsrc/sysutils/hal/4x/.buildlink/include/PolicyKit -I/pkg_comp/obj/pkgsrc/sysutils/hal/4x/.buildlink/include -O2 -Wall -Wchar-subscripts -Wmissing-declarations -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -MT drvctl.lo -MD -MP -MF .deps/drvctl.Tpo -c drvctl.c  -fPIC -DPIC -o .libs/drvctl.o
In file included from drvctl.c:39:
drvctl.h:20: warning: 'struct devlistargs' declared inside parameter list
drvctl.h:20: warning: its scope is only this definition or declaration, which is probably not what you want
drvctl.c: In function 'drvctl_iochannel_data':
drvctl.c:85: error: 'DRVGETEVENT' undeclared (first use in this function)
drvctl.c:85: error: (Each undeclared identifier is reported only once
drvctl.c:85: error: for each function it appears in.)
drvctl.c:104: warning: passing argument 1 of 'drvctl_dev_add' discards qualifiers from pointer target type
drvctl.c:106: warning: passing argument 1 of 'drvctl_dev_remove' discards qualifiers from pointer target type
drvctl.c: At top level:
drvctl.c:156: warning: 'struct devlistargs' declared inside parameter list
drvctl.c:157: error: conflicting types for 'drvctl_list'
drvctl.h:20: error: previous declaration of 'drvctl_list' was here
drvctl.c: In function 'drvctl_list':
drvctl.c:162: error: dereferencing pointer to incomplete type
drvctl.c:163: error: dereferencing pointer to incomplete type
drvctl.c:163: error: dereferencing pointer to incomplete type
drvctl.c:164: error: 'DRVLISTDEV' undeclared (first use in this function)
drvctl.c:168: error: dereferencing pointer to incomplete type
drvctl.c:172: error: dereferencing pointer to incomplete type
drvctl.c:172: error: dereferencing pointer to incomplete type
drvctl.c:173: error: dereferencing pointer to incomplete type
drvctl.c:181: error: dereferencing pointer to incomplete type
drvctl.c:182: error: dereferencing pointer to incomplete type
drvctl.c: In function 'drvctl_find_device_with_child':
drvctl.c:189: error: storage size of 'laa' isn't known
drvctl.c:189: warning: unused variable 'laa'
gmake[5]: *** [drvctl.lo] Error 1
gmake[5]: Leaving directory `/pkg_comp/obj/pkgsrc/sysutils/hal/4x/hal-0.5.11/hald/netbsd'
gmake[4]: *** [all-recursive] Error 1
gmake[4]: Leaving directory `/pkg_comp/obj/pkgsrc/sysutils/hal/4x/hal-0.5.11/hald/netbsd'
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory `/pkg_comp/obj/pkgsrc/sysutils/hal/4x/hal-0.5.11/hald'
gmake[2]: *** [all] Error 2
gmake[2]: Leaving directory `/pkg_comp/obj/pkgsrc/sysutils/hal/4x/hal-0.5.11/hald'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/pkg_comp/obj/pkgsrc/sysutils/hal/4x/hal-0.5.11'
gmake: *** [all] Error 2
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/sysutils/hal
*** Error code 1

Stop.

>Fix:
	???

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->jmcneill
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Sat, 29 Nov 2008 09:12:49 +0000
Responsible-Changed-Why:
Over to "the hal guy"


From: Robert Elz <kre@munnari.OZ.AU>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/40039 (sysutils/hal compilation errors (NetBSD 4.0)) 
Date: Sat, 29 Nov 2008 18:52:35 +0700

 Just so there is a record in he PR ... the compilation errors
 for NetBSD 4 (and earlier) are fixed now (very soon after the PR)
 but the Makefile now needs

 	LIST_SRC=	PLIST

 in the "old NetBSD" section (in the section added in Makefile 1.8
 where this PR was fixed).

 Without that, PLIST.NetBSD gets included, and that is only appropriate
 for newer versions of NetBSD

 kre


From: "Jared D. McNeill" <jmcneill@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org, kre@munnari.oz.au
Subject: Re: pkg/40039 (sysutils/hal compilation errors (NetBSD 4.0))
Date: Sat, 29 Nov 2008 09:06:35 -0500

 Does the following patch work for you?

 --- Makefile 27 Nov 2008 22:19:10 -0000 1.14
 +++ Makefile 29 Nov 2008 14:05:36 -0000
 @@ -38,15 +38,17 @@

 .include "../../mk/bsd.prefs.mk"

 +PLIST_SRC= PLIST
 +
 .if ${OPSYS} == "FreeBSD" || ${OPSYS} == "DragonFly"
 CONFIGURE_ARGS+= --with-eject=/usr/sbin/cdcontrol
 CONFIGURE_ARGS+= --with-backend=freebsd
 -PLIST_SRC= PLIST.FreeBSD PLIST
 +PLIST_SRC+= PLIST.FreeBSD
 .endif

 .if !empty(MACHINE_PLATFORM:MNetBSD-[5-9]*)
 CONFIGURE_ARGS+= --with-backend=netbsd
 -PLIST_SRC= PLIST.NetBSD PLIST
 +PLIST_SRC+= PLIST.NetBSD
 .elif ${OPSYS} == "NetBSD"
 # Pull in the dummy backend for older NetBSD
 CONFIGURE_ARGS+= --with-backend=dummy

From: Robert Elz <kre@munnari.OZ.AU>
To: "Jared D. McNeill" <jmcneill@netbsd.org>
Cc: gnats-bugs@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/40039 (sysutils/hal compilation errors (NetBSD 4.0)) 
Date: Sat, 29 Nov 2008 22:51:27 +0700

     Date:        Sat, 29 Nov 2008 09:06:35 -0500
     From:        "Jared D. McNeill" <jmcneill@netbsd.org>
     Message-ID:  <41d6f0b90811290606y7f2fd974ye47795a5f8ab834e@mail.gmail.com>

   | Does the following patch work for you?

 Yes, that looks fine.  Or more accurately, the content of the patch
 looks fine, for reasons that I didn't bother to try to understand my
 patch program (standard NetBSD version from a while ago) didn't like
 the format of the patch, so I just applied it manually.  With that
 the package built fine.

 I have no idea why my brain fixated on the var name being LIST_SRC instead of 
 PLIST_SRC - obviously I used he correct one when I tested my version of
 the fix...

 And lastly, while I'm here, when the package built, it told me ...

 The following files should be created for hal-0.5.11nb10:

         /usr/pkg/etc/dbus-1/system.d/hal.conf (m=0644)
             [/usr/pkg/share/examples/hal/hal.conf]

 (and /etc/rc.d/hal but that one is fine).   That looks incorrect, I
 have PKG_SYSCONFBASE set, so /usr/pkg/etc isn't where conf files should
 be placed.   I see no use of the CONF_FILES mechanism in hal's Makefile,
 so I assume it hasn't been made to deal with PKG_SYSCONFDIR yet?

 kre

 ps: I deleted gnats-admin from the list of recipients of this message.

From: Bernd Ernesti <netbsd@lists.veego.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/40039 (sysutils/hal compilation errors (NetBSD 4.0))
Date: Sun, 7 Dec 2008 15:37:44 +0100

 On Sat, Nov 29, 2008 at 09:06:35AM -0500, Jared D. McNeill wrote:
 > Does the following patch work for you?

 Hmm, it looks like that will work for NetBSD < 5 but I think you will get
 problems during a pkg_delete for NetBSD 5 and FreeBSD due too the way
 how the PLIST files are handled.

 - PLIST
 @dirrm lib/hal/scripts
 @dirrm lib/hal

 - PLIST.FreeBSD
 @dirrm lib/hal/scripts/freebsd

 - PLIST.NetBSD
 @dirrm lib/hal/scripts/netbsd

 The @dirrm will be executed in the order of the generated PLIST file,
 so the @dirrm from PLIST come before the '@dirrm lib/hal/scripts/*'
 in PLIST.NetBSD or PLIST.FreeBSD. The @dirrm from PLIST will fail because
 there are still files/directories left in the lib/hal/scripts.

 IMHO there are three options:

 1. Don't use your patch and only add a 'PLIST_SRC= PLIST' in the
    NetBSD < 5 case
 2. Use your patch and do the following modifications.
    Add a PLIST.common_end file where at least the two lines from the
    PLIST file for '@dirrm lib/hal' and '@dirrm lib/hal/scripts'
    has to be moved to that file (where it would be better to move
    all @dirrm from PLIST to that file). Then add the new file after
    the Linux check with 'PLIST_SRC+= PLIST.common_end'.
    This mimics the behaviour in pkgsrc/mk/plist/plist.mk
 3. It could work to use 'PLIST_SRC= PLIST.FreeBSD' and
    'PLIST_SRC= PLIST.NetBSD' and use 'PLIST_SRC+= PLIST' after
    the NetBSD (or Linux) check.

 Note that I haven't tested anything, I only looked at the PLIST files.

 Bernd

State-Changed-From-To: open->feedback
State-Changed-By: jmcneill@NetBSD.org
State-Changed-When: Wed, 24 Dec 2008 04:44:26 +0000
State-Changed-Why:
Should be fixed.


From: Robert Elz <kre@munnari.OZ.AU>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/40039 (sysutils/hal compilation errors (NetBSD 4.0)) 
Date: Wed, 24 Dec 2008 18:18:00 +0700

 Yes, I think this one was fixed a day or two ago.

 Thanks,

 kre

State-Changed-From-To: feedback->closed
State-Changed-By: jmcneill@NetBSD.org
State-Changed-When: Wed, 24 Dec 2008 11:40:12 +0000
State-Changed-Why:


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.