NetBSD Problem Report #40228

From gson@gson.org  Fri Dec 19 14:26:44 2008
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id C72C863BA47
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 19 Dec 2008 14:26:43 +0000 (UTC)
Message-Id: <20081219142635.C3BED75E99@guava.gson.org>
Date: Fri, 19 Dec 2008 16:26:35 +0200 (EET)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@gnats.NetBSD.org
Subject: Docs on getting repository by rsync are incorrect
X-Send-Pr-Version: 3.95

>Number:         40228
>Category:       misc
>Synopsis:       Docs on getting repository by rsync are incorrect
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    www
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 19 14:30:00 +0000 2008
>Closed-Date:    Wed Oct 06 14:10:47 +0000 2010
>Last-Modified:  Wed Oct 06 14:10:47 +0000 2010
>Originator:     Andreas Gustafsson
>Release:        www.netbsd.org as of Dec 19, 2008
>Organization:
>Environment:
N/A
Architecture: N/A
Machine: N/A
>Description:

http://www.netbsd.org/docs/current/#getrepos says the command for
getting the NetBSD repository by rsync is:

  rsync -v -a rsync://anoncvs.NetBSD.org/cvsroot/src .

Because the above rsync command lacks the --delete option, files that
are deleted in the master repository (or moved to the Attic, as is
more commonly the case) will remain in the local repository copy when
the rsync command is repeated after the change to the master
repository is made.

This in turn causes incorrect checkout results; specifically, deleted
files will appear in checkouts using the incorrectly mirrored
repository.

>How-To-Repeat:

Mirror the repository by running the documented rsync command at
regular intervals over a period of a few months.  Do a fresh checkout
from the mirrored repository and find that it fails to build because
it contains files that should have been deleted.

In the interest of completeness, I should note that when I noticed the
problem, I was using "checkout -D", specifying a date equal to the
most recent commit in the repository.  I assume that for the purpose
of this bug this is equivalent to a checkout without "-D", but I have
not actually verified this experimentally.  In any case, I would argue
that any divergence between the contents of the master repository and
the local copy should be considered a bug, whether or not this
divergence breaks all types of CVS checkouts or only some of them.

>Fix:

Change the documentation to say

   rsync -v -a --delete rsync://anoncvs.NetBSD.org/cvsroot/src .

-- 
Andreas Gustafsson, gson@gson.org

>Release-Note:

>Audit-Trail:
From: "Greg A. Woods; Planix, Inc." <woods@planix.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/40228: Docs on getting repository by rsync are incorrect
Date: Fri, 19 Dec 2008 12:43:01 -0500

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --Apple-Mail-2-145794808
 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
 Content-Transfer-Encoding: 7bit


 On 19-Dec-2008, at 9:30 AM, Andreas Gustafsson wrote:
 >
 >   rsync -v -a --delete rsync://anoncvs.NetBSD.org/cvsroot/src .

 That's not quite complete yet either.  At least the "--exclude" is  
 also critical from the following parameters that I use:

 	-rlptHS --timeout=86000 -vz --stats --delete --delete-after --exclude  
 '#cvs.lock'

 I have a reasonably flexible wrapper script I use to drive rsync which  
 handles retries, reporting, and also does some default "cvs update"s  
 afterwards that I can try attaching to this PR too if that would be  
 desired.

 -- 
 					Greg A. Woods; Planix, Inc.
 					<woods@planix.ca>


 --Apple-Mail-2-145794808
 content-type: application/pgp-signature; x-mac-type=70674453;
 	name=PGP.sig
 content-description: This is a digitally signed message part
 content-disposition: inline; filename=PGP.sig
 content-transfer-encoding: 7bit

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.8 (Darwin)

 iD8DBQFJS90lZn1xt3i/9H8RAopdAKC/0tY57o+eV+BThCnRQqkRJixcvACfefMp
 5aNdn89LM8V5uS2nC1uO4FA=
 =VO1L
 -----END PGP SIGNATURE-----

 --Apple-Mail-2-145794808--

Responsible-Changed-From-To: misc-bug-people->www
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Sat, 14 Feb 2009 22:11:48 +0000
Responsible-Changed-Why:
website issue.


From: "D'Arcy J.M. Cain" <darcy@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40228 CVS commit: htdocs/docs/current
Date: Tue, 5 Oct 2010 16:08:04 +0000

 Module Name:	htdocs
 Committed By:	darcy
 Date:		Tue Oct  5 16:08:04 UTC 2010

 Modified Files:
 	htdocs/docs/current: index.xml

 Log Message:
 Modify rsync command to make sure that old files are deleted.
 Added Greg Woods' sugegstion for "--exclude '#cvs.lock'" as well
 Should close PR misc/40228


 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 htdocs/docs/current/index.xml

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: darcy@NetBSD.org
State-Changed-When: Tue, 05 Oct 2010 18:37:12 +0000
State-Changed-Why:
Added suggestions from submitter and GAW.


State-Changed-From-To: feedback->closed
State-Changed-By: gson@NetBSD.org
State-Changed-When: Wed, 06 Oct 2010 14:10:47 +0000
State-Changed-Why:
Fix looks good - thanks!


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.