NetBSD Problem Report #40233

From www@NetBSD.org  Sat Dec 20 07:00:59 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 206A463B8BD
	for <gnats-bugs@gnats.netbsd.org>; Sat, 20 Dec 2008 07:00:59 +0000 (UTC)
Message-Id: <20081220070058.DD5A663B121@narn.NetBSD.org>
Date: Sat, 20 Dec 2008 07:00:58 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: make is broken.
X-Send-Pr-Version: www-1.0

>Number:         40233
>Category:       bin
>Synopsis:       make is broken.
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 20 07:05:00 +0000 2008
>Closed-Date:    Sat Dec 20 09:43:05 +0000 2008
>Last-Modified:  Sat Dec 20 09:45:01 +0000 2008
>Originator:     Henning Petersen
>Release:        Netbsd-current
>Organization:
>Environment:
>Description:
Delete a free(buf) in usr.bin/make/main.c .
>How-To-Repeat:

>Fix:
 diff -u -r1.159 main.c
--- usr.bin/make/main.c	19 Dec 2008 22:03:41 -0000	1.159
+++ usr.bin/make/main.c	20 Dec 2008 06:16:26 -0000
@@ -603,7 +603,7 @@
 		free(p1);

 	argv = brk_string(buf, &argc, TRUE, &args);
-		free(buf);
+
 	if (argv == NULL) {
 		Error("Unterminated quoted string [%s]", buf);
 		free(buf);

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: dsl@NetBSD.org
State-Changed-When: Sat, 20 Dec 2008 09:43:05 +0000
State-Changed-Why:
Fixed as suggested.


From: David Laight <dsl@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40233 CVS commit: src/usr.bin/make
Date: Sat, 20 Dec 2008 09:42:02 +0000 (UTC)

 Module Name:	src
 Committed By:	dsl
 Date:		Sat Dec 20 09:42:02 UTC 2008

 Modified Files:
 	src/usr.bin/make: main.c

 Log Message:
 Delete very splurious 'free(buf)' that xtos added.
 Fixes PR bin/40233


 To generate a diff of this commit:
 cvs rdiff -r1.159 -r1.160 src/usr.bin/make/main.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search