NetBSD Problem Report #40282

From www@NetBSD.org  Sun Dec 28 13:03:55 2008
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id C1E7763BC6A
	for <gnats-bugs@gnats.netbsd.org>; Sun, 28 Dec 2008 13:03:54 +0000 (UTC)
Message-Id: <20081228130354.64A2663BC5B@narn.NetBSD.org>
Date: Sun, 28 Dec 2008 13:03:54 +0000 (UTC)
From: rehsack@web.de
Reply-To: rehsack@web.de
To: gnats-bugs@NetBSD.org
Subject: [PATCH] bug fix in devel/p5-Class-MethodMaker
X-Send-Pr-Version: www-1.0

>Number:         40282
>Category:       pkg
>Synopsis:       [PATCH] bug fix in devel/p5-Class-MethodMaker
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 28 13:05:00 +0000 2008
>Closed-Date:    Tue Jan 20 10:34:13 +0000 2009
>Last-Modified:  Tue Jan 20 10:34:13 +0000 2009
>Originator:     Jens Rehsack
>Release:        none
>Organization:
Bayer Business Services
>Environment:
FreeBSD7-STABLE, AIX 5.3 TL8, RHEL 4.5
>Description:
With the update of devel/p5-Class-MethodMaker to 2.13 a critical bug is introduced which may prevent this perl module to work. I don't know how quick the module author will fix the problem (see http://rt.cpan.org/Ticket/Display.html?id=41994), but I strongly recommend to include this fix into pkgsrc-2008Q4.
>How-To-Repeat:

>Fix:
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/p5-Class-MethodMaker/distinfo,v
retrieving revision 1.9
diff -u -u -r1.9 distinfo
--- distinfo	19 Dec 2008 17:45:36 -0000	1.9
+++ distinfo	28 Dec 2008 13:01:37 -0000
@@ -3,3 +3,4 @@
 SHA1 (Class-MethodMaker-2.13.tar.gz) = 229765c45e2668ae56fa932bf128969a79d18cfe
 RMD160 (Class-MethodMaker-2.13.tar.gz) = 65ed468e44adbe7aee21f8a8217f31b187cd4746
 Size (Class-MethodMaker-2.13.tar.gz) = 89006 bytes
+SHA1 (patch-aa) = 1ba9cbebcd32f0b5b46353f318469bb324996057
Index: patches/patch-aa
===================================================================
--- /dev/null	2008-12-28 12:55:01.000000000 +0000
+++ patches/patch-aa	2008-12-27 15:36:12.000000000 +0000
@@ -0,0 +1,11 @@
+--- MethodMaker.xs	2008-12-27 16:36:06.000000000 +0100
++++ MethodMaker.xs.orig	2008-12-27 16:31:09.000000000 +0100
+@@ -7,7 +7,7 @@
+ int
+ set_sub_name(SV *sub, char *pname, char *subname, char *stashname)
+   INIT:
+-    if (!SvTRUE(ST(0)) || !SvTRUE(ST(1)) || !SvTRUE(ST(2)) || !SvTRUE(ST(3)))
++    if (!SvTRUE(ST(1)) || !SvTRUE(ST(2)) || !SvTRUE(ST(3)) || !SvTRUE(ST(4)))
+       XSRETURN_UNDEF;
+   CODE:
+     CvGV((GV*)SvRV(sub)) = gv_fetchpv(stashname, TRUE, SVt_PV);

>Release-Note:

>Audit-Trail:
From: Havard Eidnes <he@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40282 CVS commit: pkgsrc/devel/p5-Class-MethodMaker
Date: Sun, 28 Dec 2008 21:14:14 +0000 (UTC)

 Module Name:	pkgsrc
 Committed By:	he
 Date:		Sun Dec 28 21:14:14 UTC 2008

 Modified Files:
 	pkgsrc/devel/p5-Class-MethodMaker: Makefile distinfo
 Added Files:
 	pkgsrc/devel/p5-Class-MethodMaker/patches: patch-aa

 Log Message:
 Add a patch from PR#40282, also reported at
 http://rt.cpan.org/Public/Bug/Display.html?id=41994

 OK'ed by wiz@.


 To generate a diff of this commit:
 cvs rdiff -r1.17 -r1.18 pkgsrc/devel/p5-Class-MethodMaker/Makefile
 cvs rdiff -r1.9 -r1.10 pkgsrc/devel/p5-Class-MethodMaker/distinfo
 cvs rdiff -r0 -r1.1 pkgsrc/devel/p5-Class-MethodMaker/patches/patch-aa

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: he@NetBSD.org
State-Changed-When: Sun, 28 Dec 2008 21:17:01 +0000
State-Changed-Why:
Fix applied (though patches should be done "old new", not "new old"...)
Hope it fixes the problem as advertized.


From: Jens Rehsack <rehsack@web.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/40282 ([PATCH] bug fix in devel/p5-Class-MethodMaker)
Date: Tue, 20 Jan 2009 06:57:39 +0000

 he@NetBSD.org wrote:
 > Synopsis: [PATCH] bug fix in devel/p5-Class-MethodMaker
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: he@NetBSD.org
 > State-Changed-When: Sun, 28 Dec 2008 21:17:01 +0000
 > State-Changed-Why:
 > Fix applied (though patches should be done "old new", not "new old"...)
 > Hope it fixes the problem as advertized.

 Meanwhile I had the chance to check all circumstances and can report the
 problem is fixed.

 /Jens

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 20 Jan 2009 10:34:13 +0000
State-Changed-Why:
Confirmed fixed.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.