NetBSD Problem Report #40431

From yamt@mwd.biglobe.ne.jp  Mon Jan 19 03:36:30 2009
Return-Path: <yamt@mwd.biglobe.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 534CF63B8BA
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 19 Jan 2009 03:36:30 +0000 (UTC)
Message-Id: <20090119033627.B943111702@yamt.dyndns.org>
Date: Mon, 19 Jan 2009 12:36:27 +0900 (JST)
From: yamt@mwd.biglobe.ne.jp
Reply-To: yamt@mwd.biglobe.ne.jp
To: gnats-bugs@gnats.NetBSD.org
Subject: recent fxp change broke my fxp
X-Send-Pr-Version: 3.95

>Number:         40431
>Category:       kern
>Synopsis:       recent fxp change broke my fxp
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    mrg
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 19 03:40:00 +0000 2009
>Closed-Date:    Sun Nov 15 02:21:55 +0000 2009
>Last-Modified:  Sun Nov 15 02:21:55 +0000 2009
>Originator:     YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
>Release:        NetBSD 5.99.7
>Organization:

>Environment:


Architecture: i386
Machine: i386
>Description:
	after the recent fxp driver changes,
	dhcpcd says "timeout" on my fxp0.

	fxp0 at pci1 dev 8 function 0: Intel PRO/100 VE (MOB) Network Controller, rev 131
	fxp0: interrupting at irq 11
	fxp0: Ethernet address 00:0e:7b:f9:87:20
	inphy0 at fxp0 phy 1: i82562ET 10/100 media interface, rev. 0
	inphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto

>How-To-Repeat:
>Fix:
	reverting the following changes fixes the problem.

	> Subject: CVS commit: src/sys/dev
	> From: matthew green <mrg@netbsd.org>
	> To: source-changes@NetBSD.org
	> Date: Sun, 18 Jan 2009 10:37:04 +0000 (UTC)
	> Reply-To: mrg@netbsd.org
	> 
	> 
	> Module Name:	src
	> Committed By:	mrg
	> Date:		Sun Jan 18 10:37:04 UTC 2009
	> 
	> Modified Files:
	> 	src/sys/dev/cardbus: if_fxp_cardbus.c
	> 	src/sys/dev/ic: i82557.c i82557var.h
	> 	src/sys/dev/mii: inphy.c
	> 	src/sys/dev/pci: if_fxp_pci.c
	> 
	> Log Message:
	> The PCI revision numbers are unique to a PCI vendor/product
	> ID pair.  Misuse of the revision numbers was causing some of the chip
	> features to be disabled on some integrated Intel chips.  So, move the
	> determination of the features into the bus frontend, where the
	> vendor/product ID is known.  (Note: sc_rev should be removed.  The
	> microcode patch stuff is also busted and needs to be fixed.)  Also,
	> poll the actual flow control status in inphy, rather than making
	> assumptions.
	> 
	> contributed anonymously.
	> 
	> 
	> To generate a diff of this commit:
	> cvs rdiff -r1.34 -r1.35 src/sys/dev/cardbus/if_fxp_cardbus.c
	> cvs rdiff -r1.121 -r1.122 src/sys/dev/ic/i82557.c
	> cvs rdiff -r1.41 -r1.42 src/sys/dev/ic/i82557var.h
	> cvs rdiff -r1.49 -r1.50 src/sys/dev/mii/inphy.c
	> cvs rdiff -r1.60 -r1.61 src/sys/dev/pci/if_fxp_pci.c
	> 
	> Please note that diffs are not public domain; they are subject to the
	> copyright notices on the relevant files.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->mrg
Responsible-Changed-By: mrg@NetBSD.org
Responsible-Changed-When: Sat, 24 Jan 2009 21:41:18 +0000
Responsible-Changed-Why:
i will take care of getting this fixed or backed out.


From: matthew green <mrg@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40431 CVS commit: src/sys/dev
Date: Fri, 20 Feb 2009 05:49:34 +0000 (UTC)

 Module Name:	src
 Committed By:	mrg
 Date:		Fri Feb 20 05:49:34 UTC 2009

 Modified Files:
 	src/sys/dev/cardbus: if_fxp_cardbus.c
 	src/sys/dev/ic: i82557.c i82557reg.h i82557var.h
 	src/sys/dev/pci: if_fxp_pci.c

 Log Message:
 - remove FXPF_IPCB flag.  it should always/only be used with the code
   conditional on FXPF_EXT_TXCB, so, replace all uses with that
 - for the pci frontend, reestablish some flags lost the the prior
   changes and simplify one of the cases

 this fixes PR 40677 and may fix PR 40431.


 To generate a diff of this commit:
 cvs rdiff -r1.35 -r1.36 src/sys/dev/cardbus/if_fxp_cardbus.c
 cvs rdiff -r1.122 -r1.123 src/sys/dev/ic/i82557.c
 cvs rdiff -r1.21 -r1.22 src/sys/dev/ic/i82557reg.h
 cvs rdiff -r1.42 -r1.43 src/sys/dev/ic/i82557var.h
 cvs rdiff -r1.61 -r1.62 src/sys/dev/pci/if_fxp_pci.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Fri, 20 Feb 2009 06:23:14 +0000
State-Changed-Why:
please test with the latest changes to fpx/i8255x driver. thanks.


From: yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi)
To: gnats-bugs@NetBSD.org
Cc: mrg@NetBSD.org, netbsd-bugs@netbsd.org, gnats-admin@netbsd.org,
        mrg@NetBSD.org
Subject: Re: kern/40431 (recent fxp change broke my fxp)
Date: Fri, 20 Feb 2009 18:59:30 +0900 (JST)

 > Synopsis: recent fxp change broke my fxp
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: mrg@NetBSD.org
 > State-Changed-When: Fri, 20 Feb 2009 06:23:14 +0000
 > State-Changed-Why:
 > please test with the latest changes to fpx/i8255x driver. thanks.

 KASSERT at i82557.c:378 failed during boot.

 YAMAMOTO Takashi

From: matthew green <mrg@eterna.com.au>
To: yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi)
Cc: netbsd-bugs@netbsd.org, gnats-admin@netbsd.org,
    gnats-bugs@NetBSD.org
Subject: re: kern/40431 (recent fxp change broke my fxp)
Date: Sat, 21 Feb 2009 04:24:16 +1100

    > Synopsis: recent fxp change broke my fxp
    > 
    > State-Changed-From-To: open->feedback
    > State-Changed-By: mrg@NetBSD.org
    > State-Changed-When: Fri, 20 Feb 2009 06:23:14 +0000
    > State-Changed-Why:
    > please test with the latest changes to fpx/i8255x driver. thanks.

    KASSERT at i82557.c:378 failed during boot.

 please try the following patch.  thanks.


 .mrg.


 Index: pci/if_fxp_pci.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/pci/if_fxp_pci.c,v
 retrieving revision 1.62
 diff -p -r1.62 if_fxp_pci.c
 *** pci/if_fxp_pci.c	20 Feb 2009 05:49:34 -0000	1.62
 --- pci/if_fxp_pci.c	20 Feb 2009 17:23:31 -0000
 *************** fxp_pci_attach(device_t parent, device_t
 *** 382,388 ****
   		aprint_normal(": %s, rev %d\n", fpp->fpp_name, sc->sc_rev);
   		if (sc->sc_rev >= FXP_REV_82558_A4)
   			sc->sc_flags |= FXPF_FC|FXPF_EXT_TXCB;
 ! 		if (sc->sc_rev == FXP_REV_82550 || sc->sc_rev == FXP_REV_82550_C)
   			sc->sc_flags |= FXPF_EXT_RFA;

   		break;
 --- 382,388 ----
   		aprint_normal(": %s, rev %d\n", fpp->fpp_name, sc->sc_rev);
   		if (sc->sc_rev >= FXP_REV_82558_A4)
   			sc->sc_flags |= FXPF_FC|FXPF_EXT_TXCB;
 ! 		if (sc->sc_rev >= FXP_REV_82550)
   			sc->sc_flags |= FXPF_EXT_RFA;

   		break;

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: mrg@eterna.com.au
Cc: yamt@mwd.biglobe.ne.jp, netbsd-bugs@NetBSD.org, gnats-admin@NetBSD.org,
        gnats-bugs@NetBSD.org, tsutsui@ceres.dti.ne.jp
Subject: Re: kern/40431 (recent fxp change broke my fxp)
Date: Sat, 21 Feb 2009 02:59:02 +0900

 > please try the following patch.  thanks.
  :

 > --- 382,388 ----
 >   		aprint_normal(": %s, rev %d\n", fpp->fpp_name, sc->sc_rev);
 >   		if (sc->sc_rev >= FXP_REV_82558_A4)
 >   			sc->sc_flags |= FXPF_FC|FXPF_EXT_TXCB;
 > ! 		if (sc->sc_rev >= FXP_REV_82550)
 >   			sc->sc_flags |= FXPF_EXT_RFA;
 >   
 >   		break;

 In the previous code, 82558 and 82559 have FXPF_EXT_TXCB
 but not FXPF_EXT_RFA, so I don't think we can replace FXPF_IPCB
 with FXPF_EXT_TXCB.
 ---
 Izumi Tsutsui

State-Changed-From-To: feedback->open
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Thu, 05 Mar 2009 05:28:10 +0000
State-Changed-Why:
feedback provided.


State-Changed-From-To: open->feedback
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Thu, 05 Mar 2009 05:28:45 +0000
State-Changed-Why:
between min3e and tsutsui's recent changes, what's the status of this now?

thanks.


From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@NetBSD.org, mrg@NetBSD.org, yamt@mwd.biglobe.ne.jp,
        tsutsui@ceres.dti.ne.jp
Subject: Re: kern/40431 (recent fxp change broke my fxp)
Date: Thu, 5 Mar 2009 17:59:28 +0900

 > between min3e and tsutsui's recent changes, what's the status of this now?

 http://mail-index.NetBSD.org/current-users/2009/03/04/msg008389.html
 http://mail-index.NetBSD.org/current-users/2009/03/05/msg008412.html
 ---
 Izumi Tsutsui

From: Izumi Tsutsui <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40431 CVS commit: src/sys/dev/pci
Date: Fri, 6 Mar 2009 09:54:02 +0000

 Module Name:	src
 Committed By:	tsutsui
 Date:		Fri Mar  6 09:54:02 UTC 2009

 Modified Files:
 	src/sys/dev/pci: if_fxp_pci.c

 Log Message:
 The Intel manual says that ICH and 82562 chips are compatible with 82559,
 not 82550, so don't set FXPF_EXT_RFA (available only on 82550/82551)
 for those variants.

 Tested on Intel PRO/100 VM with 82562EM/EX PHY by ISHII Kimio
 on current-users, and should also fix PR kern/40431.


 To generate a diff of this commit:
 cvs rdiff -u -r1.63 -r1.64 src/sys/dev/pci/if_fxp_pci.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 15 Nov 2009 02:21:55 +0000
State-Changed-Why:
expected fix committed in march, no feedback


>Unformatted:

Home	PR Database Search