NetBSD Problem Report #40495

From ryoh@bonnie.jaist.ac.jp  Tue Jan 27 12:20:57 2009
Return-Path: <ryoh@bonnie.jaist.ac.jp>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 26A4B63BAB8
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 27 Jan 2009 12:20:57 +0000 (UTC)
Message-Id: <20090127122051.04B6D13122@bonnie.jaist.ac.jp>
Date: Tue, 27 Jan 2009 21:20:50 +0900 (JST)
From: Ryo HAYASAKA <ryoh@jaist.ac.jp>
Reply-To: ryoh@jaist.ac.jp
To: gnats-bugs@gnats.NetBSD.org
Subject: etc/rc.d/rndctl doesn't support "-t net" argument
X-Send-Pr-Version: 3.95

>Number:         40495
>Category:       misc
>Synopsis:       etc/rc.d/rndctl doesn't support "-t net" argument
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 27 12:25:00 +0000 2009
>Closed-Date:    Mon Feb 02 14:23:55 +0000 2009
>Last-Modified:  Fri Feb 06 01:00:03 +0000 2009
>Originator:     Ryo HAYASAKA
>Release:        NetBSD 5.99.7
>Organization:
Japan Advanced Institute of Science and Technology (JAIST)
>Environment:
System: NetBSD bonnie.jaist.ac.jp 5.99.7 NetBSD 5.99.7 (BONNIE) #32: Fri Jan 23 20:57:36 JST 2009 root@bonnie.jaist.ac.jp:/usr/src/sys/arch/i386/compile/BONNIE i386
Architecture: i386
Machine: i386
>Description:
rndctl script doesn't work with "-t net" argument.

>How-To-Repeat:

>Fix:
Index: rndctl
===================================================================
RCS file: /usr/cvsup/src/etc/rc.d/rndctl,v
retrieving revision 1.1
diff -d -p -u -r1.1 rndctl
--- rndctl      4 Jan 2009 12:10:30 -0000       1.1
+++ rndctl      27 Jan 2009 12:10:10 -0000
@@ -58,7 +58,7 @@ rndctl_startcmd()
                                        #
                                        case "${flags}" in
                                        *[cCeE]*) ;;
-                                       *)      flags="${flags} -c -e" ;;
+                                       *)      flags="-c -e ${flags}" ;;
                                        esac
                                        case "${flags}" in
                                        *[dt]*) ;;


>Release-Note:

>Audit-Trail:
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40495 CVS commit: src/etc/rc.d
Date: Mon,  2 Feb 2009 09:24:47 +0000 (UTC)

 Module Name:	src
 Committed By:	apb
 Date:		Mon Feb  2 09:24:47 UTC 2009

 Modified Files:
 	src/etc/rc.d: rndctl

 Log Message:
 The -d or -t flag must appear after -c/-C/-e/-E flags, because of the
 way we add the device name. after the flags.
 Addresses PR 40495 from Ryo HAYASAKA.


 To generate a diff of this commit:
 cvs rdiff -r1.1 -r1.2 src/etc/rc.d/rndctl

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: apb@NetBSD.org
State-Changed-When: Mon, 02 Feb 2009 14:23:55 +0000
State-Changed-Why:
Thank you for the report and patch.  The patch has been applied.


From: Soren Jacobsen <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40495 CVS commit: [netbsd-5] src/etc/rc.d
Date: Fri,  6 Feb 2009 00:56:49 +0000 (UTC)

 Module Name:	src
 Committed By:	snj
 Date:		Fri Feb  6 00:56:49 UTC 2009

 Modified Files:
 	src/etc/rc.d [netbsd-5]: rndctl

 Log Message:
 Pull up following revision(s) (requested by apb in ticket #406):
 	etc/rc.d/rndctl: revision 1.2
 The -d or -t flag must appear after -c/-C/-e/-E flags, because of the
 way we add the device name. after the flags.
 Addresses PR 40495 from Ryo HAYASAKA.


 To generate a diff of this commit:
 cvs rdiff -r1.2.2.2 -r1.2.2.3 src/etc/rc.d/rndctl

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search