NetBSD Problem Report #40608

From www@NetBSD.org  Wed Feb 11 06:57:13 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 9E09F63C0C7
	for <gnats-bugs@gnats.netbsd.org>; Wed, 11 Feb 2009 06:57:13 +0000 (UTC)
Message-Id: <20090211065713.7338863BAB8@narn.NetBSD.org>
Date: Wed, 11 Feb 2009 06:57:13 +0000 (UTC)
From: abutter.gao@gmail.com
Reply-To: abutter.gao@gmail.com
To: gnats-bugs@NetBSD.org
Subject: a small mistake in a comment in sys/arch/i386/stand/lib/dump_eax.S
X-Send-Pr-Version: www-1.0

>Number:         40608
>Category:       port-i386
>Synopsis:       a small mistake in a comment in sys/arch/i386/stand/lib/dump_eax.S
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jnemeth
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 11 07:00:00 +0000 2009
>Closed-Date:    Wed Feb 11 07:25:21 +0000 2009
>Last-Modified:  Wed Feb 11 07:35:01 +0000 2009
>Originator:     Gao Ya'nan
>Release:        NetBSD-current and NetBSD-4.0
>Organization:
>Environment:
NetBSD abutter.foo.org 4.0 NetBSD 4.0 (GENERIC) #0: Sun Dec 16 00:20:10 PST 2007  builds@wb34:/home/builds/ab/netbsd-4-0-RELEASE/i386/200712160005Z-obj/home/builds/ab/netbsd-4-0-RELEASE/src/sys/arch/i386/compile/GENERIC i386

>Description:
----------------------------------->cut<-------------------------------
#if 1 /* 5 bytes to generate real hex... */
	daa					/* 30..39, 40..45 */
	addb	$0xc0, %al			/* f0..f9, 00..05 */
	adcb	$0x40, %al			/* 30..39, 41..45 */
#endif
----------------------------------->cut<-------------------------------

so, after adcb operation, AL will fall in betwwen 0x30 to 0x39 or between 0x41 to 0x46 but 0x45.

A small mistake.
>How-To-Repeat:
Read the code
>Fix:
Change
	adcb	$0x40, %al			/* 30..39, 41..45 */
to
	adcb	$0x40, %al			/* 30..39, 41..46 */

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: port-i386-maintainer->jnemeth
Responsible-Changed-By: jnemeth@NetBSD.org
Responsible-Changed-When: Wed, 11 Feb 2009 07:25:21 +0000
Responsible-Changed-Why:
I fixed it.


State-Changed-From-To: open->closed
State-Changed-By: jnemeth@NetBSD.org
State-Changed-When: Wed, 11 Feb 2009 07:25:21 +0000
State-Changed-Why:
Fixed.  Thanks for the PR!


From: John Nemeth <jnemeth@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40608 CVS commit: src/sys/arch/i386/stand/lib
Date: Wed, 11 Feb 2009 07:24:41 +0000 (UTC)

 Module Name:	src
 Committed By:	jnemeth
 Date:		Wed Feb 11 07:24:41 UTC 2009

 Modified Files:
 	src/sys/arch/i386/stand/lib: dump_eax.S

 Log Message:
 PR/40608 - Gao Ya'nan -- typo in comment


 To generate a diff of this commit:
 cvs rdiff -r1.2 -r1.3 src/sys/arch/i386/stand/lib/dump_eax.S

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search