NetBSD Problem Report #40628

From www@NetBSD.org  Fri Feb 13 15:31:45 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 4FBB463C183
	for <gnats-bugs@gnats.netbsd.org>; Fri, 13 Feb 2009 15:31:45 +0000 (UTC)
Message-Id: <20090213153145.200FB63C181@narn.NetBSD.org>
Date: Fri, 13 Feb 2009 15:31:45 +0000 (UTC)
From: corecode@fs.ei.tum.de
Reply-To: corecode@fs.ei.tum.de
To: gnats-bugs@NetBSD.org
Subject: make sysutils/smartmontools actually work on DragonFly
X-Send-Pr-Version: www-1.0

>Number:         40628
>Category:       pkg
>Synopsis:       make sysutils/smartmontools actually work on DragonFly
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    marino
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 13 15:35:00 +0000 2009
>Closed-Date:    Tue Nov 01 13:06:34 +0000 2011
>Last-Modified:  Tue Nov 01 13:06:34 +0000 2011
>Originator:     Simon Schubert
>Release:        
>Organization:
>Environment:
DragonFly
>Description:
sysutils/smartmontools compiles on DragonFly, but doesn't work because of a missing preprocessor conditional.  Patch below fixes this issue.
>How-To-Repeat:
bmake/pkg_add the smartmontools package on DragonFly and execute smartctl on your hdd.

>Fix:
Comparing patches/patch-ah to ../../../obj/pkgsrc/sysutils/smartmontools/work/.newpatches/patch-ah
12a13,21
> @@ -410,7 +409,7 @@ int ata_command_interface(int fd, smart_
>  #endif
>        return -1;
>  
> -#if __FreeBSD_version < 502000
> +#if !defined(__DragonFly__) && (__FreeBSD_version < 502000)
>      printwarning(NO_RETURN,NULL);
>  #endif
>  

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->shattered
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Fri, 13 Feb 2009 15:40:35 +0000
Responsible-Changed-Why:
Over to maintainer.


From: Sergey Svishchev <svs@ropnet.ru>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/40628
Date: Wed, 18 Feb 2009 02:15:53 +0300

 printwarning() doesn't prevent smartmontools from working, it only
 prints irrelevant message.

 Your patch looks OK, but I'll defer the commit until smartmontools
 developers review it -- there are two more places in os_freebsd.cpp
 where __FreeBSD_version is checked.

 -- 
 Sergey Svishchev

State-Changed-From-To: open->analyzed
State-Changed-By: shattered@NetBSD.org
State-Changed-When: Wed, 16 Mar 2011 22:50:06 +0000
State-Changed-Why:
Notified the smartmontools mailing list.


From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/40628 sysutils/smartmontools ticket stalled for DragonFly
Date: Sun, 30 Oct 2011 13:31:45 +0100

 This PR was written 2.5 years ago, and apparently no news has come from
 the March ping on the mailing list.

 While the patch is now obsolete, a similar patch can be made easily and
 won't affect any system other then DragonFly.

 May I take this PR over and add the patch?
 John

Responsible-Changed-From-To: shattered->marino
Responsible-Changed-By: marino@NetBSD.org
Responsible-Changed-When: Sun, 30 Oct 2011 17:40:22 +0000
Responsible-Changed-Why:
I'll take it.


From: "John Marino" <marino@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/40628 CVS commit: pkgsrc/sysutils/smartmontools
Date: Tue, 1 Nov 2011 12:59:17 +0000

 Module Name:	pkgsrc
 Committed By:	marino
 Date:		Tue Nov  1 12:59:17 UTC 2011

 Modified Files:
 	pkgsrc/sysutils/smartmontools: distinfo
 	pkgsrc/sysutils/smartmontools/patches: patch-ah

 Log Message:
 PR#40628 sysutils/smartmontools: DragonFly support

 Currently DragonFly is using the FreeBSD-specific configuration for
 Smartmontools.  In the future, a DragonFly-specific file should be
 created and moved upstream, but for now these additional macro
 conditions will provide DragonFly support.


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 pkgsrc/sysutils/smartmontools/distinfo
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/sysutils/smartmontools/patches/patch-ah

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: marino->closed
Responsible-Changed-By: marino@NetBSD.org
Responsible-Changed-When: Tue, 01 Nov 2011 13:03:18 +0000
Responsible-Changed-Why:
Patch equivalent to suggested fix implemented, along with additional
macro conditions to support DragonFly.  Assisted by Sascha Wildner.


Responsible-Changed-From-To: closed->marino
Responsible-Changed-By: marino@NetBSD.org
Responsible-Changed-When: Tue, 01 Nov 2011 13:06:34 +0000
Responsible-Changed-Why:
Accidently changed "responsible" instead of "state" on last edit.
Fix implemented; see last edit from a few minutes ago.


State-Changed-From-To: analyzed->closed
State-Changed-By: marino@NetBSD.org
State-Changed-When: Tue, 01 Nov 2011 13:06:34 +0000
State-Changed-Why:
Fixed.


>Unformatted:

Home	PR Database Search