NetBSD Problem Report #41155

From njoly@lanfeust.sis.pasteur.fr  Sun Apr  5 22:16:48 2009
Return-Path: <njoly@lanfeust.sis.pasteur.fr>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 37B4C63B8A5
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  5 Apr 2009 22:16:48 +0000 (UTC)
Message-Id: <20090405221642.B420CDC9B9@lanfeust.sis.pasteur.fr>
Date: Mon,  6 Apr 2009 00:16:42 +0200 (CEST)
From: njoly@pasteur.fr
Reply-To: njoly@pasteur.fr
To: gnats-bugs@gnats.NetBSD.org
Subject: recent mtree ordering breaks systat/sysstat installation uid/gid/perms
X-Send-Pr-Version: 3.95

>Number:         41155
>Category:       bin
>Synopsis:       recent mtree ordering breaks systat/sysstat installation uid/gid/perms
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 05 22:20:00 +0000 2009
>Closed-Date:    Mon May 18 16:06:24 +0000 2009
>Last-Modified:  Sat Jun 06 22:15:18 +0000 2009
>Originator:     Nicolas Joly
>Release:        NetBSD 5.99.10
>Organization:
Institut Pasteur
>Environment:
System: NetBSD nicodeme.sis.pasteur.fr 5.99.10 NetBSD 5.99.10 (NICODEME) #1: Sun Apr 5 16:13:00 CEST 2009 njoly@nicodeme.sis.pasteur.fr:/local/src/NetBSD/obj.amd64/sys/arch/amd64/compile/NICODEME amd64
Architecture: x86_64
Machine: amd64
>Description:
After upgrading one of my -current machine, i noticed that systat(1) won't
start anymore due to permission problem ...

njoly@lanfeust [~]> systat 
/dev/mem: Permission denied
njoly@lanfeust [~]> sysstat 
/dev/mem: Permission denied

It looks like that with recent mtree modification to do list ordering, now
sysstat(1) link get installed before systat(1) which has the expected
uid/gid/perms.

from an old working alpha base.tgz:
njoly@thanos [binary/sets]> tar tvzf base.tgz | grep -e systat -e sysstat
-r-xr-sr-x  1 root     kmem      160887 Mar 13 16:15 ./usr/bin/systat
-r-xr-xr-x  2 root     wheel          0 Mar 13 16:15 ./usr/bin/sysstat == ./usr/bin/systat

from a new broken amd64 base.tgz:
njoly@lanfeust [binary/sets]> tar tvzf base.tgz | grep -e systat -e sysstat
-r-xr-xr-x  1 root     wheel     134230 Apr  5 19:04 ./usr/bin/sysstat
-r-xr-sr-x  2 root     kmem           0 Apr  5 19:04 ./usr/bin/systat == ./usr/bin/sysstat

>How-To-Repeat:
try to install/update -current from sets. Notice that systat won't work
anymore due to permission problem.
>Fix:

>Release-Note:

>Audit-Trail:
From: Alan Barrett <apb@cequrux.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/41155: recent mtree ordering breaks systat/sysstat
	installation uid/gid/perms
Date: Mon, 6 Apr 2009 11:04:09 +0200

 On Sun, 05 Apr 2009, njoly@pasteur.fr wrote:
 > It looks like that with recent mtree modification to do list ordering, now
 > sysstat(1) link get installed before systat(1) which has the expected
 > uid/gid/perms.

 See PR 24457 for a related problem.  The uid/gid/perms stored in the
 METALOG for sysstat are incorrect, and previously things sort of worked
 by accident as a result of systat being installed before sysstat.

 --apb (Alan Barrett)

From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41155 CVS commit: src
Date: Fri, 10 Apr 2009 16:16:12 +0000

 Module Name:	src
 Committed By:	apb
 Date:		Fri Apr 10 16:16:12 UTC 2009

 Modified Files:
 	src/distrib/common: parselist.awk
 	src/share/dict: Makefile
 	src/share/mk: bsd.README bsd.hostprog.mk bsd.kmodule.mk bsd.lib.mk
 	    bsd.links.mk bsd.man.mk bsd.prog.mk
 	src/share/zoneinfo: Makefile

 Log Message:
 Add LINKSOWN, LINKSGRP, and LINKSMODE variables for use by bsd.links.mk
 when installing hard links.  They have no effect except when using a
 metalog, in which case the information is added to the metalog.  In
 the future, these variables may be replaced by a method for explicitly
 recording hard links in a metadata log.

 Also change a few things that called ${INSTALL_LINK} without going
 through bsd.links.mk.

 Reviewed by perry and joerg.  This should fix PR 24457 and PR 41155.


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 src/distrib/common/parselist.awk
 cvs rdiff -u -r1.16 -r1.17 src/share/dict/Makefile
 cvs rdiff -u -r1.248 -r1.249 src/share/mk/bsd.README
 cvs rdiff -u -r1.54 -r1.55 src/share/mk/bsd.hostprog.mk
 cvs rdiff -u -r1.18 -r1.19 src/share/mk/bsd.kmodule.mk
 cvs rdiff -u -r1.297 -r1.298 src/share/mk/bsd.lib.mk
 cvs rdiff -u -r1.33 -r1.34 src/share/mk/bsd.links.mk
 cvs rdiff -u -r1.99 -r1.100 src/share/mk/bsd.man.mk
 cvs rdiff -u -r1.240 -r1.241 src/share/mk/bsd.prog.mk
 cvs rdiff -u -r1.42 -r1.43 src/share/zoneinfo/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 18 May 2009 07:30:34 +0000
State-Changed-Why:
Fixed?


State-Changed-From-To: feedback->closed
State-Changed-By: njoly@NetBSD.org
State-Changed-When: Mon, 18 May 2009 16:06:24 +0000
State-Changed-Why:
apb@ fixed it. Thanks.


From: Manuel Bouyer <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41155 CVS commit: [netbsd-5] src
Date: Sat, 6 Jun 2009 22:10:13 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Sat Jun  6 22:10:13 UTC 2009

 Modified Files:
 	src/distrib/common [netbsd-5]: parselist.awk
 	src/distrib/sets [netbsd-5]: maketars
 	src/share/dict [netbsd-5]: Makefile
 	src/share/mk [netbsd-5]: bsd.README bsd.hostprog.mk bsd.kmodule.mk
 	    bsd.lib.mk bsd.links.mk bsd.man.mk bsd.prog.mk
 	src/share/zoneinfo [netbsd-5]: Makefile
 	src/usr.bin/xinstall [netbsd-5]: xinstall.c

 Log Message:
 Pull up following revision(s) (requested by snj in ticket #790):
 	share/mk/bsd.lib.mk: revision 1.298
 	share/mk/bsd.man.mk: revision 1.100
 	share/mk/bsd.hostprog.mk: revision 1.55
 	distrib/sets/maketars: revision 1.66
 	share/zoneinfo/Makefile: revision 1.43
 	share/mk/bsd.kmodule.mk: revision 1.19
 	usr.bin/xinstall/xinstall.c: revisions 1.106 - 1.108 via patch
 	share/mk/bsd.prog.mk: revision 1.241
 	share/dict/Makefile: revision 1.17
 	share/mk/bsd.README: revision 1.249
 	distrib/common/parselist.awk: revision 1.16
 	share/mk/bsd.links.mk: revision 1.34
 Explicitly sort entries on preparing set files from METALOG.
 METALOG could have different order due to install(1) race
 on parallel builds, and mtree(8) doesn't sort files.
 Should fix inconsistent shared sets among builds as seen in
 /pub/NetBSD-daily/netbsd-5/200904010000Z/shared/ and
 /pub/NetBSD-daily/netbsd-5/200904010002Z/shared/ dirs.
 Okay'ed by snj@.
 Changes for installing with a metalog:
 * When installing hard links and using a metalog, if -o, -g, -m, or -f
   args were explicitly specified on the command line, then believe them,
   but do not implicitly believe uname/gname/mode/flags from the file
   system.
 * Output fields in the same order used by mtree.
 Fix -Wshadow -Wcast-qual issues
 Re-calculate size and digestresult after stripping, to ensure that
 correct values appear in the metalog.
 Add LINKSOWN, LINKSGRP, and LINKSMODE variables for use by bsd.links.mk
 when installing hard links.  They have no effect except when using a
 metalog, in which case the information is added to the metalog.  In
 the future, these variables may be replaced by a method for explicitly
 recording hard links in a metadata log.
 Also change a few things that called ${INSTALL_LINK} without going
 through bsd.links.mk.
 Reviewed by perry and joerg.  This should fix PR 24457 and PR 41155.


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.15.4.1 src/distrib/common/parselist.awk
 cvs rdiff -u -r1.64.6.2 -r1.64.6.3 src/distrib/sets/maketars
 cvs rdiff -u -r1.16 -r1.16.38.1 src/share/dict/Makefile
 cvs rdiff -u -r1.236.2.7 -r1.236.2.8 src/share/mk/bsd.README
 cvs rdiff -u -r1.53 -r1.53.2.1 src/share/mk/bsd.hostprog.mk
 cvs rdiff -u -r1.13.2.1 -r1.13.2.2 src/share/mk/bsd.kmodule.mk
 cvs rdiff -u -r1.289.2.2 -r1.289.2.3 src/share/mk/bsd.lib.mk
 cvs rdiff -u -r1.32 -r1.32.24.1 src/share/mk/bsd.links.mk
 cvs rdiff -u -r1.98 -r1.98.2.1 src/share/mk/bsd.man.mk
 cvs rdiff -u -r1.239.2.1 -r1.239.2.2 src/share/mk/bsd.prog.mk
 cvs rdiff -u -r1.42 -r1.42.12.1 src/share/zoneinfo/Makefile
 cvs rdiff -u -r1.103 -r1.103.4.1 src/usr.bin/xinstall/xinstall.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Manuel Bouyer <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41155 CVS commit: [netbsd-5-0] src
Date: Sat, 6 Jun 2009 22:10:50 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Sat Jun  6 22:10:50 UTC 2009

 Modified Files:
 	src/distrib/common [netbsd-5-0]: parselist.awk
 	src/distrib/sets [netbsd-5-0]: maketars
 	src/share/dict [netbsd-5-0]: Makefile
 	src/share/mk [netbsd-5-0]: bsd.README bsd.hostprog.mk bsd.kmodule.mk
 	    bsd.lib.mk bsd.links.mk bsd.man.mk bsd.prog.mk
 	src/share/zoneinfo [netbsd-5-0]: Makefile
 	src/usr.bin/xinstall [netbsd-5-0]: xinstall.c

 Log Message:
 Pull up following revision(s) (requested by snj in ticket #790):
 	share/mk/bsd.lib.mk: revision 1.298
 	share/mk/bsd.man.mk: revision 1.100
 	share/mk/bsd.hostprog.mk: revision 1.55
 	distrib/sets/maketars: revision 1.66
 	share/zoneinfo/Makefile: revision 1.43
 	share/mk/bsd.kmodule.mk: revision 1.19
 	usr.bin/xinstall/xinstall.c: revisions 1.106 - 1.108 via patch
 	share/mk/bsd.prog.mk: revision 1.241
 	share/dict/Makefile: revision 1.17
 	share/mk/bsd.README: revision 1.249
 	distrib/common/parselist.awk: revision 1.16
 	share/mk/bsd.links.mk: revision 1.34
 Explicitly sort entries on preparing set files from METALOG.
 METALOG could have different order due to install(1) race
 on parallel builds, and mtree(8) doesn't sort files.
 Should fix inconsistent shared sets among builds as seen in
 /pub/NetBSD-daily/netbsd-5/200904010000Z/shared/ and
 /pub/NetBSD-daily/netbsd-5/200904010002Z/shared/ dirs.
 Okay'ed by snj@.
 Changes for installing with a metalog:
 * When installing hard links and using a metalog, if -o, -g, -m, or -f
   args were explicitly specified on the command line, then believe them,
   but do not implicitly believe uname/gname/mode/flags from the file
   system.
 * Output fields in the same order used by mtree.
 Fix -Wshadow -Wcast-qual issues
 Re-calculate size and digestresult after stripping, to ensure that
 correct values appear in the metalog.
 Add LINKSOWN, LINKSGRP, and LINKSMODE variables for use by bsd.links.mk
 when installing hard links.  They have no effect except when using a
 metalog, in which case the information is added to the metalog.  In
 the future, these variables may be replaced by a method for explicitly
 recording hard links in a metadata log.
 Also change a few things that called ${INSTALL_LINK} without going
 through bsd.links.mk.
 Reviewed by perry and joerg.  This should fix PR 24457 and PR 41155.


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.15.8.1 src/distrib/common/parselist.awk
 cvs rdiff -u -r1.64.6.2 -r1.64.6.2.2.1 src/distrib/sets/maketars
 cvs rdiff -u -r1.16 -r1.16.42.1 src/share/dict/Makefile
 cvs rdiff -u -r1.236.2.7 -r1.236.2.7.2.1 src/share/mk/bsd.README
 cvs rdiff -u -r1.53 -r1.53.4.1 src/share/mk/bsd.hostprog.mk
 cvs rdiff -u -r1.13.2.1 -r1.13.2.1.2.1 src/share/mk/bsd.kmodule.mk
 cvs rdiff -u -r1.289.2.2 -r1.289.2.2.2.1 src/share/mk/bsd.lib.mk
 cvs rdiff -u -r1.32 -r1.32.28.1 src/share/mk/bsd.links.mk
 cvs rdiff -u -r1.98 -r1.98.6.1 src/share/mk/bsd.man.mk
 cvs rdiff -u -r1.239.2.1 -r1.239.2.1.2.1 src/share/mk/bsd.prog.mk
 cvs rdiff -u -r1.42 -r1.42.16.1 src/share/zoneinfo/Makefile
 cvs rdiff -u -r1.103 -r1.103.6.1 src/usr.bin/xinstall/xinstall.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search