NetBSD Problem Report #41200

From www@NetBSD.org  Mon Apr 13 18:30:12 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 0558C63B8DF
	for <gnats-bugs@gnats.netbsd.org>; Mon, 13 Apr 2009 18:30:12 +0000 (UTC)
Message-Id: <20090413183011.C837963B8A5@www.NetBSD.org>
Date: Mon, 13 Apr 2009 18:30:11 +0000 (UTC)
From: guy@alum.mit.edu
Reply-To: guy@alum.mit.edu
To: gnats-bugs@NetBSD.org
Subject: <net/bpf.h> should include <sys/ioccom.h>
X-Send-Pr-Version: www-1.0

>Number:         41200
>Category:       kern
>Synopsis:       <net/bpf.h> should include <sys/ioccom.h>
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 13 18:35:00 +0000 2009
>Closed-Date:    Sat Sep 05 20:11:50 +0000 2015
>Last-Modified:  Mon Sep 07 03:50:01 +0000 2015
>Originator:     Guy Harris
>Release:        top of tree
>Organization:
>Environment:
>Description:
<net/bpf.h> defines ioctls, so it should include <sys/ioccom.h>, so that code that includes it doesn't have to include <sys/ioccom.h> itself beforehand or include something that includes <sys/ioccom.h>.  When I originally created <sys/ioccom.h> in SunOS 4.0, I intended it to be included by headers that defined ioctls, rather than by .c files.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41200 CVS commit: src/sys/net
Date: Sat, 5 Sep 2015 20:01:21 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Sat Sep  5 20:01:21 UTC 2015

 Modified Files:
 	src/sys/net: bpf.h

 Log Message:
 Uses _IOR/_IOW/etc. and thus needs sys/ioccom.h. PR 41200


 To generate a diff of this commit:
 cvs rdiff -u -r1.66 -r1.67 src/sys/net/bpf.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 05 Sep 2015 20:11:50 +0000
State-Changed-Why:
fixed, thanks. sorry this sat around so long.


From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41200 CVS commit: src/sys
Date: Sun, 6 Sep 2015 06:01:02 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Sun Sep  6 06:01:02 UTC 2015

 Modified Files:
 	src/sys/coda: coda.h coda_io.h coda_pioctl.h
 	src/sys/compat/freebsd: freebsd_ioctl.h
 	src/sys/compat/netinet6: in6_var.h
 	src/sys/compat/sunos: sunos.h
 	src/sys/compat/sys: clockctl.h cpuio.h
 	src/sys/compat/ultrix: ultrix_tty.h
 	src/sys/dev: biovar.h ccdvar.h cgdvar.h fssvar.h vndvar.h
 	src/sys/dev/apm: apmio.h
 	src/sys/dev/bluetooth: btdev.h btsco.h
 	src/sys/dev/dm: netbsd-dm.h
 	src/sys/dev/filemon: filemon.h
 	src/sys/dev/gpib: gpibio.h
 	src/sys/dev/i2o: iopio.h
 	src/sys/dev/ic: athioctl.h hd44780var.h isp_ioctl.h
 	src/sys/dev/ir: cirio.h irdaio.h
 	src/sys/dev/isa: satlinkio.h spkrio.h wtreg.h
 	src/sys/dev/ofw: openfirmio.h
 	src/sys/dev/pci: if_devar.h if_ipwvar.h if_iwivar.h if_lmc.h mlyio.h
 	    twaio.h
 	src/sys/dev/pci/cxgb: cxgb_ioctl.h
 	src/sys/dev/pcmcia: if_cnwioctl.h if_rayreg.h
 	src/sys/dev/ppbus: lptio.h
 	src/sys/dev/raidframe: rf_compat50.h
 	src/sys/dev/scsipi: ses.h
 	src/sys/dev/sun: disklabel.h fbio.h kbio.h vuid_event.h
 	src/sys/dev/tc: sticio.h
 	src/sys/dev/usb: ukyopon.h urio.h
 	src/sys/dev/vme: xio.h
 	src/sys/dev/wscons: wsdisplay_usl_io.h wseventvar.h
 	src/sys/net: if_atm.h if_gre.h if_ppp.h if_pppoe.h if_sppp.h if_srt.h
 	    if_tap.h if_tun.h slip.h
 	src/sys/net80211: ieee80211_ioctl.h
 	src/sys/netatalk: phase2.h
 	src/sys/netbt: hci.h
 	src/sys/netinet6: in6_var.h
 	src/sys/netisdn: i4b_debug.h i4b_ioctl.h i4b_isppp.h i4b_rbch_ioctl.h
 	    i4b_tel_ioctl.h i4b_trace.h
 	src/sys/netnatm: natm.h
 	src/sys/opencrypto: ocryptodev.h
 	src/sys/sys: agpio.h cdio.h chio.h clockctl.h gpio.h ioctl_compat.h
 	    ksyms.h lua.h midiio.h mtio.h radioio.h rndio.h scanio.h videoio.h

 Log Message:
 More on PR 41200: headers that declare ioctls should include sys/ioccom.h.
 This covers (I think) all the MI headers outside of external/ (and dist/).


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 src/sys/coda/coda.h
 cvs rdiff -u -r1.7 -r1.8 src/sys/coda/coda_io.h
 cvs rdiff -u -r1.8 -r1.9 src/sys/coda/coda_pioctl.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/compat/freebsd/freebsd_ioctl.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/compat/netinet6/in6_var.h
 cvs rdiff -u -r1.23 -r1.24 src/sys/compat/sunos/sunos.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/compat/sys/clockctl.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/compat/sys/cpuio.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/compat/ultrix/ultrix_tty.h
 cvs rdiff -u -r1.9 -r1.10 src/sys/dev/biovar.h
 cvs rdiff -u -r1.34 -r1.35 src/sys/dev/ccdvar.h src/sys/dev/vndvar.h
 cvs rdiff -u -r1.17 -r1.18 src/sys/dev/cgdvar.h
 cvs rdiff -u -r1.28 -r1.29 src/sys/dev/fssvar.h
 cvs rdiff -u -r1.5 -r1.6 src/sys/dev/apm/apmio.h
 cvs rdiff -u -r1.9 -r1.10 src/sys/dev/bluetooth/btdev.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/dev/bluetooth/btsco.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/dev/dm/netbsd-dm.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/dev/filemon/filemon.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/dev/gpib/gpibio.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/dev/i2o/iopio.h
 cvs rdiff -u -r1.15 -r1.16 src/sys/dev/ic/athioctl.h
 cvs rdiff -u -r1.7 -r1.8 src/sys/dev/ic/hd44780var.h
 cvs rdiff -u -r1.11 -r1.12 src/sys/dev/ic/isp_ioctl.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/dev/ir/cirio.h
 cvs rdiff -u -r1.7 -r1.8 src/sys/dev/ir/irdaio.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/dev/isa/satlinkio.h
 cvs rdiff -u -r1.1 -r1.2 src/sys/dev/isa/spkrio.h
 cvs rdiff -u -r1.8 -r1.9 src/sys/dev/isa/wtreg.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/dev/ofw/openfirmio.h
 cvs rdiff -u -r1.59 -r1.60 src/sys/dev/pci/if_devar.h
 cvs rdiff -u -r1.16 -r1.17 src/sys/dev/pci/if_ipwvar.h
 cvs rdiff -u -r1.17 -r1.18 src/sys/dev/pci/if_iwivar.h
 cvs rdiff -u -r1.21 -r1.22 src/sys/dev/pci/if_lmc.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/dev/pci/mlyio.h
 cvs rdiff -u -r1.5 -r1.6 src/sys/dev/pci/twaio.h
 cvs rdiff -u -r1.1 -r1.2 src/sys/dev/pci/cxgb/cxgb_ioctl.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/dev/pcmcia/if_cnwioctl.h
 cvs rdiff -u -r1.10 -r1.11 src/sys/dev/pcmcia/if_rayreg.h
 cvs rdiff -u -r1.8 -r1.9 src/sys/dev/ppbus/lptio.h
 cvs rdiff -u -r1.1 -r1.2 src/sys/dev/raidframe/rf_compat50.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/dev/scsipi/ses.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/dev/sun/disklabel.h src/sys/dev/sun/kbio.h
 cvs rdiff -u -r1.11 -r1.12 src/sys/dev/sun/fbio.h
 cvs rdiff -u -r1.7 -r1.8 src/sys/dev/sun/vuid_event.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/dev/tc/sticio.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/dev/usb/ukyopon.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/dev/usb/urio.h
 cvs rdiff -u -r1.5 -r1.6 src/sys/dev/vme/xio.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/dev/wscons/wsdisplay_usl_io.h
 cvs rdiff -u -r1.15 -r1.16 src/sys/dev/wscons/wseventvar.h
 cvs rdiff -u -r1.19 -r1.20 src/sys/net/if_atm.h
 cvs rdiff -u -r1.42 -r1.43 src/sys/net/if_gre.h
 cvs rdiff -u -r1.26 -r1.27 src/sys/net/if_ppp.h
 cvs rdiff -u -r1.11 -r1.12 src/sys/net/if_pppoe.h
 cvs rdiff -u -r1.27 -r1.28 src/sys/net/if_sppp.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/net/if_srt.h
 cvs rdiff -u -r1.5 -r1.6 src/sys/net/if_tap.h
 cvs rdiff -u -r1.18 -r1.19 src/sys/net/if_tun.h
 cvs rdiff -u -r1.9 -r1.10 src/sys/net/slip.h
 cvs rdiff -u -r1.20 -r1.21 src/sys/net80211/ieee80211_ioctl.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/netatalk/phase2.h
 cvs rdiff -u -r1.39 -r1.40 src/sys/netbt/hci.h
 cvs rdiff -u -r1.73 -r1.74 src/sys/netinet6/in6_var.h
 cvs rdiff -u -r1.9 -r1.10 src/sys/netisdn/i4b_debug.h
 cvs rdiff -u -r1.12 -r1.13 src/sys/netisdn/i4b_ioctl.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/netisdn/i4b_isppp.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/netisdn/i4b_rbch_ioctl.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/netisdn/i4b_tel_ioctl.h
 cvs rdiff -u -r1.5 -r1.6 src/sys/netisdn/i4b_trace.h
 cvs rdiff -u -r1.14 -r1.15 src/sys/netnatm/natm.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/opencrypto/ocryptodev.h
 cvs rdiff -u -r1.10 -r1.11 src/sys/sys/agpio.h
 cvs rdiff -u -r1.33 -r1.34 src/sys/sys/cdio.h
 cvs rdiff -u -r1.12 -r1.13 src/sys/sys/chio.h
 cvs rdiff -u -r1.15 -r1.16 src/sys/sys/clockctl.h src/sys/sys/midiio.h
 cvs rdiff -u -r1.13 -r1.14 src/sys/sys/gpio.h
 cvs rdiff -u -r1.16 -r1.17 src/sys/sys/ioctl_compat.h
 cvs rdiff -u -r1.32 -r1.33 src/sys/sys/ksyms.h
 cvs rdiff -u -r1.7 -r1.8 src/sys/sys/lua.h
 cvs rdiff -u -r1.23 -r1.24 src/sys/sys/mtio.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/sys/radioio.h src/sys/sys/scanio.h
 cvs rdiff -u -r1.1 -r1.2 src/sys/sys/rndio.h
 cvs rdiff -u -r1.8 -r1.9 src/sys/sys/videoio.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41200 CVS commit: src/sys/arch
Date: Mon, 7 Sep 2015 03:49:46 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Mon Sep  7 03:49:46 UTC 2015

 Modified Files:
 	src/sys/arch/acorn32/include: scrio.h
 	src/sys/arch/alpha/include: kbio.h
 	src/sys/arch/amiga/dev: clockioctl.h grfioctl.h iteioctl.h kbdreg.h
 	    viewioctl.h
 	src/sys/arch/atari/dev: clockioctl.h grfioctl.h iteioctl.h kbdreg.h
 	    viewioctl.h
 	src/sys/arch/atari/include: msioctl.h
 	src/sys/arch/atari/vme: leoioctl.h
 	src/sys/arch/hp300/stand/common: scsireg.h
 	src/sys/arch/mac68k/include: grfioctl.h
 	src/sys/arch/macppc/include: grfioctl.h
 	src/sys/arch/newsmips/include: wsconsio.h
 	src/sys/arch/ofppc/include: grfioctl.h
 	src/sys/arch/prep/include: nvram.h
 	src/sys/arch/sh3/include: wdogvar.h
 	src/sys/arch/shark/include: beep.h kbd.h mouse.h profileio.h scrio.h
 	src/sys/arch/sparc/dev: cgfourteenvar.h
 	src/sys/arch/sparc/include: openpromio.h tctrl.h
 	src/sys/arch/sun3/dev: xio.h
 	src/sys/arch/x68k/include: grfioctl.h iteioctl.h kbio.h sram.h
 	src/sys/arch/x68k/x68k: clockioctl.h
 	src/sys/arch/xen/include: xenio.h xenio3.h xenio_gntdev.h

 Log Message:
 Final bit of PR 41200: headers that declare ioctls should include sys/ioccom.h.
 This covers most if not all of the MD headers.

 XXX: a lot of the ioctl definitions in some of these files are cutpasted.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/sys/arch/acorn32/include/scrio.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/arch/alpha/include/kbio.h
 cvs rdiff -u -r1.5 -r1.6 src/sys/arch/amiga/dev/clockioctl.h
 cvs rdiff -u -r1.20 -r1.21 src/sys/arch/amiga/dev/grfioctl.h
 cvs rdiff -u -r1.12 -r1.13 src/sys/arch/amiga/dev/iteioctl.h
 cvs rdiff -u -r1.7 -r1.8 src/sys/arch/amiga/dev/kbdreg.h
 cvs rdiff -u -r1.9 -r1.10 src/sys/arch/amiga/dev/viewioctl.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/arch/atari/dev/clockioctl.h
 cvs rdiff -u -r1.9 -r1.10 src/sys/arch/atari/dev/grfioctl.h
 cvs rdiff -u -r1.7 -r1.8 src/sys/arch/atari/dev/iteioctl.h
 cvs rdiff -u -r1.5 -r1.6 src/sys/arch/atari/dev/kbdreg.h
 cvs rdiff -u -r1.1.1.1 -r1.2 src/sys/arch/atari/dev/viewioctl.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/arch/atari/include/msioctl.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/arch/atari/vme/leoioctl.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/arch/hp300/stand/common/scsireg.h
 cvs rdiff -u -r1.14 -r1.15 src/sys/arch/mac68k/include/grfioctl.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/macppc/include/grfioctl.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/arch/newsmips/include/wsconsio.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/arch/ofppc/include/grfioctl.h
 cvs rdiff -u -r1.8 -r1.9 src/sys/arch/prep/include/nvram.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/sh3/include/wdogvar.h
 cvs rdiff -u -r1.2 -r1.3 src/sys/arch/shark/include/beep.h \
     src/sys/arch/shark/include/kbd.h src/sys/arch/shark/include/mouse.h
 cvs rdiff -u -r1.1 -r1.2 src/sys/arch/shark/include/profileio.h \
     src/sys/arch/shark/include/scrio.h
 cvs rdiff -u -r1.16 -r1.17 src/sys/arch/sparc/dev/cgfourteenvar.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/sparc/include/openpromio.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/arch/sparc/include/tctrl.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/arch/sun3/dev/xio.h
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/x68k/include/grfioctl.h
 cvs rdiff -u -r1.8 -r1.9 src/sys/arch/x68k/include/iteioctl.h
 cvs rdiff -u -r1.5 -r1.6 src/sys/arch/x68k/include/kbio.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/arch/x68k/include/sram.h
 cvs rdiff -u -r1.4 -r1.5 src/sys/arch/x68k/x68k/clockioctl.h
 cvs rdiff -u -r1.9 -r1.10 src/sys/arch/xen/include/xenio.h
 cvs rdiff -u -r1.3 -r1.4 src/sys/arch/xen/include/xenio3.h
 cvs rdiff -u -r1.1 -r1.2 src/sys/arch/xen/include/xenio_gntdev.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search