NetBSD Problem Report #41250

From dhgutteridge@sympatico.ca  Sun Apr 19 21:02:51 2009
Return-Path: <dhgutteridge@sympatico.ca>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 5C42363C1FA
	for <gnats-bugs@gnats.netbsd.org>; Sun, 19 Apr 2009 21:02:51 +0000 (UTC)
Message-Id: <BLU0-SMTP60ED46F9AA44AD13B2961B7790@phx.gbl>
Date: Sun, 19 Apr 2009 17:03:03 -0400
From: "David H. Gutteridge" <DHGUTTERIDGE@SYMPATICO.CA>
Reply-To:
To: gnats-bugs@netbsd.org
Subject: librefuse fuse_opt.h header doesn't accommodate C++ compilation

>Number:         41250
>Category:       lib
>Synopsis:       librefuse fuse_opt.h header doesn't accommodate C++ compilation
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tron
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 19 21:05:00 +0000 2009
>Closed-Date:    Mon Aug 08 20:10:13 +0000 2011
>Last-Modified:  Mon Aug 08 20:10:13 +0000 2011
>Originator:     David H. Gutteridge
>Release:        NetBSD 5.99.10
>Organization:

>Environment:
  As above.
>Description:
 Hello,

 When trying to create a new pkgsrc package for a FUSE filesystem, I
 found that fuse_opt.h doesn't accommodate C++ compilation.  The
 (trivial) fix is below.

 (I'll submit my package when I've confirmed it's working, it certainly
 compiles now.  It's for Amazon S3 access via FUSE.)

 (PS I tried sending this before and then realized it would end up being
 unintelligible to Gnats, so you'll have some older malformed duplicates
 of this, sorry about that.)

>How-To-Repeat:

 Try compiling C++ code that makes use of functions defined in
 fuse_opt.h.

>Fix:
 --- fuse_opt.h.orig	2009-04-06 23:58:06.000000000 -0400
 +++ fuse_opt.h	2009-04-18 16:54:06.000000000 -0400
 @@ -31,6 +31,10 @@
   #ifndef _FUSE_OPT_H_
   #define _FUSE_OPT_H_

 +#ifdef __cplusplus
 +extern "C" {
 +#endif
 +
   enum {
   	FUSE_OPT_KEY_OPT = -1,
   	FUSE_OPT_KEY_NONOPT = -2,
 @@ -59,4 +63,8 @@
   		   const struct fuse_opt *, fuse_opt_proc_t);
   int fuse_opt_match(const struct fuse_opt *, const char *);

 +#ifdef __cplusplus
 +}
 +#endif
 +
   #endif /* _FUSE_OPT_H_ */


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: gnats-admin->lib-bug-people
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Sun, 26 Apr 2009 06:15:05 +0000
Responsible-Changed-Why:
Sort out mangled PR.


State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 26 Apr 2009 07:40:50 +0000
State-Changed-Why:
Christos fixed this an hour after the PR came in, but the commit didn't
make it to gnats for some reason.


From: "David H. Gutteridge" <dhgutteridge@sympatico.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: lib/41250 (librefuse fuse_opt.h header doesn't accommodate C++ compilation)
Date: Mon, 27 Apr 2009 19:05:58 -0400

 On 26-Apr-09, at 3:40 AM, dholland@NetBSD.org wrote:
  >Synopsis: librefuse fuse_opt.h header doesn't accommodate C++  
 compilation
  >
  >State-Changed-From-To: open->closed
  >State-Changed-By: dholland@NetBSD.org
  >State-Changed-When: Sun, 26 Apr 2009 07:40:50 +0000
  >State-Changed-Why:
  >Christos fixed this an hour after the PR came in, but the commit  
 didn't
  >make it to gnats for some reason.

 Is it possible to pull this up to the netbsd-5 branch (after 5.0 is
 released)?  This should be a non-intrusive change, and may benefit
 people trying to package other FUSE components.

 Dave

State-Changed-From-To: closed->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Wed, 29 Apr 2009 03:41:36 +0000
State-Changed-Why:
submitter wants pullup to -5 (which seems eminently reasonable)


Responsible-Changed-From-To: lib-bug-people->tron
Responsible-Changed-By: tron@NetBSD.org
Responsible-Changed-When: Sat, 09 Jul 2011 16:21:43 +0000
Responsible-Changed-Why:
I'm handling the pullup requests.


State-Changed-From-To: open->pending-pullups
State-Changed-By: tron@NetBSD.org
State-Changed-When: Sat, 09 Jul 2011 16:21:43 +0000
State-Changed-Why:
I've requested pullup into the "netbsd-5" branch:

http://releng.netbsd.org/cgi-bin/req-5.cgi?show=1649


From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41250 CVS commit: [netbsd-5] src/lib/librefuse
Date: Mon, 8 Aug 2011 19:55:27 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Mon Aug  8 19:55:27 UTC 2011

 Modified Files:
 	src/lib/librefuse [netbsd-5]: fuse_opt.h

 Log Message:
 Pull up following revision(s) (requested by tron in ticket #1649):
 	lib/librefuse/fuse_opt.h: revision 1.5
 PR/41250: David H. Gutteridge: librefuse fuse_opt.h header doesn't accommod=
 ate
 C++ compilation


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.4.18.1 src/lib/librefuse/fuse_opt.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: tron@NetBSD.org
State-Changed-When: Mon, 08 Aug 2011 20:10:13 +0000
State-Changed-Why:
The change has been pulled up into the "netbsd-5" branch. Thanks a lot for
the bug report.


>Unformatted:

Home	PR Database Search