NetBSD Problem Report #41255
From www@NetBSD.org Tue Apr 21 02:36:39 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id 6B25663BC38
for <gnats-bugs@gnats.netbsd.org>; Tue, 21 Apr 2009 02:36:39 +0000 (UTC)
Message-Id: <20090421023639.0659263B8A5@www.NetBSD.org>
Date: Tue, 21 Apr 2009 02:36:39 +0000 (UTC)
From: lidl@pix.net
Reply-To: lidl@pix.net
To: gnats-bugs@NetBSD.org
Subject: gcc 4.3.3 won't compile some of the source tree
X-Send-Pr-Version: www-1.0
>Number: 41255
>Category: misc
>Synopsis: gcc 4.3.3 won't compile some of the source tree
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: misc-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Apr 21 02:40:00 +0000 2009
>Closed-Date: Wed Jul 15 06:50:28 +0000 2009
>Last-Modified: Wed Jul 15 06:50:28 +0000 2009
>Originator: Kurt Lidl
>Release: netbsd-5
>Organization:
>Environment:
SunOS lsl.pix.net 5.11 snv_110 i86pc i386 i86pc
(Cross compiling for netbsd-5 on a new target architecture)
>Description:
Gcc 4.3.3 is more picky that the in-tree gcc 4.1.2 that netbsd-5
has. However, it supports the processor (Freescale Coldfire) that
is being used for this project.
crypto/dist/heimdal/lib/hx509/softp11.c
-- missing va_start before varargs processing
dist/ntp/ntpd/ntp_loopfilter.c
-- bad code in #ifdef/#else clause that will not parse
sys/arch/sparc/dev/cgfourteen.c
-- single quote in comment that gcc will not accept
sys/fs/hfs/libhfs.c
-- Initialize a data structure that gcc cannot determine if it
used or not during this function. This patch makes it
compile, but I'm not 100% sure it is correct. Feedback
welcome.
sys/kern/vfs_wapbl.c
-- Comment in #ifdef/#endif block that gcc will not parse,
just change it to be a proper "C" multi-line comment
sys/nfs/nfs_vnops.c
-- I think this should be a pid_t and not a short, but am not
100% sure that it matters. Feedback welcome.
sys/rump/librump/rumpuser/rumpuser_pth.c
-- Mark the function as __dead so it matches its prototype,
and then gcc 4.3.3 will compile it.
tests/Makefile
-- OK, this isn't actually a "gcc" problem, but tests/net relies
on ATF, so if MKATF==no, don't try the "net" directory either
usr.bin/mail/lex.c
-- Get rid of "might be clobbered by `longjmp' or `vfork'" error.
This might be an inappropriate way to fix the problem.
Feedback welcome.
usr.bin/mixerctl/mixerctl.c
-- I don't see how this could have worked before, properly.
usr.bin/rdist/expand.c
-- #ifdef out a unused static function
usr.bin/systat/main.c
-- Use strcmp to figure out argment match. I'm not sure this is
correct or not. The way that argument parsing is done in this
program seems kinda fragile to me.
>How-To-Repeat:
Build a gcc 4.3.3 cross-compiler, cross-build netbsd-5 with that
compiler, watch the problems roll in.
>Fix:
I will attach a diff to this PR once I get the number back from the
server.
>Release-Note:
>Audit-Trail:
From: "Kurt J. Lidl" <lidl@pix.net>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: misc/41255: gcc 4.3.3 won't compile some of the source tree
Date: Mon, 20 Apr 2009 22:41:32 -0400
--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Tue, Apr 21, 2009 at 02:40:01AM +0000, gnats-admin@NetBSD.org wrote:
> Thank you very much for your problem report.
> It has the internal identification `misc/41255'.
> The individual assigned to look at your
> report is: misc-bug-people.
>
> >Category: misc
> >Responsible: misc-bug-people
> >Synopsis: gcc 4.3.3 won't compile some of the source tree
> >Arrival-Date: Tue Apr 21 02:40:00 +0000 2009
Attached should be the patch file.
-Kurt
--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="gcc_4_3_3.diffs"
Index: crypto/dist/heimdal/lib/hx509/softp11.c
===================================================================
RCS file: /cvsroot/src/crypto/dist/heimdal/lib/hx509/softp11.c,v
retrieving revision 1.1
diff -u -3 -r1.1 softp11.c
--- crypto/dist/heimdal/lib/hx509/softp11.c 22 Mar 2008 09:42:41 -0000 1.1
+++ crypto/dist/heimdal/lib/hx509/softp11.c 21 Apr 2009 01:48:16 -0000
@@ -127,6 +127,7 @@
{
int len;
va_list ap;
+ va_start(ap, fmt);
len = vsnprintf(str, size, fmt, ap);
va_end(ap);
if (len < 0 || len > size)
Index: dist/ntp/ntpd/ntp_loopfilter.c
===================================================================
RCS file: /cvsroot/src/dist/ntp/ntpd/ntp_loopfilter.c,v
retrieving revision 1.8.18.1
diff -u -3 -r1.8.18.1 ntp_loopfilter.c
--- dist/ntp/ntpd/ntp_loopfilter.c 16 Jan 2009 03:01:13 -0000 1.8.18.1
+++ dist/ntp/ntpd/ntp_loopfilter.c 21 Apr 2009 01:48:21 -0000
@@ -191,7 +191,7 @@
#ifdef STA_FMT
snprintb(buf, sizeof(buf), STA_FMT, ntv.status);
#else
- snprintf(buf, sizeof(buf), "%04x, status);
+ snprintf(buf, sizeof(buf), "%04x", status);
#endif
NLOG(NLOG_SYNCEVENT | NLOG_SYSEVENT)
msyslog(LOG_NOTICE,
Index: sys/arch/sparc/dev/cgfourteen.c
===================================================================
RCS file: /cvsroot/src/sys/arch/sparc/dev/cgfourteen.c,v
retrieving revision 1.54
diff -u -3 -r1.54 cgfourteen.c
--- sys/arch/sparc/dev/cgfourteen.c 13 Jun 2008 13:10:18 -0000 1.54
+++ sys/arch/sparc/dev/cgfourteen.c 21 Apr 2009 01:49:13 -0000
@@ -155,7 +155,7 @@
#endif
#if defined(RASTERCONSOLE) && (NWSDISPLAY > 0)
-#error You can't have it both ways - either RASTERCONSOLE or wsdisplay
+#error You cannot have it both ways - either RASTERCONSOLE or wsdisplay
#endif
/*
Index: sys/dev/mii/miidevs
===================================================================
RCS file: /cvsroot/src/sys/dev/mii/miidevs,v
retrieving revision 1.78
diff -u -3 -r1.78 miidevs
--- sys/dev/mii/miidevs 28 Sep 2008 18:30:11 -0000 1.78
+++ sys/dev/mii/miidevs 21 Apr 2009 01:49:15 -0000
@@ -205,6 +205,7 @@
model xxNATSEMI DP83843 0x0001 DP83843 10/100 media interface
model xxNATSEMI DP83815 0x0002 DP83815 10/100 media interface
model xxNATSEMI DP83847 0x0003 DP83847 10/100 media interface
+model xxNATSEMI DP83849 0x000a DP8384a 10/100 media interface
model xxNATSEMI DP83891 0x0005 DP83891 1000BASE-T media interface
model xxNATSEMI DP83861 0x0006 DP83861 1000BASE-T media interface
Index: sys/dev/mii/miidevs.h
===================================================================
RCS file: /cvsroot/src/sys/dev/mii/miidevs.h,v
retrieving revision 1.81
diff -u -3 -r1.81 miidevs.h
--- sys/dev/mii/miidevs.h 28 Sep 2008 18:30:47 -0000 1.81
+++ sys/dev/mii/miidevs.h 21 Apr 2009 01:49:15 -0000
@@ -286,6 +286,8 @@
#define MII_STR_xxNATSEMI_DP83815 "DP83815 10/100 media interface"
#define MII_MODEL_xxNATSEMI_DP83847 0x0003
#define MII_STR_xxNATSEMI_DP83847 "DP83847 10/100 media interface"
+#define MII_MODEL_xxNATSEMI_DP83849 0x000a
+#define MII_STR_xxNATSEMI_DP83849 "DP83849 10/100 media interface"
#define MII_MODEL_xxNATSEMI_DP83891 0x0005
#define MII_STR_xxNATSEMI_DP83891 "DP83891 1000BASE-T media interface"
#define MII_MODEL_xxNATSEMI_DP83861 0x0006
Index: sys/dev/mii/miidevs_data.h
===================================================================
RCS file: /cvsroot/src/sys/dev/mii/miidevs_data.h,v
retrieving revision 1.71
diff -u -3 -r1.71 miidevs_data.h
--- sys/dev/mii/miidevs_data.h 28 Sep 2008 18:30:47 -0000 1.71
+++ sys/dev/mii/miidevs_data.h 21 Apr 2009 01:49:15 -0000
@@ -111,6 +111,7 @@
{ MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83843, MII_STR_xxNATSEMI_DP83843 },
{ MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83815, MII_STR_xxNATSEMI_DP83815 },
{ MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83847, MII_STR_xxNATSEMI_DP83847 },
+ { MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83849, MII_STR_xxNATSEMI_DP83849 },
{ MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83891, MII_STR_xxNATSEMI_DP83891 },
{ MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83861, MII_STR_xxNATSEMI_DP83861 },
{ MII_OUI_xxPMCSIERRA, MII_MODEL_xxPMCSIERRA_PM8351, MII_STR_xxPMCSIERRA_PM8351 },
Index: sys/dev/mii/nsphyter.c
===================================================================
RCS file: /cvsroot/src/sys/dev/mii/nsphyter.c,v
retrieving revision 1.32
diff -u -3 -r1.32 nsphyter.c
--- sys/dev/mii/nsphyter.c 5 May 2008 01:37:56 -0000 1.32
+++ sys/dev/mii/nsphyter.c 21 Apr 2009 01:49:15 -0000
@@ -107,6 +107,9 @@
{ MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83847,
MII_STR_xxNATSEMI_DP83847 },
+ { MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83849,
+ MII_STR_xxNATSEMI_DP83849 },
+
{ MII_OUI_xxNATSEMI, MII_MODEL_xxNATSEMI_DP83815,
MII_STR_xxNATSEMI_DP83815 },
Index: sys/fs/hfs/libhfs.c
===================================================================
RCS file: /cvsroot/src/sys/fs/hfs/libhfs.c,v
retrieving revision 1.5
diff -u -3 -r1.5 libhfs.c
--- sys/fs/hfs/libhfs.c 11 Dec 2007 12:04:23 -0000 1.5
+++ sys/fs/hfs/libhfs.c 21 Apr 2009 01:49:16 -0000
@@ -809,7 +809,7 @@
hfs_file_record_t file;
hfs_catalog_key_t filekey;
hfs_thread_record_t fileparent;
- hfs_fork_t fork;
+ hfs_fork_t fork = { 0 };
hfs_extent_record_t nextextentrec;
uint32_t numblocks;
uint16_t numextents, n;
Index: sys/kern/vfs_wapbl.c
===================================================================
RCS file: /cvsroot/src/sys/kern/vfs_wapbl.c,v
retrieving revision 1.3.8.1
diff -u -3 -r1.3.8.1 vfs_wapbl.c
--- sys/kern/vfs_wapbl.c 24 Feb 2009 04:13:35 -0000 1.3.8.1
+++ sys/kern/vfs_wapbl.c 21 Apr 2009 01:49:17 -0000
@@ -1176,12 +1176,13 @@
#endif
if (bp->b_error) {
-#ifdef notyet /* Can't currently handle possible dirty buffer reuse */
+#ifdef notyet
+ /* Can't currently handle possible dirty buffer reuse
XXXpooka: interfaces not fully updated
Note: this was not enabled in the original patch
against netbsd4 either. I don't know if comment
above is true or not.
-
+ */
/*
* If an error occurs, report the error and leave the
* buffer as a delayed write on the LRU queue.
Index: sys/nfs/nfs_vnops.c
===================================================================
RCS file: /cvsroot/src/sys/nfs/nfs_vnops.c,v
retrieving revision 1.267
diff -u -3 -r1.267 nfs_vnops.c
--- sys/nfs/nfs_vnops.c 15 Oct 2008 14:21:35 -0000 1.267
+++ sys/nfs/nfs_vnops.c 21 Apr 2009 01:49:18 -0000
@@ -2972,7 +2972,7 @@
struct sillyrename *sp;
struct nfsnode *np;
int error;
- short pid;
+ pid_t pid;
cache_purge(dvp);
np = VTONFS(vp);
Index: sys/rump/librump/rumpuser/rumpuser_pth.c
===================================================================
RCS file: /cvsroot/src/sys/rump/librump/rumpuser/rumpuser_pth.c,v
retrieving revision 1.18
diff -u -3 -r1.18 rumpuser_pth.c
--- sys/rump/librump/rumpuser/rumpuser_pth.c 30 Oct 2008 01:54:25 -0000 1.18
+++ sys/rump/librump/rumpuser/rumpuser_pth.c 21 Apr 2009 01:49:18 -0000
@@ -142,7 +142,7 @@
return pthread_create(&ptid, NULL, f, arg);
}
-void
+__dead void
rumpuser_thread_exit()
{
Index: tests/Makefile
===================================================================
RCS file: /cvsroot/src/tests/Makefile,v
retrieving revision 1.9
diff -u -3 -r1.9 Makefile
--- tests/Makefile 16 Aug 2008 23:51:51 -0000 1.9
+++ tests/Makefile 21 Apr 2009 01:49:18 -0000
@@ -2,10 +2,10 @@
.include <bsd.own.mk>
-SUBDIR= fs games modules net util
+SUBDIR= fs games modules util
.if ${MKATF} != "no"
-SUBDIR+= atf
+SUBDIR+= atf net
.endif
TESTSDIR= ${TESTSBASE}
Index: usr.bin/mail/lex.c
===================================================================
RCS file: /cvsroot/src/usr.bin/mail/lex.c,v
retrieving revision 1.36
diff -u -3 -r1.36 lex.c
--- usr.bin/mail/lex.c 17 Dec 2007 22:06:00 -0000 1.36
+++ usr.bin/mail/lex.c 21 Apr 2009 01:49:21 -0000
@@ -484,7 +484,7 @@
{
char *word;
char *arglist[MAXARGC];
- const struct cmd *com = NULL;
+ const volatile struct cmd *com = NULL;
char *volatile cp;
int c;
int e = 1;
Index: usr.bin/mixerctl/mixerctl.c
===================================================================
RCS file: /cvsroot/src/usr.bin/mixerctl/mixerctl.c,v
retrieving revision 1.22
diff -u -3 -r1.22 mixerctl.c
--- usr.bin/mixerctl/mixerctl.c 28 Apr 2008 20:24:14 -0000 1.22
+++ usr.bin/mixerctl/mixerctl.c 21 Apr 2009 01:49:21 -0000
@@ -364,7 +364,7 @@
fd = open(file, O_RDWR);
/* Try with mixer0. */
- if (fd < 0 && file == _PATH_MIXER) {
+ if (fd < 0 && (strcmp(file, _PATH_MIXER) == 0)) {
file = _PATH_MIXER0;
fd = open(file, O_RDWR);
}
Index: usr.bin/rdist/expand.c
===================================================================
RCS file: /cvsroot/src/usr.bin/rdist/expand.c,v
retrieving revision 1.16
diff -u -3 -r1.16 expand.c
--- usr.bin/rdist/expand.c 7 Aug 2003 11:15:35 -0000 1.16
+++ usr.bin/rdist/expand.c 21 Apr 2009 01:49:21 -0000
@@ -77,7 +77,9 @@
static void expstr(char *);
static int match(char *, char *);
static void matchdir(char *);
+#if 0
static int smatch(char *, char *);
+#endif
/*
* Take a list of names and expand any macros, etc.
@@ -520,6 +522,7 @@
}
}
+#if 0
static int
smatch(char *s, char *p)
{
@@ -577,6 +580,7 @@
}
}
}
+#endif
static void
Cat(char *s1, char *s2)
Index: usr.bin/systat/main.c
===================================================================
RCS file: /cvsroot/src/usr.bin/systat/main.c,v
retrieving revision 1.43
diff -u -3 -r1.43 main.c
--- usr.bin/systat/main.c 21 Jul 2008 14:19:26 -0000 1.43
+++ usr.bin/systat/main.c 21 Apr 2009 01:49:22 -0000
@@ -153,7 +153,7 @@
break;
}
- if(strstr("all",argv[0]) == "all"){
+ if (!strcmp(strstr("all",argv[0]), "all")) {
allcounter=0;
allflag=1;
}
--FL5UXtIhxfXey3p5--
From: Alan Barrett <apb@cequrux.com>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: misc/41255: gcc 4.3.3 won't compile some of the source tree
Date: Mon, 27 Apr 2009 23:41:41 +0200
On Tue, 21 Apr 2009, Kurt J. Lidl wrote:
> --- usr.bin/mail/lex.c 17 Dec 2007 22:06:00 -0000 1.36
> +++ usr.bin/mail/lex.c 21 Apr 2009 01:49:21 -0000
> @@ -484,7 +484,7 @@
> {
> char *word;
> char *arglist[MAXARGC];
> - const struct cmd *com = NULL;
> + const volatile struct cmd *com = NULL;
> char *volatile cp;
> int c;
> int e = 1;
I think that should be
const struct cmd * volatile com = NULL;
(a volatile pointer to a non-volatile const struct).
By my reading of the setjmp/longjmp rules in section 7.13.2.1 of the
N1256 draft of the C99 standard), com needs to be volatile to protect it
from becoming indeterminate as a result of a longjmp call. The struct
that com points to, on the other hand, does not have automatic storage
duration and is therefore not at risk of becoming indeterminate, whether
or not it is volatile.
--apb (Alan Barrett)
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/crypto/dist/heimdal/lib/hx509
Date: Tue, 14 Jul 2009 20:54:25 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 20:54:25 UTC 2009
Modified Files:
src/crypto/dist/heimdal/lib/hx509: softp11.c
Log Message:
Add missing va_start before varargs processing.
Part of PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/crypto/dist/heimdal/lib/hx509/softp11.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/dist/ntp/ntpd
Date: Tue, 14 Jul 2009 20:56:12 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 20:56:12 UTC 2009
Modified Files:
src/dist/ntp/ntpd: ntp_loopfilter.c
Log Message:
Add missing close quote in a usually-unreached part of an #if block.
Part of PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/dist/ntp/ntpd/ntp_loopfilter.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/sys/arch/sparc/dev
Date: Tue, 14 Jul 2009 20:57:22 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 20:57:22 UTC 2009
Modified Files:
src/sys/arch/sparc/dev: cgfourteen.c
Log Message:
Enclose the argument to #error in quotes, to protect an embedded single
quote. Part of PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.60 -r1.61 src/sys/arch/sparc/dev/cgfourteen.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/sys/kern
Date: Tue, 14 Jul 2009 20:59:00 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 20:59:00 UTC 2009
Modified Files:
src/sys/kern: vfs_wapbl.c
Log Message:
Convert free text inside #ifdef to a proper comment.
Inspired by PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.26 src/sys/kern/vfs_wapbl.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/sys/nfs
Date: Tue, 14 Jul 2009 20:59:54 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 20:59:54 UTC 2009
Modified Files:
src/sys/nfs: nfs_vnops.c
Log Message:
Use pid_t, not short, for a pid.
Part of PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.279 -r1.280 src/sys/nfs/nfs_vnops.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/sys/rump/librump/rumpuser
Date: Tue, 14 Jul 2009 21:00:53 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 21:00:53 UTC 2009
Modified Files:
src/sys/rump/librump/rumpuser: rumpuser_pth.c
Log Message:
Mark rumpuser_thread_exit() as __dead, to match its prototype.
Part of PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/sys/rump/librump/rumpuser/rumpuser_pth.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/usr.bin/mixerctl
Date: Tue, 14 Jul 2009 21:02:24 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 21:02:24 UTC 2009
Modified Files:
src/usr.bin/mixerctl: mixerctl.c
Log Message:
Compare strings with strcmp(), not ==.
Part of PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.23 -r1.24 src/usr.bin/mixerctl/mixerctl.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/usr.bin/rdist
Date: Tue, 14 Jul 2009 21:05:35 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 21:05:35 UTC 2009
Modified Files:
src/usr.bin/rdist: expand.c
Log Message:
Delete unused static smatch() function.
Inspired by PR 41255 from Kurt Lidl (which used #if 0 instead of
deleting the function).
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 src/usr.bin/rdist/expand.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/usr.bin/systat
Date: Tue, 14 Jul 2009 21:08:31 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 21:08:31 UTC 2009
Modified Files:
src/usr.bin/systat: main.c
Log Message:
Don't assume that two identical-looking string literals will have the
same address and will therefore be comparable with the == operator.
Instead, use a const variable.
Inspired by PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.43 -r1.44 src/usr.bin/systat/main.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/sys/fs/hfs
Date: Tue, 14 Jul 2009 21:12:18 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 21:12:18 UTC 2009
Modified Files:
src/sys/fs/hfs: libhfs.c
Log Message:
Initialise the "fork" local variable in hfslib_get_file_extents().
This variable was not actually used uninitialised, but some compilers
(e.g. gcc-4.3.3) warned that the variable might be used uninitialised.
Inspired by PR 41255 from Kurt Lidl.
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/sys/fs/hfs/libhfs.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: apb@NetBSD.org
State-Changed-When: Tue, 14 Jul 2009 21:21:32 +0000
State-Changed-Why:
I think I have applied all your patches, with or without changes,
except for those which you identified as belonging to another PR, and
the change to tests/Makefile which is not part of the same issue.
Please let us know whether the PR can be closed.
From: Alan Barrett <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/41255 CVS commit: src/usr.bin/mail
Date: Tue, 14 Jul 2009 21:15:48 +0000
Module Name: src
Committed By: apb
Date: Tue Jul 14 21:15:48 UTC 2009
Modified Files:
src/usr.bin/mail: lex.c
Log Message:
Declare "com" as volatile in execute(), to make it safe to use
across setjmp/longjmp.
Inspired by PR 41255 from Kurt Lidl, but this change makes "com" a
volatile pointer to const non-volatile data, whereas the PR made it a
non-volatile pointer to const volatile data.
To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/usr.bin/mail/lex.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Kurt J. Lidl" <lidl@pix.net>
To: gnats-bugs@NetBSD.org
Cc: misc-bug-people@NetBSD.org, netbsd-bugs@NetBSD.org, gnats-admin@NetBSD.org,
apb@NetBSD.org
Subject: Re: misc/41255 (gcc 4.3.3 won't compile some of the source tree)
Date: Tue, 14 Jul 2009 23:16:53 -0400
On Tue, Jul 14, 2009 at 09:21:33PM +0000, apb@NetBSD.org wrote:
> Synopsis: gcc 4.3.3 won't compile some of the source tree
>
> State-Changed-From-To: open->feedback
> State-Changed-By: apb@NetBSD.org
> State-Changed-When: Tue, 14 Jul 2009 21:21:32 +0000
> State-Changed-Why:
> I think I have applied all your patches, with or without changes,
> except for those which you identified as belonging to another PR, and
> the change to tests/Makefile which is not part of the same issue.
> Please let us know whether the PR can be closed.
After reviewing the changes you made, I think this resolves
all the issues that I reported.
Please close this PR.
Thanks!
-Kurt
State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Wed, 15 Jul 2009 06:50:28 +0000
State-Changed-Why:
Patches applied -- thanks! :-)
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home