NetBSD Problem Report #41291

From cheusov@tut.by  Mon Apr 27 16:49:36 2009
Return-Path: <cheusov@tut.by>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 200EE63C166
	for <gnats-bugs@gnats.netbsd.org>; Mon, 27 Apr 2009 16:49:36 +0000 (UTC)
Message-Id: <s93skjuf69f.fsf@chen.chizhovka.net>
Date: Mon, 27 Apr 2009 18:47:24 +0300
From: cheusov@tut.by
Reply-To:
To: gnats-bugs@gnats.NetBSD.org
Subject: Update for news/leafnode broken under NetBSD-5
X-Send-Pr-Version: 3.95

>Number:         41291
>Category:       pkg
>Synopsis:       Update for news/leafnode broken under NetBSD-5
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 27 16:50:00 +0000 2009
>Closed-Date:    Wed Apr 29 10:54:25 +0000 2009
>Last-Modified:  Wed Apr 29 10:55:01 +0000 2009
>Originator:     cheusov@tut.by
>Release:        NetBSD 5.0_RC4
>Organization:
>Environment:
System: NetBSD chen.chizhovka.net 5.0_RC4 NetBSD 5.0_RC4 (GENERIC) #4: Mon Apr 20 21:38:46 EEST 2009 cheusov@chen.chizhovka.net:/srv/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
Because of changes in ioctl(SIOCGIFADDR) in NetBSD-5 news/leafnode
package shipped with pkgsrc becomes broken.

Details about the problem are available here
http://mail-index.netbsd.org/tech-userlevel/2009/03/21/msg001898.html

Upstream was notified about the problem, fixed the problem and
released new leafnode-1.11.7

Notes about the patch.
patches/patch-aa was regenerated because old one is not applied cleanly.
patches/patch-ab was removed because it is not needed anymore
(upstream is correct).

>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/news/leafnode/Makefile,v
retrieving revision 1.40
diff -u -r1.40 Makefile
--- Makefile	25 Oct 2008 13:19:10 -0000	1.40
+++ Makefile	27 Apr 2009 16:40:32 -0000
@@ -1,8 +1,6 @@
 # $NetBSD: Makefile,v 1.40 2008/10/25 13:19:10 obache Exp $

-DISTNAME=		leafnode-1.11.3.rel
-PKGNAME=		${DISTNAME:S/.rel//}
-PKGREVISION=		1
+DISTNAME=		leafnode-1.11.7
 CATEGORIES=		news
 MASTER_SITES=		${MASTER_SITE_SOURCEFORGE:=leafnode/}
 EXTRACT_SUFX=		.tar.bz2
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/news/leafnode/distinfo,v
retrieving revision 1.16
diff -u -r1.16 distinfo
--- distinfo	15 Oct 2006 20:06:59 -0000	1.16
+++ distinfo	27 Apr 2009 16:40:32 -0000
@@ -1,7 +1,6 @@
 $NetBSD: distinfo,v 1.16 2006/10/15 20:06:59 schwarz Exp $

-SHA1 (leafnode-1.11.3.rel.tar.bz2) = 6910f05c0fa4b1bb5a4baaa6e6fd529fef5ece22
-RMD160 (leafnode-1.11.3.rel.tar.bz2) = 786fc42b58660d8d47eccd5d610718202eb50a3c
-Size (leafnode-1.11.3.rel.tar.bz2) = 506217 bytes
-SHA1 (patch-aa) = 6820ab420cb656e61848f9eb29d4674bccb856a6
-SHA1 (patch-ab) = 02f0911d41bf7934d44306054edb77b1d1751045
+SHA1 (leafnode-1.11.7.tar.bz2) = 81b85be012f1c3d2613e9f9c078336bdd238a052
+RMD160 (leafnode-1.11.7.tar.bz2) = 666623ef121aa625337e83512ca7569cc745a5d9
+Size (leafnode-1.11.7.tar.bz2) = 494740 bytes
+SHA1 (patch-aa) = bfcc59e28a8c60058f9f5289c02a0dbc8269bbfd
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/news/leafnode/patches/patch-aa,v
retrieving revision 1.6
diff -u -r1.6 patch-aa
--- patches/patch-aa	13 May 2005 15:08:04 -0000	1.6
+++ patches/patch-aa	27 Apr 2009 16:40:32 -0000
@@ -1,13 +1,13 @@
 $NetBSD: patch-aa,v 1.6 2005/05/13 15:08:04 kim Exp $

---- Makefile.in.orig	2005-05-04 10:36:22.000000000 -0400
-+++ Makefile.in	2005-05-13 10:53:41.000000000 -0400
-@@ -801,14 +801,14 @@
+--- Makefile.in.orig	2009-04-20 17:37:40.000000000 +0300
++++ Makefile.in
+@@ -846,14 +846,14 @@ uninstall-man8:
  	  rm -f "$(DESTDIR)$(man8dir)/$$inst"; \
  	done
  install-sysconfDATA: $(sysconf_DATA)
 -	@$(NORMAL_INSTALL)
--	test -z "$(sysconfdir)" || $(mkdir_p) "$(DESTDIR)$(sysconfdir)"
+-	test -z "$(sysconfdir)" || $(MKDIR_P) "$(DESTDIR)$(sysconfdir)"
 -	@list='$(sysconf_DATA)'; for p in $$list; do \
 -	  if test -f "$$p"; then d=; else d="$(srcdir)/"; fi; \
 -	  f=$(am__strip_dir) \
@@ -15,7 +15,7 @@
 -	  $(sysconfDATA_INSTALL) "$$d$$p" "$(DESTDIR)$(sysconfdir)/$$f"; \
 -	done
 +#	@$(NORMAL_INSTALL)
-+#	test -z "$(sysconfdir)" || $(mkdir_p) "$(DESTDIR)$(sysconfdir)"
++#	test -z "$(sysconfdir)" || $(MKDIR_P) "$(DESTDIR)$(sysconfdir)"
 +#	@list='$(sysconf_DATA)'; for p in $$list; do \
 +#	  if test -f "$$p"; then d=; else d="$(srcdir)/"; fi; \
 +#	  f=$(am__strip_dir) \
@@ -25,13 +25,13 @@

  uninstall-sysconfDATA:
  	@$(NORMAL_UNINSTALL)
-@@ -1349,17 +1349,17 @@
+@@ -1417,17 +1417,17 @@ rpm:	leafnode.spec
  	rpmbuild -ba leafnode.spec || rpm -ba leafnode.spec

  install-data-hook: amiroot
--	set -e ; for i in . leaf.node failed.postings interesting.groups \
--		out.going message.id temp.files ; do \
--        mkdir -p $(DESTDIR)$(SPOOLDIR)/$$i ; \
+-	set -e ; for i in "" /leaf.node /failed.postings /interesting.groups \
+-		/out.going /message.id /temp.files ; do \
+-        mkdir -p $(DESTDIR)$(SPOOLDIR)$$i ; \
 -	if ./amiroot ; then \
 -	 chown @NEWS_USER@:@NEWS_GROUP@ $(DESTDIR)$(SPOOLDIR)/$$i ; \
 -	 chmod 2775      $(DESTDIR)$(SPOOLDIR)/$$i ; fi ; \
@@ -40,9 +40,9 @@
 -	if ./amiroot ; then \
 -          chown @NEWS_USER@:@NEWS_GROUP@ "$${d}" ; \
 -	  chmod 2775 "$${d}" ; fi
-+#	set -e ; for i in . leaf.node failed.postings interesting.groups \
-+#		out.going message.id temp.files ; do \
-+#        mkdir -p $(DESTDIR)$(SPOOLDIR)/$$i ; \
++#	set -e ; for i in "" /leaf.node /failed.postings /interesting.groups \
++#		/out.going /message.id /temp.files ; do \
++#        mkdir -p $(DESTDIR)$(SPOOLDIR)$$i ; \
 +#	if ./amiroot ; then \
 +#	 chown @NEWS_USER@:@NEWS_GROUP@ $(DESTDIR)$(SPOOLDIR)/$$i ; \
 +#	 chmod 2775      $(DESTDIR)$(SPOOLDIR)/$$i ; fi ; \
Index: patches/patch-ab
===================================================================
RCS file: patches/patch-ab
diff -N patches/patch-ab
--- patches/patch-ab	15 Oct 2006 20:06:59 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,13 +0,0 @@
-$NetBSD: patch-ab,v 1.1 2006/10/15 20:06:59 schwarz Exp $
-
---- mastring.h.orig	2006-10-15 21:51:05.000000000 +0200
-+++ mastring.h	2006-10-15 21:51:19.000000000 +0200
-@@ -38,7 +38,7 @@
- /*@only@*/ mastr *mastr_new(size_t);
- /*@only@*/ mastr *mastr_newstr(const char *);
- int mastr_cpy(mastr *, const char *);
--int mastr_cat(mastr *, /*@unique@*/ /*@observer@*/ const char *);
-+int mastr_cat(mastr *, /*@unique@*/ /*@observer@*/ const char *const);
- int mastr_vcat(mastr *, ...);
- int mastr_resizekeep(mastr *, size_t);
- int mastr_resizekill(mastr *, size_t);

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 29 Apr 2009 10:54:25 +0000
State-Changed-Why:
Committed, thank you!


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41291 CVS commit: pkgsrc/news/leafnode
Date: Wed, 29 Apr 2009 10:54:11 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Wed Apr 29 10:54:11 UTC 2009

 Modified Files:
 	pkgsrc/news/leafnode: Makefile distinfo
 	pkgsrc/news/leafnode/patches: patch-aa
 Removed Files:
 	pkgsrc/news/leafnode/patches: patch-ab

 Log Message:
 Update to 1.11.7, provided by Aleksey Cheusov in PR 41291.

 * 1.11.7, 2009-04-20

 ### WORKAROUND
 - fetchnews: If the LN_SUPPRESS_DATE environment variable is defined and set
   to any value or empty, fetchnews will not test the upstream server's time by
   means of the "DATE" NNTP command.
   This can be used to quench related log messages.

 ### BUGFIXES
 - Fix logging if texpire unlinks files without further hardlinks from
   message.id/NNN/
 - Fix potential segfault on libcs that do not catch NULL for %s formatting
   (several GNU libc versions do) when trying to retrieve delayed bodies from
   corrupt article headers. Pretend success, to purge article number from
   subscription file.  Bug reported by Chris Carr.
 - Fix & change "noactive" so that it can be overridden by "fetchnews -f", as
   documented in config.example.
   Regression as side effect of 1.9.50 fix, reported by Jesse F. Hughes.
 - Fix logged IP address in "connected to..., reply:" message when compiled
   without IPv6 support.
   Fixes Mandriva Bug #45605, reported by David W. Hodgins.
 - Print connected to... to console as well at proper verbosity level, found
   by maintainer while debugging aforementioned bug.
 - Only emit warning that no server with posting permission was found if that's
   actually needed. Reported by Christian Weiske.
 - If corrupted articles had been detected, fetchnews -x NNN would not be able
   to re-fetch the said article because a 0-sized file remained in message.id,
   making fetchnews believe the article was in the spool.
   0-sized message.id/NNN/ files are now purged when checking if the article is
   already in the spool.
   Reported by Peter Bauernfeind. (de.comm.software.newsserver post, May 2008)
 - Change interface enumeration to track incompatible NetBSD 5 changes.  The
   latter led to bogus connection refusals in NNTPD.  SourceForge Bug #2700756,
   by Aleksey Cheusov, fix suggested by Roy Marples.
 - Add support for SIOCGIFALIAS where available (BSD) in order to obtain
   netmasks for 4.4BSD-style IP aliases.
   getifaddrs() has been suggested as well, but it isn't available everywhere,
   so we would have to keep the old code around anyways, and we can just fix
   that rather than introduce alternative code branches.

 ### BUGFIXES BACKPORTED FROM LEAFNODE 2
 - lsort (used by make update) now detects and report errors.
 - "make update" handles the lockfile properly now: it records its PID and
   removes the lock also in cases of failure.
 - "make update" restores the old groupinfo file if lsort fails.
 - "make update" now builds an up-to-date lsort first.
 - "make update" now uses the configured NEWS_USER and _GROUP.
 - "make update" is now a phony Makefile target, i. e. it will work even
   if there is a file "update" in the build directory.

 ### CHANGES
 - When creating a Path: header (because the newsreader did not do that), use
   "not-for-mail" instead of NEWS_USER (usually "news") as the user component.
   This seems to resolve propagation issues with 2nd-hop-upstreams, as reported
   in Debian Bug#459980 by Michael Weitzel, with Universit
 - When writing to client fails, log decoded errno, too.
   This can help debugging certain firewall misconfigurations more easily.
 - Undoing a wordwrap in configure.ac allows for bootstrapping on Cygwin.
 - Drop obsolete mysetvbuf().
 - leafnode-version now supports an additional "-v" mode to print more
   information on the installation. The output then is similar, but not
   identical - due to different feature sets - to the way leafnode-2 prints it.

 ### DOCUMENTATION
 - Add some comments to UNINSTALL-daemontools
 - Put README-FQDN* under leafnode's license. Found to be in conflict with
   Debian's DFSG by Mark Brown.

 ==============================================================================
 * 1.11.6, 2007-03-17

 ### BUGFIXES
 - .site TLDs are refused in FQDN.
 - apply patch from Georg Schwarz to fix compilation with SGI IDO cc.
 - do not delete articles if the References: lines are malformatted.
   Reported by Adam Funk.
 - support autoconf 2.60, fixing datarootdir-related warnings.
 - do not log authentication success unless in verbose mode.

 ### DOCUMENTATION
 - fix minor typos in README-FQDN.
 - minor changes to INSTALL.

 ==============================================================================
 * 1.11.5, 2006-04-09

 ### BUGFIXES
 - Fix logging of invalid FQDH/FQDN.
 - Do not trash delaybody download markers if the interesting.group/* files
   are writeable by NEWS_USER ("news") but owned by somebody else. Found
   debugging a problem described by David Aldred.
 - Some syslog messages were still logged at LOG_DEBUG priority without
   debugmode set.
 - Support noactive = 0. Reported by Rafal Maj, Debian Bug #329760.
 - Support nodesc = 0.
 - Keep non-expiring groups (negative groupexpire date) in active file even if
   they have expired upstream. Sourceforge Bug #1230256, Thomas Zajic.
 - INSTALL: leafnode needs a "news" group as well. Found by Julien Sansonnens.
 - Allow unterminated lines in regular files. Found by Ivo Maintz.
 - Applyfilter unfolds headers before matching, to match fetchnews behavior.
 - Applyfilter no longer unconditionally removes messages without body
   if delaybody is off. The interesting.groups/group.name file might still
   have pointers so that fetchnews will download the bodies later.

 ### CHANGES
 - "killed nnn (<mess@ge.id>), already fetched before" messages have been
   demoted to debug priority, to avoid syslog spamming with multiple upstream
   servers or after crashes.  Reported by Adam Funk.
 - The RPM is now accompanied by a -debuginfo package.
 - Build "grouplist" program in "make check".
 - The fetchnews manual page states that -f is not to be used in cron jobs.
 - The filtering documentation (applyfilter(8) man page and filters.example)
   was overhauled, at the suggestion of Michael R. McCarrey.
   Mike also courteously provided additional filter examples with documentation.

 ### WEBSITE
 - http://www.leafnode.org/ is now served by SourceForge's VHOST service and
   thus serves the same content as http://leafnode.sourceforge.net/

 ==============================================================================
 * 1.11.4, 2005-11-23

 ### BUGFIXES
 - Skip server processing when posting articles fails, for instance,
   because of a protocol error or server disconnect/timeout.
   Bug found when analyzing Debian #318644.
 - Do not mark the active for refetch when the failed server has "noread" set
   or fetchnews is in -P (post only) mode. Patch by Brian Sammon.

 ### COMPATIBILITY CHANGE
 - GNU coreutils 5.92 are broken and can no longer create a missing directory
   with "mkdir -p missing/." Work around the bug. Reported by Michael Shigorin.

 ### DOCUMENTATION
 - Switch FAQ.pdf formatting back to XSL stylesheets and RenderX XEP 4.4,
   now that a personal license for OpenSource documentation is available.
 - Renamed all CAN-YYYY-NNNN to CVE-YYYY-NNNN in leafnode-SA-*.txt, ChangeLog,
   NEWS and OLDNEWS to chase the CVE database change of 2005-10-19.


 To generate a diff of this commit:
 cvs rdiff -u -r1.40 -r1.41 pkgsrc/news/leafnode/Makefile
 cvs rdiff -u -r1.16 -r1.17 pkgsrc/news/leafnode/distinfo
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/news/leafnode/patches/patch-aa
 cvs rdiff -u -r1.1 -r0 pkgsrc/news/leafnode/patches/patch-ab

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.