NetBSD Problem Report #41422

From www@NetBSD.org  Wed May 13 07:35:38 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 090E863B946
	for <gnats-bugs@gnats.netbsd.org>; Wed, 13 May 2009 07:35:38 +0000 (UTC)
Message-Id: <20090513073536.305A063B8DF@www.NetBSD.org>
Date: Wed, 13 May 2009 07:35:36 +0000 (UTC)
From: cheusov@tut.by
Reply-To: cheusov@tut.by
To: gnats-bugs@NetBSD.org
Subject: 'make depends DEPENDS=do-bin-install' vs. 'pkg_add -A'
X-Send-Pr-Version: www-1.0

>Number:         41422
>Category:       pkg
>Synopsis:       'make depends DEPENDS=do-bin-install' vs. 'pkg_add -A'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 13 07:40:00 +0000 2009
>Closed-Date:    
>Last-Modified:  Tue May 26 11:59:05 +0000 2009
>Originator:     Aleksey Cheusov
>Release:        linux
>Organization:
home
>Environment:
linux
>Description:
The following command
   make depends DEPENDS=do-bin-install
do not set "installed as a dependency" flag to the installed packages.
This is because -A flag is not passed to the underlying 'pkg_add'.

I think the following patch should be applied but it alone doesn't solve the problem.

>How-To-Repeat:

>Fix:
Index: mk/bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.1956
diff -u -r1.1956 bsd.pkg.mk
--- mk/bsd.pkg.mk       9 Apr 2009 00:51:23 -0000       1.1956
+++ mk/bsd.pkg.mk       13 May 2009 07:29:04 -0000
@@ -651,7 +651,7 @@
 PKG_ARGS_ADD=          -W ${LOCALBASE} -w ${DEFAULT_VIEW}
 .endif
 _BIN_INSTALL_FLAGS=    ${BIN_INSTALL_FLAGS}
-.if defined(_AUTOMATIC) && !empty(_AUTOMATIC:MYES)
+.if defined(_AUTOMATIC) && !empty(_AUTOMATIC:M[Yy][Ee][Ss])
 _BIN_INSTALL_FLAGS+=   -A
 .endif
 _BIN_INSTALL_FLAGS+=   ${PKG_ARGS_ADD}

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: cheusov@tut.by
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/41422: 'make depends DEPENDS=do-bin-install' vs. 'pkg_add
	-A'
Date: Wed, 13 May 2009 10:44:53 +0200

 On Wed, May 13, 2009 at 07:40:00AM +0000, cheusov@tut.by wrote:
 >    make depends DEPENDS=do-bin-install

 Is that a typo?
 You should use "bin-install", not "do-bin-install"
  Thomas

From: Aleksey Cheusov <cheusov@tut.by>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/41422: 'make depends DEPENDS=do-bin-install' vs. 'pkg_add -A'
Date: Wed, 13 May 2009 13:35:13 +0300

 > The following reply was made to PR pkg/41422; it has been noted by GNATS.

 > From: Thomas Klausner <wiz@NetBSD.org>
 > To: cheusov@tut.by
 > Cc: gnats-bugs@NetBSD.org
 > Subject: Re: pkg/41422: 'make depends DEPENDS=do-bin-install' vs. 'pkg_add
 > 	-A'
 > Date: Wed, 13 May 2009 10:44:53 +0200

 >  On Wed, May 13, 2009 at 07:40:00AM +0000, cheusov@tut.by wrote:
  >>    make depends DEPENDS=do-bin-install
 >  
 >  Is that a typo?
 >  You should use "bin-install", not "do-bin-install"
 >   Thomas

 Yes. s/DEPENDS/DEPENDS_TARGET/ :-)
 About do-bin-install. Yes, I use it and want to see it declared as
 public. Anyway, bin-install doesn't work too.

 -- 
 Best regards, Aleksey Cheusov.

State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Tue, 26 May 2009 06:03:59 +0000
State-Changed-Why:
Patch applied.  Thanks!


From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41422 CVS commit: pkgsrc/mk
Date: Tue, 26 May 2009 06:03:02 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Tue May 26 06:03:02 UTC 2009

 Modified Files:
 	pkgsrc/mk: bsd.pkg.mk

 Log Message:
 Accept _AUTOMATIC=yes.
 At least, set as "yes" in mk/flavor/pkg/depends.mk,
 and accept both "YES" and "yes" in flavor/pkg/install.mk.

 Fixes PR 41422.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1956 -r1.1957 pkgsrc/mk/bsd.pkg.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Aleksey Cheusov <cheusov@tut.by>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org,
	 obache@NetBSD.org
Subject: Re: pkg/41422 ('make depends DEPENDS=do-bin-install' vs. 'pkg_add -A')
Date: Tue, 26 May 2009 13:36:40 +0300

 > State-Changed-From-To: open->closed
 > Patch applied.  Thanks!
 The applied patch alone doesn't solve the problem. Please reopen PR.

 -- 
 Best regards, Aleksey Cheusov.

State-Changed-From-To: closed->open
State-Changed-By: obache@NetBSD.org
State-Changed-When: Tue, 26 May 2009 11:59:05 +0000
State-Changed-Why:
The problem is not solved completely.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.