NetBSD Problem Report #41781

From bad@bsd.de  Sat Jul 25 15:45:39 2009
Return-Path: <bad@bsd.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 7E7D563B863
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 25 Jul 2009 15:45:39 +0000 (UTC)
Message-Id: <20090725154534.3F6A6122A3@sanctioned-parts-list.k.bsd.de>
Date: Sat, 25 Jul 2009 15:45:34 +0000 (UTC)
From: bad@bsd.de
Reply-To: bad@bsd.de
To: gnats-bugs@gnats.NetBSD.org
Subject: vi regex regression matching dollar signs
X-Send-Pr-Version: 3.95

>Number:         41781
>Category:       bin
>Synopsis:       the pattern /\$/ doesn't match a dollar sign anymore by default
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 25 15:50:00 +0000 2009
>Closed-Date:    Sun Nov 15 05:29:45 +0000 2009
>Last-Modified:  Sun Nov 15 05:29:45 +0000 2009
>Originator:     Christoph Badura
>Release:        NetBSD 5.0_STABLE
>Organization:
netbsd bozotic software test labs

>Environment:


System: NetBSD sanctioned-parts-list 5.0_STABLE NetBSD 5.0_STABLE (pe1400) #0: Sun Jul 12 17:58:26 UTC 2009 bad@arbitrary:/m/src/sys/arch/i386/compile/pe1400 i386
Architecture: i386
Machine: i386
>Description:

The new vi in NetBSD 5 does not allow to match a literal $ by default.
This used to work until e.g. NetBSD 3.x.

mrg@ provided the hint that the behaviour changes with setting "extended"
mode for regular expressions on.

However, the NetBSD 3.x vi does allow escaping a dollar sign with a backslash
and matching a literal dollar sign with either setting of "extended".

>How-To-Repeat:

$ cat >zorch <<\ETX
a
b\$c
d
ETX
$ env EXINIT=":se noext" vi -c ':/\\\$/p' zorch
$ env EXINIT=":se ext" vi -c ':/\\\$/p' zorch

>Fix:
unknown


>Release-Note:

>Audit-Trail:
From: Takehiko NOZAKI <takehiko.nozaki@gmail.com>
To: gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: bin/41781: vi regex regression matching dollar signs
Date: Sun, 26 Jul 2009 13:04:22 +0900

 --0016364ef3c8bfd065046f93ee99
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit

 hi,

 please try attached patch, i'll commit it 2 or 3 day later.
 (i'm now away from my ssh key), sorry for your inconvinience.

 very truly yours.
 -- 
 Takehiko NOZAKI<takehiko.nozaki@gmail.com>

 --0016364ef3c8bfd065046f93ee99
 Content-Type: application/octet-stream; name=patch-nvi
 Content-Disposition: attachment; filename=patch-nvi
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_fxl8thm60

 SW5kZXg6IHJlZ2V4L3JlZ2NvbXAuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zzcm9vdC9zcmMv
 ZGlzdC9udmkvcmVnZXgvcmVnY29tcC5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQKZGlmZiAt
 dSAtcjEuNCByZWdjb21wLmMKLS0tIHJlZ2V4L3JlZ2NvbXAuYwkxOCBKYW4gMjAwOSAwMzo0NTo1
 MCAtMDAwMAkxLjQKKysrIHJlZ2V4L3JlZ2NvbXAuYwkyNiBKdWwgMjAwOSAwMzo1ODo1NCAtMDAw
 MApAQCAtNTQ5LDEyICs1NDksMTQgQEAKIAlyZWdpc3RlciBzb3BubyBwb3M7CiAJcmVnaXN0ZXIg
 aW50IGk7CiAJcmVnaXN0ZXIgc29wbm8gc3Vibm87CisJaW50IGJhY2tzbDsKIAogCXBvcyA9IEhF
 UkUoKTsJCS8qIHJlcGV0aW9uIG9wLCBpZiBhbnksIGNvdmVycyBmcm9tIGhlcmUgKi8KIAogCWFz
 c2VydChNT1JFKCkpOwkJLyogY2FsbGVyIHNob3VsZCBoYXZlIGVuc3VyZWQgdGhpcyAqLwogCWMg
 PSBHRVRORVhUKCk7Ci0JaWYgKGMgPT0gJ1xcJykgeworCWJhY2tzbCA9IGMgPT0gJ1xcJzsKKwlp
 ZiAoYmFja3NsKSB7CiAJCSh2b2lkKVJFUVVJUkUoTU9SRSgpLCBSRUdfRUVTQ0FQRSk7CiAJCWMg
 PSAodW5zaWduZWQgY2hhcilHRVRORVhUKCk7CiAJCXN3aXRjaCAoYykgewpAQCAtNjUxLDcgKzY1
 Myw3IEBACiAJCQkodm9pZClSRVFVSVJFKE1PUkUoKSwgUkVHX0VCUkFDRSk7CiAJCQlTRVRFUlJP
 UihSRUdfQkFEQlIpOwogCQl9Ci0JfSBlbHNlIGlmIChjID09ICh1bnNpZ25lZCBjaGFyKSckJykJ
 LyogJCAoYnV0IG5vdCBcJCkgZW5kcyBpdCAqLworCX0gZWxzZSBpZiAoIWJhY2tzbCAmJiBjID09
 ICh1bnNpZ25lZCBjaGFyKSckJykJLyogJCAoYnV0IG5vdCBcJCkgZW5kcyBpdCAqLwogCQlyZXR1
 cm4oMSk7CiAKIAlyZXR1cm4oMCk7Cg==
 --0016364ef3c8bfd065046f93ee99--

From: Christoph Badura <bad@bsd.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/41781: vi regex regression matching dollar signs
Date: Sun, 26 Jul 2009 15:33:41 +0200

 On Sun, Jul 26, 2009 at 04:05:03AM +0000, Takehiko NOZAKI wrote:
 >  please try attached patch, i'll commit it 2 or 3 day later.
 >  (i'm now away from my ssh key), sorry for your inconvinience.

 Works for me.

 Thank you very much.
 --chris

State-Changed-From-To: open->pending-pullups
State-Changed-By: tnozaki@NetBSD.org
State-Changed-When: Sun, 30 Aug 2009 15:15:26 +0000
State-Changed-Why:
patch submitted, thanks!

State-Changed-From-To: pending-pullups->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Nov 2009 05:29:45 +0000
State-Changed-Why:
This fix has been pulled up.


>Unformatted:
 NetBSD 5.0_STABLE as of 2009-07-02

Home	PR Database Search