NetBSD Problem Report #41790

From www@NetBSD.org  Mon Jul 27 13:25:23 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 2918863B9B8
	for <gnats-bugs@gnats.netbsd.org>; Mon, 27 Jul 2009 13:25:23 +0000 (UTC)
Message-Id: <20090727132522.DBE2D63B8E9@www.NetBSD.org>
Date: Mon, 27 Jul 2009 13:25:22 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: mail/mutt-devel does not compile on NetBSD 4.0.1
X-Send-Pr-Version: www-1.0

>Number:         41790
>Category:       pkg
>Synopsis:       mail/mutt-devel does not compile on NetBSD 4.0.1
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tonnerre
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 27 13:30:00 +0000 2009
>Closed-Date:    Sat Nov 02 18:36:42 +0000 2013
>Last-Modified:  Sat Nov 02 18:36:42 +0000 2013
>Originator:     Jörn Clausen
>Release:        4.0.1
>Organization:
University of Bielefeld
>Environment:
NetBSD hrzkpgsrc 4.0.1 NetBSD 4.0.1 (GENERIC) #0: Tue Oct  7 22:58:48 PDT 2008  builds@wb30:/home/builds/ab/netbsd-4-0-1-RELEASE/i386/200810080053Z-obj/home/builds/ab/netbsd-4-0-1-RELEASE/src/sys/arch/i386/compile/GENERIC i386

>Description:
mail/mutt-devel fails on NetBSD 4.0.1 with

cc -DPKGDATADIR=\"/usr/pkg/share/mutt\" -DSYSCONFDIR=\"/usr/pkg/etc\"  -DBINDIR=\"/usr/pkg/bin\" -DMUTTLOCALEDIR=\"/usr/pkg/share/locale\"  -DHAVE_CONFIG_H=1 -I.  -I. -I. -I./imap  -Iintl  -I/usr/include -I/usr/include -I./intl  -Wall -pedantic -Wno-long-long -O2 -I/usr/include -MT mvchgat.o -MD -MP -MF .deps/mvchgat.Tpo -c -o mvchgat.o mvchgat.c
mvchgat.c:17: error: expected ')' before '*' token
mvchgat.c:27: error: expected declaration specifiers or '...' before 'attr_t'
mvchgat.c: In function 'mvchgat':
mvchgat.c:30: warning: implicit declaration of function 'mvwchgat'
mvchgat.c:30: error: 'stdscr' undeclared (first use in this function)
mvchgat.c:30: error: (Each undeclared identifier is reported only once
mvchgat.c:30: error: for each function it appears in.)
mvchgat.c:30: error: 'attr' undeclared (first use in this function)
*** Error code 1


It seems, patches/patch-aq is the source of this problem. I don't see HAVE_MVWCHGAT mentioned (let alone defined) anywhere.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->tonnerre
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Mon, 27 Jul 2009 23:32:21 +0000
Responsible-Changed-Why:
tonnerre@ added the patch.


From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/41790
Date: Wed, 05 Aug 2009 10:30:28 +0200

 This is the corresponding error on OpenSolaris:

 gcc -DPKGDATADIR=\"/opt/pkg/share/mutt\" -DSYSCONFDIR=\"/opt/pkg/etc\" 
 -DBINDIR=\"/opt/pkg/bin\" -DMUTTLOCALEDIR=\"/opt/pkg/lib/locale\" 
 -DHAVE_CONFIG_H=1 -I.  -I. -I. -I./imap  -Iintl  -I/usr/include 
 -I/opt/pkg/include -I/opt/pkg/gcc34/include 
 -I/opt/pkg/gcc34/lib/gcc/i386-pc-solaris2.11/3.4.6/include 
 -I/opt/pkg/include -I/opt/pkg/include -I./intl  -Wall -pedantic 
 -Wno-long-long -O -I/usr/include -I/opt/pkg/include 
 -I/opt/pkg/gcc34/include 
 -I/opt/pkg/gcc34/lib/gcc/i386-pc-solaris2.11/3.4.6/include -MT mvchgat.o 
 -MD -MP -MF .deps/mvchgat.Tpo -c -o mvchgat.o mvchgat.c
 mvchgat.c:17: error: syntax error before '*' token
 mvchgat.c: In function `mvwchgat':
 mvchgat.c:20: warning: implicit declaration of function `wmove'
 mvchgat.c:20: error: `win' undeclared (first use in this function)
 mvchgat.c:20: error: (Each undeclared identifier is reported only once
 mvchgat.c:20: error: for each function it appears in.)
 mvchgat.c:20: error: `y' undeclared (first use in this function)
 mvchgat.c:20: error: `x' undeclared (first use in this function)
 mvchgat.c:21: warning: implicit declaration of function `wattr_set'
 mvchgat.c:21: error: `attr' undeclared (first use in this function)
 mvchgat.c:21: error: `color' undeclared (first use in this function)
 mvchgat.c:21: error: `opts' undeclared (first use in this function)
 mvchgat.c: At top level:
 mvchgat.c:27: error: syntax error before "attr_t"
 mvchgat.c: In function `mvchgat':
 mvchgat.c:30: error: `stdscr' undeclared (first use in this function)
 mvchgat.c:30: error: `y' undeclared (first use in this function)
 mvchgat.c:30: error: `x' undeclared (first use in this function)
 mvchgat.c:30: error: `count' undeclared (first use in this function)
 mvchgat.c:30: error: `attr' undeclared (first use in this function)
 mvchgat.c:30: error: `color' undeclared (first use in this function)
 mvchgat.c:30: error: `opts' undeclared (first use in this function)

 How about removing this patch until it has been tested more thoroughly?

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

From: Tonnerre LOMBARD <tonnerre@netbsd.ch>
To: gnats-bugs@NetBSD.org
Cc: tonnerre@NetBSD.org, pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org,
	gnats-admin@netbsd.org, obache@NetBSD.org,
	joern.clausen@uni-bielefeld.de
Subject: Re: pkg/41790 (mail/mutt-devel does not compile on NetBSD 4.0.1)
Date: Sun, 9 Aug 2009 14:41:23 +0200

 Salut,

 As far as I can tell, this was resolved very recently?

 			Tonnerre

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joernc@googlemail.com>
To: Tonnerre LOMBARD <tonnerre@netbsd.ch>
Cc: gnats-bugs@netbsd.org, tonnerre@netbsd.org, pkg-manager@netbsd.org, 
	pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, obache@netbsd.org, 
	joern.clausen@uni-bielefeld.de
Subject: Re: pkg/41790 (mail/mutt-devel does not compile on NetBSD 4.0.1)
Date: Sun, 9 Aug 2009 17:07:03 +0200

 On Sun, Aug 9, 2009 at 2:41 PM, Tonnerre LOMBARD<tonnerre@netbsd.ch> wrote:
 > Salut,
 >
 > As far as I can tell, this was resolved very recently?

 Not that I am aware of. mvchgat.c still does not compile (at least) on
 NetBSD 5.0, 4.0.1, OpenSolaris and Solaris 10. It seems to compile on
 DragonFly. On what OS and with what settings did you test your patch?
 Which curses library is the default there?

 -- 
 Joern Clausen
 http://thebloeg.blogspot.com/
 http://www.oe-files.de/oefiles/

From: Klaus Heinz <k.heinz@augneun.kh-22.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/41790 (mail/mutt-devel does not compile on NetBSD 4.0.1)
Date: Sun, 9 Aug 2009 19:10:06 +0200

 Jörn Clausen wrote:

 > DragonFly. On what OS and with what settings did you test your patch?
 > Which curses library is the default there?

 Fails on NetBSD 3 (I know, not supported any longer) with

   cc -DPKGDATADIR=\"/usr/pkg/share/mutt\" -DSYSCONFDIR=\"/usr/pkg/etc\"
   -DBINDIR=\"/usr/pkg/bin\" -DMUTTLOCALEDIR=\"/usr/pkg/share/locale\"
   -DHAVE_CONFIG_H=1 -I.  -I. -I. -I./imap  -Iintl  -I/usr/include
   -I/usr/include -I./intl  -Wall -pedantic -Wno-long-long -O2
   -I/usr/include -MT mvchgat.o -MD -MP -MF .deps/mvchgat.Tpo -c -o
   mvchgat.o mvchgat.c
   mvchgat.c:17: error: parse error before '*' token
   mvchgat.c: In function `mvwchgat':
   mvchgat.c:20: warning: implicit declaration of function `wmove'
   mvchgat.c:20: error: `win' undeclared (first use in this function)
   mvchgat.c:20: error: (Each undeclared identifier is reported only once
   mvchgat.c:20: error: for each function it appears in.)
   mvchgat.c:20: error: `y' undeclared (first use in this function)
   mvchgat.c:20: error: `x' undeclared (first use in this function)
   mvchgat.c:21: warning: implicit declaration of function `wattr_set'
   mvchgat.c:21: error: `attr' undeclared (first use in this function)
   mvchgat.c:21: error: `color' undeclared (first use in this function)
   mvchgat.c:21: error: `opts' undeclared (first use in this function)
   mvchgat.c: At top level:
   mvchgat.c:27: error: parse error before "attr_t"
   mvchgat.c: In function `mvchgat':
   mvchgat.c:30: error: `stdscr' undeclared (first use in this function)
   mvchgat.c:30: error: `y' undeclared (first use in this function)
   mvchgat.c:30: error: `x' undeclared (first use in this function)
   mvchgat.c:30: error: `count' undeclared (first use in this function)
   mvchgat.c:30: error: `attr' undeclared (first use in this function)
   mvchgat.c:30: error: `color' undeclared (first use in this function)
   mvchgat.c:30: error: `opts' undeclared (first use in this function)
   *** Error code 1

 ciao
      Klaus

From: Tonnerre Lombard <tonnerre@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41790 CVS commit: pkgsrc/mail/mutt-devel
Date: Sun, 9 Aug 2009 20:05:38 +0000

 Module Name:	pkgsrc
 Committed By:	tonnerre
 Date:		Sun Aug  9 20:05:37 UTC 2009

 Modified Files:
 	pkgsrc/mail/mutt-devel: distinfo
 	pkgsrc/mail/mutt-devel/patches: patch-aq

 Log Message:
 Use mutts builtin mutt_curses.h to discover the correct curses header.
 Fixes PR 41790.


 To generate a diff of this commit:
 cvs rdiff -u -r1.60 -r1.61 pkgsrc/mail/mutt-devel/distinfo
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/mail/mutt-devel/patches/patch-aq

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Tonnerre LOMBARD <tonnerre@netbsd.ch>
To: gnats-bugs@NetBSD.org
Cc: tonnerre@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
	joern.clausen@uni-bielefeld.de
Subject: Re: pkg/41790 (mail/mutt-devel does not compile on NetBSD 4.0.1)
Date: Sun, 9 Aug 2009 22:11:45 +0200

 Salut,

 On Sun, Aug 09, 2009 at 03:10:05PM +0000, Jörn Clausen wrote:
 >  On Sun, Aug 9, 2009 at 2:41 PM, Tonnerre LOMBARD<tonnerre@netbsd.ch> wrote:
 >  > As far as I can tell, this was resolved very recently?
 >  
 >  Not that I am aware of. mvchgat.c still does not compile (at least) on
 >  NetBSD 5.0, 4.0.1, OpenSolaris and Solaris 10. It seems to compile on
 >  DragonFly. On what OS and with what settings did you test your patch?
 >  Which curses library is the default there?

 All ncurses versions worked, but no non-n curses header was ever
 included, causing the error. It appears to work now though.

 				Tonnerre

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: tonnerre@NetBSD.org, gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/41790 (mail/mutt-devel does not compile on NetBSD 4.0.1)
Date: Mon, 10 Aug 2009 10:02:21 +0200

 Tonnerre LOMBARD wrote:
 >  All ncurses versions worked, but no non-n curses header was ever
 >  included, causing the error. It appears to work now though.

 mutt-devel now compiles again on NetBSD 4.0.1 (and probably 5.0).

 On Solaris 10 and OpenSolaris I get:

 gcc -DPKGDATADIR=\"/opt/pkg/share/mutt\" -DSYSCONFDIR=\"/opt/pkg/etc\" 
 -DBINDIR=\"/opt/pkg/bin\" -DMUTTLOCALEDIR=\"/opt/pkg/lib/locale\" 
 -DHAVE_CONFIG_H=1 -I.  -I. -I. -I./imap  -Iintl  -I/usr/include 
 -I/opt/pkg/include -I/opt/pkg/gcc34/include 
 -I/opt/pkg/gcc34/lib/gcc/i386-pc-solaris2.11/3.4.6/include 
 -I/opt/pkg/include -I/opt/pkg/include -I./intl  -Wall -pedantic 
 -Wno-long-long -O -I/usr/include -I/opt/pkg/include 
 -I/opt/pkg/gcc34/include 
 -I/opt/pkg/gcc34/lib/gcc/i386-pc-solaris2.11/3.4.6/include -MT mvchgat.o 
 -MD -MP -MF .deps/mvchgat.Tpo -c -o mvchgat.o mvchgat.c
 In file included from 
 /opt/pkgsrc/pkgsrc/mail/mutt-devel/work.solstice/.buildlink/gcc34/lib/gcc/i386-pc-solaris2.11/3.4.6/include/limits.h:11,
                   from mutt.h:35,
                   from mvchgat.c:5:
 /opt/pkgsrc/pkgsrc/mail/mutt-devel/work.solstice/.buildlink/gcc34/lib/gcc/i386-pc-solaris2.11/3.4.6/include/syslimits.h:43: 
 warning: ignoring #pragma ident
 In file included from mutt.h:45,
                   from mvchgat.c:5:
 /opt/pkgsrc/pkgsrc/mail/mutt-devel/work.solstice/.buildlink/gcc34/lib/gcc/i386-pc-solaris2.11/3.4.6/include/wchar.h:39: 
 warning: ignoring #pragma ident
 In file included from mutt_curses.h:52,
                   from mvchgat.c:6:
 /opt/pkgsrc/pkgsrc/mail/mutt-devel/work.solstice/.buildlink/gcc34/lib/gcc/i386-pc-solaris2.11/3.4.6/include/curses.h:52: 
 warning: ignoring #pragma ident
 mvchgat.c:10: error: syntax error before "attr_t"
 mvchgat.c: In function `mvwchgat':
 mvchgat.c:13: error: `win' undeclared (first use in this function)
 mvchgat.c:13: error: (Each undeclared identifier is reported only once
 mvchgat.c:13: error: for each function it appears in.)
 mvchgat.c:13: error: `y' undeclared (first use in this function)
 mvchgat.c:13: error: `x' undeclared (first use in this function)
 mvchgat.c:14: warning: implicit declaration of function `wattr_set'
 mvchgat.c:14: error: `attr' undeclared (first use in this function)
 mvchgat.c:14: error: `color' undeclared (first use in this function)
 mvchgat.c:14: error: `opts' undeclared (first use in this function)
 mvchgat.c: At top level:
 mvchgat.c:20: error: syntax error before "attr_t"
 mvchgat.c: In function `mvchgat':
 mvchgat.c:23: error: `y' undeclared (first use in this function)
 mvchgat.c:23: error: `x' undeclared (first use in this function)
 mvchgat.c:23: error: `count' undeclared (first use in this function)
 mvchgat.c:23: error: `attr' undeclared (first use in this function)
 mvchgat.c:23: error: `color' undeclared (first use in this function)
 mvchgat.c:23: error: `opts' undeclared (first use in this function)
 *** Error code 1

 Requesting ncurses via

 $ env PKG_OPTIONS.mutt='-curses ncurses' bmake

 does not help. No symlinks in work/.buildlink are created, so the native 
 curses implementation is still used. Just checked: When requesting 
 ncurses on NetBSD, the symlinks are created.

 This is also true when selecting slang instead of (n)curses. 
 devel/libslang gets built (wasn't installed yet), but it's not picked up 
 by mutt afterwards. I don't know, maybe this was already broken before 
 your patch.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/41790
Date: Wed, 23 Dec 2009 14:45:56 +0100

 Please revert the patches this PR references.

 I have contacted Tonnerre Lombard in October, but received no reply at 
 all. Vanilla Mutt (i.e. without the patches provided by Tonnerre) 
 compiles on Solaris both with native curses and pkgsrc ncurses, so I 
 simply don't see what his patches try to achieve.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/41790
Date: Sat, 2 Jan 2010 04:23:43 +0000

 On Wed, Dec 23, 2009 at 01:50:03PM +0000, J?rn Clausen wrote:
  >  Please revert the patches this PR references.
  >  
  >  I have contacted Tonnerre Lombard in October, but received no reply at 
  >  all. Vanilla Mutt (i.e. without the patches provided by Tonnerre) 
  >  compiles on Solaris both with native curses and pkgsrc ncurses, so I 
  >  simply don't see what his patches try to achieve.

 According to patch-aq's CVS log it's to fix the build with the sidebar
 patch.

 If mutt doesn't need mvchgat without the sidebar patch, maybe the
 stuff in patch-aq should be suppressed unless it's enabled; that would
 at least punt the problem to people who have some reason to care about
 it.

 -- 
 David A. Holland
 dholland@netbsd.org

From: Sergey Svishchev <svs@ropnet.ru>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/41790
Date: Wed, 23 Mar 2011 03:37:38 +0300

 This is still broken on Solaris 10 with native curses, correct?

 -- 
 Sergey Svishchev

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: Sergey Svishchev <svs@ropnet.ru>, tonnerre@NetBSD.org,
 gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/41790
Date: Mon, 04 Apr 2011 13:19:26 +0200

 >   This is still broken on Solaris 10 with native curses, correct?

 As far as I know, this is still broken on Solaris. Period.

 As this PR dragged on and nobody was willing to actually solve the root 
 cause of the problem, I added local patches to my pkgsrc installation to 
 revert tonnerre's patches. So I could finally compile this package 
 again. That version is built against devel/ncurses.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/41790
Date: Tue, 22 Oct 2013 09:16:49 +0200

 Please close this PR. With the recent changes and the removal of the 
 changes by tonnerre@, mutt-devel compiles out of the box again.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 02 Nov 2013 18:36:42 +0000
State-Changed-Why:
Withdrawn by submitter.


>Unformatted:

Home	PR Database Search