NetBSD Problem Report #41862

From www@NetBSD.org  Sun Aug  9 11:04:47 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id E2A5563C277
	for <gnats-bugs@gnats.netbsd.org>; Sun,  9 Aug 2009 11:04:47 +0000 (UTC)
Message-Id: <20090809110447.A375863C270@www.NetBSD.org>
Date: Sun,  9 Aug 2009 11:04:47 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Misplaced "))" and "{" . 
X-Send-Pr-Version: www-1.0

>Number:         41862
>Category:       kern
>Synopsis:       Misplaced "))" and "{" .
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 09 11:05:00 +0000 2009
>Closed-Date:    Sat Sep 12 18:56:20 +0000 2009
>Last-Modified:  Sat Sep 12 18:56:20 +0000 2009
>Originator:     Henning Petersen
>Release:        current-NetBSD
>Organization:
>Environment:
>Description:
Misplaced "))" , "{" and no need for #else. 
>How-To-Repeat:

>Fix:
diff -u -r1.70 mscp_disk.c
--- sys/dev/mscp/mscp_disk.c	12 May 2009 14:37:59 -0000	1.70
+++ sys/dev/mscp/mscp_disk.c	9 Aug 2009 07:26:37 -0000
@@ -462,9 +462,8 @@
 			if ((error == 0) && (cmd == DIOCWDINFO
 #ifdef __HAVE_OLD_DISKLABEL
 			    || cmd == ODIOCWDINFO
-#else
-			    )) {
 #endif
+			    )) {
 				ra->ra_wlabel = 1;
 				error = writedisklabel(dev, rastrategy, lp,0);
 				ra->ra_wlabel = 0;

>Release-Note:

>Audit-Trail:
From: Izumi Tsutsui <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/41862 CVS commit: src/sys/dev/mscp
Date: Sat, 12 Sep 2009 18:01:50 +0000

 Module Name:	src
 Committed By:	tsutsui
 Date:		Sat Sep 12 18:01:50 UTC 2009

 Modified Files:
 	src/sys/dev/mscp: mscp_disk.c

 Log Message:
 Make this compile on ports with __HAVE_OLD_DISKLABEL
 (though currently no such ports which have mscp).
 Noticed by PR kern/41862.


 To generate a diff of this commit:
 cvs rdiff -u -r1.70 -r1.71 src/sys/dev/mscp/mscp_disk.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sun, 13 Sep 2009 03:56:20 +0900
State-Changed-Why:
fixed.


>Unformatted:

Home	PR Database Search