NetBSD Problem Report #42122
From www@NetBSD.org Thu Sep 24 20:56:43 2009
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id BA8F363B8DF
for <gnats-bugs@gnats.netbsd.org>; Thu, 24 Sep 2009 20:56:43 +0000 (UTC)
Message-Id: <20090924205643.8541C63B850@www.NetBSD.org>
Date: Thu, 24 Sep 2009 20:56:43 +0000 (UTC)
From: gendalia@netbsd.org
Reply-To: gendalia@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: larger than 2TB drives can't be properly found at boot
X-Send-Pr-Version: www-1.0
>Number: 42122
>Category: kern
>Synopsis: larger than 2TB drives can't be properly found at boot
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Sep 24 21:00:00 +0000 2009
>Closed-Date:
>Last-Modified: Wed Dec 11 20:43:21 +0000 2024
>Originator: Tracy Di Marco White
>Release: 5.0.1
>Organization:
>Environment:
NetBSD blackhole 5.0.1 NetBSD 5.0.1 (GENERIC) #0: Thu Jul 30 01:39:11 UTC 2009 builds@b8.netbsd.org:/home/builds/ab/netbsd-5-0-1-RELEASE/i386/200907292356Z-obj/home/builds/ab/netbsd-5-0-1-RELEASE/src/sys/arch/i386/compile/GENERIC i386
>Description:
sd2 at scsibus1 target 0 lun 0: <IFT, A16U-G2430, 348C> disk fixed
sd2: 512, 270286 cyl, 255 head, 0 sec, 512 bytes/sect x 1 sectors
sd2: sync (6.25ns offset 127), 16-bit (320.000MB/s) transfers, tagged queueing
It's an 8TB disk.
>How-To-Repeat:
Attach a large raid array. boot.
>Fix:
>Release-Note:
>Audit-Trail:
From: Tracy Di Marco White <gendalia@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: kern/42122: larger than 2TB drives can't be properly found at
boot
Date: Thu, 24 Sep 2009 18:51:55 -0500
jakllsch says: anyway, my theory on tracy's problem is that the array
firmware reports a 0 for the maximum block in the READ_CAPACITY_10
command output, and thus sd(4) fails to move on to READ_CAPACITY_16
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: kern/42122: larger than 2TB drives can't be properly found at
boot
Date: Thu, 28 Jan 2010 05:18:08 +0000
(wasn't sent to gnats-bugs)
------
From: Michael van Elst <mlelstv@serpens.de>
To: gnats@netbsd.org
Subject: Re: kern/42122: larger than 2TB drives can't be properly found at
boot
Date: Mon, 25 Jan 2010 13:54:06 +0100
The Array should return -1 with read_capacity_10 to signal
that read_capacity_16 is required. Apparently this is not
implemented right. A workaround is to try the read_capacity_16
first and retry with read_capacity_10 if the command wasn't
accepted (Invalid Command).
Does this patch help?
Index: sd.c
===================================================================
RCS file: /cvsroot/src/sys/dev/scsipi/sd.c,v
retrieving revision 1.290
diff -u -r1.290 sd.c
--- sd.c 21 Oct 2009 21:12:05 -0000 1.290
+++ sd.c 25 Jan 2010 11:26:14 -0000
@@ -1679,9 +1679,7 @@
struct scsipi_read_capacity_16_data data16;
} *datap;
uint64_t rv;
-
- memset(&cmd, 0, sizeof(cmd));
- cmd.cmd.opcode = READ_CAPACITY_10;
+ int error;
/*
* Don't allocate data buffer on stack;
@@ -1693,43 +1691,44 @@
if (datap == NULL)
return 0;
- /*
- * If the command works, interpret the result as a 4 byte
- * number of blocks
- */
rv = 0;
- memset(datap, 0, sizeof(datap->data));
- if (scsipi_command(periph, (void *)&cmd.cmd, sizeof(cmd.cmd),
- (void *)datap, sizeof(datap->data), SCSIPIRETRIES, 20000, NULL,
- flags | XS_CTL_DATA_IN | XS_CTL_SILENT) != 0)
- goto out;
-
- if (_4btol(datap->data.addr) != 0xffffffff) {
- *blksize = _4btol(datap->data.length);
- rv = _4btol(datap->data.addr) + 1;
- goto out;
- }
/*
- * Device is larger than can be reflected by READ CAPACITY (10).
- * Try READ CAPACITY (16).
+ * Try READ CAPACITY (16) first, some disks don't return
+ * a correct overflow with READ CAPACITY (10).
*/
-
memset(&cmd, 0, sizeof(cmd));
cmd.cmd16.opcode = READ_CAPACITY_16;
cmd.cmd16.byte2 = SRC16_SERVICE_ACTION;
_lto4b(sizeof(datap->data16), cmd.cmd16.len);
memset(datap, 0, sizeof(datap->data16));
- if (scsipi_command(periph, (void *)&cmd.cmd16, sizeof(cmd.cmd16),
+ error = scsipi_command(periph, (void *)&cmd.cmd16, sizeof(cmd.cmd16),
(void *)datap, sizeof(datap->data16), SCSIPIRETRIES, 20000, NULL,
- flags | XS_CTL_DATA_IN | XS_CTL_SILENT) != 0)
- goto out;
+ flags | XS_CTL_DATA_IN | XS_CTL_SILENT);
- *blksize = _4btol(datap->data16.length);
- rv = _8btol(datap->data16.addr) + 1;
+ if (error == 0) {
+ *blksize = _4btol(datap->data16.length);
+ rv = _8btol(datap->data16.addr) + 1;
+ } else if (error == EINVAL) {
+ /*
+ * Fall back to READ CAPACITY (10)
+ */
+ memset(&cmd, 0, sizeof(cmd));
+ cmd.cmd.opcode = READ_CAPACITY_10;
+
+ memset(datap, 0, sizeof(datap->data));
+ error = scsipi_command(periph, (void *)&cmd.cmd, sizeof(cmd.cmd),
+ (void *)datap, sizeof(datap->data), SCSIPIRETRIES, 20000, NULL,
+ flags | XS_CTL_DATA_IN | XS_CTL_SILENT);
+ if (error == 0) {
+ if (_4btol(datap->data.addr) != 0xffffffff) {
+ *blksize = _4btol(datap->data.length);
+ rv = _4btol(datap->data.addr) + 1;
+ }
+ }
+ }
- out:
free(datap, M_TEMP);
return rv;
}
--
Michael van Elst
Internet: mlelstv@serpens.de
"A potential Snark may lurk in every tree."
From: Tracy Di Marco White <gendalia@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: kern/42122: larger than 2TB drives can't be properly found at
boot
Date: Mon, 15 Feb 2010 14:13:22 -0600
With this patch:
# dmesg|grep ^sd
sd0 at scsibus0 target 0 lun 0: <, , R0.0> disk fixed
sd0: 512, 238020 cyl, 128 head, 0 sec, 512 bytes/sect x 1 sectors
sd0: sync (6.25ns offset 127), 16-bit (320.000MB/s) transfers, tagged queue=
ing
sd1 at scsibus0 target 1 lun 0: <, , R0.0> disk fixed
sd1: 512, 178682 cyl, 128 head, 0 sec, 512 bytes/sect x 1 sectors
sd1: sync (6.25ns offset 127), 16-bit (320.000MB/s) transfers, tagged queue=
ing
sd2 at scsibus1 target 0 lun 0: <IFT, A16U-G2430, 348C> disk fixed
sd2: 512, 112619 cyl, 255 head, 0 sec, 512 bytes/sect x 1 sectors
sd2: sync (6.25ns offset 127), 16-bit (320.000MB/s) transfers, tagged queue=
ing
And things don't work, none of the scsi disks' file systems are found.
Without this patch:
bash-3.00# dmesg|grep ^sd
sd0 at scsibus0 target 0 lun 0: <, , R0.0> disk fixed
sd0: 1859 GB, 238020 cyl, 128 head, 128 sec, 512 bytes/sect x 3899719680 se=
ctors
sd0: sync (6.25ns offset 127), 16-bit (320.000MB/s) transfers, tagged queue=
ing
sd1 at scsibus0 target 1 lun 0: <, , R0.0> disk fixed
sd1: 1395 GB, 178682 cyl, 128 head, 128 sec, 512 bytes/sect x 2927525888 se=
ctors
sd1: sync (6.25ns offset 127), 16-bit (320.000MB/s) transfers, tagged queue=
ing
sd2 at scsibus1 target 0 lun 0: <IFT, A16U-G2430, 348C> disk fixed
sd2: 512, 112619 cyl, 255 head, 0 sec, 512 bytes/sect x 1 sectors
sd2: sync (6.25ns offset 127), 16-bit (320.000MB/s) transfers, tagged queue=
ing
On Wed, Jan 27, 2010 at 11:20 PM, David Holland
<dholland-bugs@netbsd.org> wrote:
> The following reply was made to PR kern/42122; it has been noted by GNATS=
.
>
> From: David Holland <dholland-bugs@netbsd.org>
> To: gnats-bugs@netbsd.org
> Cc:
> Subject: Re: kern/42122: larger than 2TB drives can't be properly found a=
t
> =A0 =A0 =A0 =A0boot
> Date: Thu, 28 Jan 2010 05:18:08 +0000
>
> =A0(wasn't sent to gnats-bugs)
>
> =A0 =A0------
>
> =A0From: Michael van Elst <mlelstv@serpens.de>
> =A0To: gnats@netbsd.org
> =A0Subject: Re: kern/42122: larger than 2TB drives can't be properly foun=
d at
> =A0 =A0 =A0 =A0boot
> =A0Date: Mon, 25 Jan 2010 13:54:06 +0100
>
>
> =A0The Array should return -1 with read_capacity_10 to signal
> =A0that read_capacity_16 is required. Apparently this is not
> =A0implemented right. A workaround is to try the read_capacity_16
> =A0first and retry with read_capacity_10 if the command wasn't
> =A0accepted (Invalid Command).
>
> =A0Does this patch help?
>
> =A0Index: sd.c
> =A0=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =A0RCS file: /cvsroot/src/sys/dev/scsipi/sd.c,v
> =A0retrieving revision 1.290
> =A0diff -u -r1.290 sd.c
> =A0--- sd.c =A0 =A0 =A0 21 Oct 2009 21:12:05 -0000 =A0 =A0 =A01.290
> =A0+++ sd.c =A0 =A0 =A0 25 Jan 2010 11:26:14 -0000
> =A0@@ -1679,9 +1679,7 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0struct scsipi_read_capacity_16_data data16=
;
> =A0 =A0 =A0 =A0} *datap;
> =A0 =A0 =A0 =A0uint64_t rv;
> =A0-
> =A0- =A0 =A0 =A0memset(&cmd, 0, sizeof(cmd));
> =A0- =A0 =A0 =A0cmd.cmd.opcode =3D READ_CAPACITY_10;
> =A0+ =A0 =A0 =A0int error;
>
> =A0 =A0 =A0 =A0/*
> =A0 =A0 =A0 =A0 * Don't allocate data buffer on stack;
> =A0@@ -1693,43 +1691,44 @@
> =A0 =A0 =A0 =A0if (datap =3D=3D NULL)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return 0;
>
> =A0- =A0 =A0 =A0/*
> =A0- =A0 =A0 =A0 * If the command works, interpret the result as a 4 byte
> =A0- =A0 =A0 =A0 * number of blocks
> =A0- =A0 =A0 =A0 */
> =A0 =A0 =A0 =A0rv =3D 0;
> =A0- =A0 =A0 =A0memset(datap, 0, sizeof(datap->data));
> =A0- =A0 =A0 =A0if (scsipi_command(periph, (void *)&cmd.cmd, sizeof(cmd.c=
md),
> =A0- =A0 =A0 =A0 =A0 =A0(void *)datap, sizeof(datap->data), SCSIPIRETRIES=
, 20000, NULL,
> =A0- =A0 =A0 =A0 =A0 =A0flags | XS_CTL_DATA_IN | XS_CTL_SILENT) !=3D 0)
> =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0goto out;
> =A0-
> =A0- =A0 =A0 =A0if (_4btol(datap->data.addr) !=3D 0xffffffff) {
> =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0*blksize =3D _4btol(datap->data.length);
> =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0rv =3D _4btol(datap->data.addr) + 1;
> =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0goto out;
> =A0- =A0 =A0 =A0}
>
> =A0 =A0 =A0 =A0/*
> =A0- =A0 =A0 =A0 * Device is larger than can be reflected by READ CAPACIT=
Y (10).
> =A0- =A0 =A0 =A0 * Try READ CAPACITY (16).
> =A0+ =A0 =A0 =A0 * Try READ CAPACITY (16) first, some disks don't return
> =A0+ =A0 =A0 =A0 * a correct overflow with READ CAPACITY (10).
> =A0 =A0 =A0 =A0 */
> =A0-
> =A0 =A0 =A0 =A0memset(&cmd, 0, sizeof(cmd));
> =A0 =A0 =A0 =A0cmd.cmd16.opcode =3D READ_CAPACITY_16;
> =A0 =A0 =A0 =A0cmd.cmd16.byte2 =3D SRC16_SERVICE_ACTION;
> =A0 =A0 =A0 =A0_lto4b(sizeof(datap->data16), cmd.cmd16.len);
>
> =A0 =A0 =A0 =A0memset(datap, 0, sizeof(datap->data16));
> =A0- =A0 =A0 =A0if (scsipi_command(periph, (void *)&cmd.cmd16, sizeof(cmd=
.cmd16),
> =A0+ =A0 =A0 =A0error =3D scsipi_command(periph, (void *)&cmd.cmd16, size=
of(cmd.cmd16),
> =A0 =A0 =A0 =A0 =A0 =A0(void *)datap, sizeof(datap->data16), SCSIPIRETRIE=
S, 20000, NULL,
> =A0- =A0 =A0 =A0 =A0 =A0flags | XS_CTL_DATA_IN | XS_CTL_SILENT) !=3D 0)
> =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0goto out;
> =A0+ =A0 =A0 =A0 =A0 =A0flags | XS_CTL_DATA_IN | XS_CTL_SILENT);
>
> =A0- =A0 =A0 =A0*blksize =3D _4btol(datap->data16.length);
> =A0- =A0 =A0 =A0rv =3D _8btol(datap->data16.addr) + 1;
> =A0+ =A0 =A0 =A0if (error =3D=3D 0) {
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0*blksize =3D _4btol(datap->data16.length)=
;
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0rv =3D _8btol(datap->data16.addr) + 1;
> =A0+ =A0 =A0 =A0} else if (error =3D=3D EINVAL) {
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0/*
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 * Fall back to READ CAPACITY (10)
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 */
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0memset(&cmd, 0, sizeof(cmd));
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0cmd.cmd.opcode =3D READ_CAPACITY_10;
> =A0+
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0memset(datap, 0, sizeof(datap->data));
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0error =3D scsipi_command(periph, (void *)=
&cmd.cmd, sizeof(cmd.cmd),
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(void *)datap, sizeof(datap->data=
), SCSIPIRETRIES, 20000, NULL,
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0flags | XS_CTL_DATA_IN | XS_CTL_S=
ILENT);
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0if (error =3D=3D 0) {
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (_4btol(datap->data.ad=
dr) !=3D 0xffffffff) {
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*blksize =
=3D _4btol(datap->data.length);
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0rv =3D _4=
btol(datap->data.addr) + 1;
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
> =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0}
> =A0+ =A0 =A0 =A0}
>
> =A0- out:
> =A0 =A0 =A0 =A0free(datap, M_TEMP);
> =A0 =A0 =A0 =A0return rv;
> =A0}
>
> =A0--
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Michael v=
an Elst
> =A0Internet: mlelstv@serpens.de
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "A potent=
ial Snark may lurk in every tree."
>
>
State-Changed-From-To: open->feedback
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 27 May 2019 02:42:13 +0000
State-Changed-Why:
Is this still an issue?
State-Changed-From-To: feedback->open
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 11 Dec 2024 20:43:21 +0000
State-Changed-Why:
feedback timeout
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.47 2022/09/11 19:34:41 kim Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2024
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home